Skip to contentSkip to conversation

devpts: Fix type for uid and gid params

PATCH Applied David Howells 2 participants 2 messages Apr 2, 2025 – Apr 3, 2025 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devpts: Fix type for uid and gid params

Fix devpts to parse uid and gid params using the correct type so that they get interpreted in the context of the user namespace.

Fixes cc0876f817d6 ("vfs: Convert devpts to use the new mount API")
cc Eric Sandeen <[email protected]>
---
 fs/devpts/inode.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/devpts/inode.c +2 -2
index 42e4d6eeb29f..9c20d78e41f6 100644
@@ -89,12 +89,12 @@ enum {
 };
 
 static const struct fs_parameter_spec devpts_param_specs[] = {
-	fsparam_u32	("gid",		Opt_gid),
+	fsparam_gid	("gid",		Opt_gid),
 	fsparam_s32	("max",		Opt_max),
 	fsparam_u32oct	("mode",	Opt_mode),
 	fsparam_flag	("newinstance",	Opt_newinstance),
 	fsparam_u32oct	("ptmxmode",	Opt_ptmxmode),
-	fsparam_u32	("uid",		Opt_uid),
+	fsparam_uid	("uid",		Opt_uid),
 	{}
 };
 
maintainer Applied
#1 lore raw
Quoted 5 lines · David Howells

Fix devpts to parse uid and gid params using the correct type so that they get interpreted in the context of the user namespace.

Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] devpts: Fix type for uid and gid params

      https://git.kernel.org/vfs/vfs/c/b478f56b7866