Skip to contentSkip to conversation

virtio-gpu: support blob alignment information

PATCH Superseded Sergio Lopez 2 participants 3 messages Apr 3, 2025

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-gpu: support blob alignment information

Allow the device to require certain alignment constrains for blob resources by extending the device configuration with the field "blob_alignment" and introducing the VIRTIO_GPU_F_BLOB_ALIGNMENT feature.

---
 device-types/gpu/description.tex | 12 ++++++++++++
 1 file changed, 12 insertions(+)
device-types/gpu/description.tex +12 -0
index 4435248..8e5258d 100644
@@ -37,6 +37,8 @@ \subsection{Feature bits}\label{sec:Device Types / GPU Device / Feature bits}
   resources is supported.
 \item[VIRTIO_GPU_F_CONTEXT_INIT (4)] multiple context types and
   synchronization timelines supported.  Requires VIRTIO_GPU_F_VIRGL.
+\item[VIRTIO_GPU_F_BLOB_ALIGNMENT (5)] configuration field
+  \field{blob_alignment} is valid. Requires VIRTIO_GPU_F_RESOURCE_BLOB.
 \end{description}
 
 \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / Device configuration layout}
@@ -52,6 +54,7 @@ \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / D
         le32 events_clear;
         le32 num_scanouts;
         le32 num_capsets;
+        le32 blob_alignment;
 };
 \end{lstlisting}
 
@@ -67,6 +70,8 @@ \subsubsection{Device configuration fields}
   supported by the device.  Minimum value is 1, maximum value is 16.
 \item[\field{num_capsets}] specifies the maximum number of capability
   sets supported by the device.  The minimum value is zero.
+\item[\field{blob_alignment}] specifies the byte alignment required by
+  the device for resource blobs.
 \end{description}
 
 \subsubsection{Events}
@@ -672,6 +677,9 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 resource. There is no restriction on the image/buffer view the driver
 has on the blob resource.
 
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set, \field{size} must be aligned to
+\field{blob_alignment} as defined in the device configuration.
+
 \item[VIRTIO_GPU_CMD_SET_SCANOUT_BLOB] sets scanout parameters for a
    blob resource. Request data is
   \field{struct virtio_gpu_set_scanout_blob}. Response type is
@@ -776,6 +784,10 @@ \subsubsection{Device Operation: controlq (3d)}\label{sec:Device Types / GPU Dev
 };
 \end{lstlisting}
 
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set, \field{padding} and \field{offset}
+must be aligned to \field{blob_alignment} as defined in the device
+configuration.
+
 \item[VIRTIO_GPU_CMD_RESOURCE_UNMAP_BLOB] unmaps a
   host-only blob resource from the host visible memory region. Request data
   is \field{struct virtio_gpu_resource_unmap_blob}.  Response type is
Signature · 1 line
2.49.0
#1 lore raw
Quoted 32 lines · Sergio Lopez

Allow the device to require certain alignment constrains for blob resources by extending the device configuration with the field "blob_alignment" and introducing the VIRTIO_GPU_F_BLOB_ALIGNMENT feature.

---
 device-types/gpu/description.tex | 12 ++++++++++++
 1 file changed, 12 insertions(+)
device-types/gpu/description.tex +3 -0
index 4435248..8e5258d 100644
@@ -37,6 +37,8 @@ \subsection{Feature bits}\label{sec:Device Types / GPU Device / Feature bits}
   resources is supported.
 \item[VIRTIO_GPU_F_CONTEXT_INIT (4)] multiple context types and
   synchronization timelines supported.  Requires VIRTIO_GPU_F_VIRGL.
+\item[VIRTIO_GPU_F_BLOB_ALIGNMENT (5)] configuration field
+  \field{blob_alignment} is valid. Requires VIRTIO_GPU_F_RESOURCE_BLOB.
 \end{description}
 
 \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / Device configuration layout}
@@ -52,6 +54,7 @@ \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / D
         le32 events_clear;
         le32 num_scanouts;
         le32 num_capsets;
+        le32 blob_alignment;
 };
 \end{lstlisting}
 

device-types/gpu/description.tex \subsubsection{Device configuration fields} · line 74

Quoted 5 lines
device-types/gpu/description.tex +2 -0
@@ -67,6 +70,8 @@ \subsubsection{Device configuration fields}
   supported by the device.  Minimum value is 1, maximum value is 16.
 \item[\field{num_capsets}] specifies the maximum number of capability
   sets supported by the device.  The minimum value is zero.
+\item[\field{blob_alignment}] specifies the byte alignment required by
+  the device for resource blobs.

byte alignment means no alignment restrictions.
I think "alignment, in bytes"?
I also think you mean the minimal alignment.

Also please specify the legal values, like other fields do. Is 2G alignment always going to be sufficient, in your opinion?

device-types/gpu/description.tex \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device / · line 682

Quoted 10 lines
device-types/gpu/description.tex +3 -0
 \end{description}
 
 \subsubsection{Events}
@@ -672,6 +677,9 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 resource. There is no restriction on the image/buffer view the driver
 has on the blob resource.
 
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set, \field{size} must be aligned to
+\field{blob_alignment} as defined in the device configuration.
+

set where? you mean has been negotiated?

device-types/gpu/description.tex \subsubsection{Device Operation: controlq (3d)}\label{sec:Device Types / GPU Dev · line 787

Quoted 8 lines
device-types/gpu/description.tex +1 -0
 \item[VIRTIO_GPU_CMD_SET_SCANOUT_BLOB] sets scanout parameters for a
    blob resource. Request data is
   \field{struct virtio_gpu_set_scanout_blob}. Response type is
@@ -776,6 +784,10 @@ \subsubsection{Device Operation: controlq (3d)}\label{sec:Device Types / GPU Dev
 };
 \end{lstlisting}
 
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set,

same

Quoted 9 lines
device-types/gpu/description.tex +3 -0
 \field{padding} and \field{offset}
+must be aligned to \field{blob_alignment} as defined in the device
+configuration.
+
 \item[VIRTIO_GPU_CMD_RESOURCE_UNMAP_BLOB] unmaps a
   host-only blob resource from the host visible memory region. Request data

is \field{struct virtio_gpu_resource_unmap_blob}. Response type is

Signature · 1 line
2.49.0
#2 lore raw
Quoted 32 lines · Michael S. Tsirkin
Quoted 31 lines · Sergio Lopez

Allow the device to require certain alignment constrains for blob resources by extending the device configuration with the field "blob_alignment" and introducing the VIRTIO_GPU_F_BLOB_ALIGNMENT feature.

---
 device-types/gpu/description.tex | 12 ++++++++++++
 1 file changed, 12 insertions(+)
device-types/gpu/description.tex +3 -0
index 4435248..8e5258d 100644
@@ -37,6 +37,8 @@ \subsection{Feature bits}\label{sec:Device Types / GPU Device / Feature bits}
   resources is supported.
 \item[VIRTIO_GPU_F_CONTEXT_INIT (4)] multiple context types and
   synchronization timelines supported.  Requires VIRTIO_GPU_F_VIRGL.
+\item[VIRTIO_GPU_F_BLOB_ALIGNMENT (5)] configuration field
+  \field{blob_alignment} is valid. Requires VIRTIO_GPU_F_RESOURCE_BLOB.
 \end{description}
 
 \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / Device configuration layout}
@@ -52,6 +54,7 @@ \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / D
         le32 events_clear;
         le32 num_scanouts;
         le32 num_capsets;
+        le32 blob_alignment;
 };
 \end{lstlisting}
 
Quoted 10 lines

device-types/gpu/description.tex \subsubsection{Device configuration fields} · line 74

Quoted 6 lines
device-types/gpu/description.tex +2 -0
@@ -67,6 +70,8 @@ \subsubsection{Device configuration fields}
   supported by the device.  Minimum value is 1, maximum value is 16.
 \item[\field{num_capsets}] specifies the maximum number of capability
   sets supported by the device.  The minimum value is zero.
+\item[\field{blob_alignment}] specifies the byte alignment required by
+  the device for resource blobs.

byte alignment means no alignment restrictions.
I think "alignment, in bytes"?
I also think you mean the minimal alignment.

OK, I'll replace it with "(...) minimal alignment, in bytes (...)"

Quoted 2 lines

Also please specify the legal values, like other fields do. Is 2G alignment always going to be sufficient, in your opinion?

We know it must be a power of two, and the minimum value is 1 (2^0), but I'm not sure what to specify as maximum value. Should we state that is 4294967296 (2^32) even if we know it doesn't make sense in practice?

Quoted 7 lines
Quoted 7 lines
device-types/gpu/description.tex +0 -0
 \end{description}
 
 \subsubsection{Events}
@@ -672,6 +677,9 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 resource. There is no restriction on the image/buffer view the driver
 has on the blob resource.
 
Quoted 5 lines

device-types/gpu/description.tex \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device / · line 682

Quoted 3 lines
device-types/gpu/description.tex +3 -0
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set, \field{size} must be aligned to
+\field{blob_alignment} as defined in the device configuration.
+

set where? you mean has been negotiated?

Here I was just mimicking the style from the previous paragraph:

---
If VIRTIO_GPU_F_VIRGL is set, both VIRTIO_GPU_CMD_TRANSFER_TO_HOST_3D and VIRTIO_GPU_CMD_TRANSFER_FROM_HOST_3D may be used to update the resource. There is no restriction on the image/buffer view the driver has on the blob resource.
---

Thanks!
Sergio.