Skip to contentSkip to conversation

target/i386: hvf: fix lflags_to_rflags

PATCH In review Paolo Bonzini 2 participants 2 messages Apr 3, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/i386: hvf: fix lflags_to_rflags

Clear the flags before adding in the ones computed from lflags.

---
 target/i386/hvf/x86_flags.c | 1 +
 1 file changed, 1 insertion(+)
target/i386/hvf/x86_flags.c +1 -0
index 32772c359e9..31d76c067bf 100644
@@ -284,6 +284,7 @@ void set_SF(CPUX86State *env, bool val)
 
 void lflags_to_rflags(CPUX86State *env)
 {
+    env->eflags &= ~(CC_C|CC_P|CC_A|CC_P|CC_Z|CC_S|CC_O);
     env->eflags |= get_CF(env) ? CC_C : 0;
     env->eflags |= get_PF(env) ? CC_P : 0;
     env->eflags |= get_AF(env) ? CC_A : 0;
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Paolo Bonzini

Clear the flags before adding in the ones computed from lflags.

---
  target/i386/hvf/x86_flags.c | 1 +
  1 file changed, 1 insertion(+)
target/i386/hvf/x86_flags.c +0 -0
index 32772c359e9..31d76c067bf 100644

target/i386/hvf/x86_flags.c void set_SF(CPUX86State *env, bool val) · line 287

Quoted 4 lines
target/i386/hvf/x86_flags.c +1 -0
@@ -284,6 +284,7 @@ void set_SF(CPUX86State *env, bool val)
 
  void lflags_to_rflags(CPUX86State *env)
  {
+    env->eflags &= ~(CC_C|CC_P|CC_A|CC_P|CC_Z|CC_S|CC_O);

CC_P is twice, otherwise:

Quoted 3 lines
target/i386/hvf/x86_flags.c +0 -0
      env->eflags |= get_CF(env) ? CC_C : 0;
      env->eflags |= get_PF(env) ? CC_P : 0;
      env->eflags |= get_AF(env) ? CC_A : 0;