Skip to contentSkip to conversation

staging: rtl8723bs: Remove trailing whitespace

PATCH Superseded Gabriel Shahrouzi 2 participants 4 messages Apr 2, 2025 – Apr 4, 2025 Staging

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: Remove trailing whitespace

Remove trailing whitespace to comply with kernel coding style.

---
Changes in v2:
- Resend using git send-email to fix formatting issues in email body.

---
 drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
staging/rtl8723bs/include/hal_pwr_seq.h +1 -1
index b93d74a5b9a5..48bf7f66a06e 100644
@@ -209,7 +209,7 @@
 #define RTL8723B_TRANS_END															\
 	/* format */																\
 	/* { offset, cut_msk, fab_msk|interface_msk, base|cmd, msk, value }, comments here*/								\
-	{0xFFFF, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, 0, PWR_CMD_END, 0, 0}, 
+	{0xFFFF, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_ALL_MSK, 0, PWR_CMD_END, 0, 0},
 
 
 extern struct wlan_pwr_cfg rtl8723B_power_on_flow[RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS];
Signature · 1 line
2.43.0
maintainer
#1 lore raw

staging/rtl8723bs/include/hal_pwr_seq.h

Quoted 14 lines · Gabriel Shahrouzi

Remove trailing whitespace to comply with kernel coding style.

---
Changes in v2:
- Resend using git send-email to fix formatting issues in email body.

---
 drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
staging/rtl8723bs/include/hal_pwr_seq.h +0 -0
index b93d74a5b9a5..48bf7f66a06e 100644

This wasn't made with git, was it? You are "one" indent level off, the diff should say:

--- a/drivers/staging/rtl8723bs/include/hal_pwr_seq.h +++ b/drivers/staging/rtl8723bs/include/hal_pwr_seq.h

here, right?

Anyway, because of that, this does not apply to the tree at all :(

Please fix and send a v3.

thanks,

greg k-h

author
#2 lore raw
Quoted 12 lines · Greg KH
Quoted 10 lines · Gabriel Shahrouzi

Remove trailing whitespace to comply with kernel coding style.

---
Changes in v2:
- Resend using git send-email to fix formatting issues in the email body.

---
 drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines

staging/rtl8723bs/include/hal_pwr_seq.h

Quoted 4 lines
staging/rtl8723bs/include/hal_pwr_seq.h +0 -0
index b93d74a5b9a5..48bf7f66a06e 100644

This wasn't made with git, was it? You are "one" indent level off, the diff should say:

Interesting. Not entirely certain how this happened. Since it was from an earlier commit I made, I rebased it, amended the changes, and then formatted another patch using git. Apparently one of my other patches for an earlier version had the same problem but the subsequent version has the correct indent.

Quoted 5 lines
drivers/staging/rtl8723bs/include/hal_pwr_seq.h +0 -0

here, right?

Yes.

Quoted 4 lines

Anyway, because of that, this does not apply to the tree at all :(

Please fix and send a v3.

Got it.

Quoted 4 lines

thanks,

greg k-h

Quoted 32 lines · Greg KH

staging/rtl8723bs/include/hal_pwr_seq.h

Quoted 14 lines · Gabriel Shahrouzi

Remove trailing whitespace to comply with kernel coding style.

---
Changes in v2:
- Resend using git send-email to fix formatting issues in email body.

---
 drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
staging/rtl8723bs/include/hal_pwr_seq.h +0 -0
index b93d74a5b9a5..48bf7f66a06e 100644

This wasn't made with git, was it? You are "one" indent level off, the diff should say:

drivers/staging/rtl8723bs/include/hal_pwr_seq.h +0 -0

here, right?

Anyway, because of that, this does not apply to the tree at all :(

Please fix and send a v3.

thanks,

greg k-h

author
#3 lore raw
Quoted 68 lines · Gabriel
Quoted 12 lines · Greg KH
Quoted 10 lines · Gabriel Shahrouzi

Remove trailing whitespace to comply with kernel coding style.

---
Changes in v2:
- Resend using git send-email to fix formatting issues in the email body.

---
 drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines

staging/rtl8723bs/include/hal_pwr_seq.h

Quoted 4 lines
staging/rtl8723bs/include/hal_pwr_seq.h +0 -0
index b93d74a5b9a5..48bf7f66a06e 100644

This wasn't made with git, was it? You are "one" indent level off, the diff should say:

Interesting. Not entirely certain how this happened. Since it was from an earlier commit I made, I rebased it, amended the changes, and then formatted another patch using git. Apparently one of my other patches for an earlier version had the same problem but the subsequent version has the correct indent.

Quoted 5 lines
drivers/staging/rtl8723bs/include/hal_pwr_seq.h +0 -0

here, right?

Yes.

Quoted 4 lines

Anyway, because of that, this does not apply to the tree at all :(

Please fix and send a v3.

Got it.

Quoted 4 lines

thanks,

greg k-h

Quoted 25 lines · Greg KH

staging/rtl8723bs/include/hal_pwr_seq.h

Quoted 14 lines · Gabriel Shahrouzi

Remove trailing whitespace to comply with kernel coding style.

---
Changes in v2:
- Resend using git send-email to fix formatting issues in email body.

---
 drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
staging/rtl8723bs/include/hal_pwr_seq.h +0 -0
index b93d74a5b9a5..48bf7f66a06e 100644

This wasn't made with git, was it? You are "one" indent level off, the diff should say:

drivers/staging/rtl8723bs/include/hal_pwr_seq.h +0 -0

here, right?

Quoted 7 lines
Quoted 7 lines

Anyway, because of that, this does not apply to the tree at all :(

Please fix and send a v3.

thanks,

greg k-h

Apologies for the duplicate post. I initially replied only to one person by accident and have resent it using 'reply all'