Skip to contentSkip to conversation

selftests: ublk: fix test_stripe_04

PATCH Applied Ming Lei 3 participants 5 messages Apr 4, 2025

Subsystems (4)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Ming Lei

author
#0 lore raw

PATCH 1/1 selftests: ublk: fix test_stripe_04

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") added test entry of test_stripe_04, but forgot to add the test script.

So fix the test by adding the script file.

---
 .../testing/selftests/ublk/test_stripe_04.sh  | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100755 tools/testing/selftests/ublk/test_stripe_04.sh
tools/testing/selftests/ublk/test_stripe_04.sh new file +24 -0
new file mode 100755
index 000000000000..1f2b642381d1
@@ -0,0 +1,24 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+. "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
+
+TID="stripe_04"
+ERR_CODE=0
+
+_prep_test "stripe" "mkfs & mount & umount on zero copy"
+
+backfile_0=$(_create_backfile 256M)
+backfile_1=$(_create_backfile 256M)
+dev_id=$(_add_ublk_dev -t stripe -z -q 2 "$backfile_0" "$backfile_1")
+_check_add_dev $TID $? "$backfile_0" "$backfile_1"
+
+_mkfs_mount_test /dev/ublkb"${dev_id}"
+ERR_CODE=$?
+
+_cleanup_test "stripe"
+
+_remove_backfile "$backfile_0"
+_remove_backfile "$backfile_1"
+
+_show_result $TID $ERR_CODE
Signature · 1 line
2.47.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ming Lei

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") added test entry of test_stripe_04, but forgot to add the test script.

So fix the test by adding the script file.

Thanks for the quick fix!

Quoted 38 lines
---
 .../testing/selftests/ublk/test_stripe_04.sh  | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100755 tools/testing/selftests/ublk/test_stripe_04.sh
tools/testing/selftests/ublk/test_stripe_04.sh new file +24 -0
new file mode 100755
index 000000000000..1f2b642381d1
@@ -0,0 +1,24 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+. "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
+
+TID="stripe_04"
+ERR_CODE=0
+
+_prep_test "stripe" "mkfs & mount & umount on zero copy"
+
+backfile_0=$(_create_backfile 256M)
+backfile_1=$(_create_backfile 256M)
+dev_id=$(_add_ublk_dev -t stripe -z -q 2 "$backfile_0" "$backfile_1")
+_check_add_dev $TID $? "$backfile_0" "$backfile_1"
+
+_mkfs_mount_test /dev/ublkb"${dev_id}"
+ERR_CODE=$?
+
+_cleanup_test "stripe"
+
+_remove_backfile "$backfile_0"
+_remove_backfile "$backfile_1"
+
+_show_result $TID $ERR_CODE
Signature · 1 line
2.47.1
maintainer Applied
#2 lore raw
In reply to Ming Lei
Quoted 6 lines · Ming Lei

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") added test entry of test_stripe_04, but forgot to add the test script.

So fix the test by adding the script file.

Applied, thanks!

[1/1] selftests: ublk: fix test_stripe_04
(no commit info)

Best regards,

Signature · 1 line
Jens Axboe
author
#3 lore raw
Quoted 5 lines · Jens Axboe
Quoted 3 lines · Ming Lei

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") added test entry of test_stripe_04, but forgot to add the test script.

Quoted 8 lines
Quoted 3 lines

So fix the test by adding the script file.

Applied, thanks!

[1/1] selftests: ublk: fix test_stripe_04
(no commit info)

Hi Jens,

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") is in io_uring-6.15, so this patch should be merged to io_uring-6.15 instead of block-6.15.

Thanks,
Ming

maintainer
#4 lore raw
Quoted 12 lines · Ming Lei
Quoted 11 lines · Jens Axboe
Quoted 6 lines · Ming Lei

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") added test entry of test_stripe_04, but forgot to add the test script.

So fix the test by adding the script file.

Applied, thanks!

Quoted 8 lines
Quoted 2 lines

[1/1] selftests: ublk: fix test_stripe_04
(no commit info)

Hi Jens,

Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target") is in io_uring-6.15, so this patch should be merged to io_uring-6.15 instead of block-6.15.

Both branches already went to Linus yesterday, which is why this one is in the block branch now as there are no dependencies left.

Signature · 1 line
Jens Axboe