Skip to contentSkip to conversation

cobalt/dovetail: Fill fault statistics counters

PATCH Applied Richard Weinberger 2 participants 2 messages Apr 4, 2025 – Apr 5, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cobalt/dovetail: Fill fault statistics counters

/proc/xenomai/faults reports always zeros on dovetail. Looks like filling these counters was forgotten for the dovetail case.

---
 kernel/cobalt/dovetail/kevents.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/cobalt/dovetail/kevents.c +2 -0
index 0f70dbc27..9fa75faa1 100644
@@ -43,6 +43,8 @@ void handle_oob_trap_entry(unsigned int trapnr, struct pt_regs *regs)
 	 */
 	trace_cobalt_thread_fault(xnarch_fault_pc(regs), trapnr);
 
+	raw_cpu_ptr(&cobalt_machine_cpudata)->faults[trapnr]++;
+
 	if (xnthread_test_state(thread, XNROOT))
 		return;
 
Signature · 1 line
2.43.0
Applied
#1 lore raw
Quoted 14 lines · Richard Weinberger

/proc/xenomai/faults reports always zeros on dovetail. Looks like filling these counters was forgotten for the dovetail case.

---
 kernel/cobalt/dovetail/kevents.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/cobalt/dovetail/kevents.c +0 -0
index 0f70dbc27..9fa75faa1 100644

kernel/cobalt/dovetail/kevents.c void handle_oob_trap_entry(unsigned int trapnr, struct pt_regs *regs) · line 50

Quoted 8 lines
kernel/cobalt/dovetail/kevents.c +2 -0
@@ -43,6 +43,8 @@ void handle_oob_trap_entry(unsigned int trapnr, struct pt_regs *regs)
 	 */
 	trace_cobalt_thread_fault(xnarch_fault_pc(regs), trapnr);
 
+	raw_cpu_ptr(&cobalt_machine_cpudata)->faults[trapnr]++;
+
 	if (xnthread_test_state(thread, XNROOT))
 		return;
 

Thanks, applied.

Jan

Signature · 2 lines
Siemens AG, Foundational Technologies
Linux Expert Center