Skip to contentSkip to conversation

media: qcom: camss: vfe: suppress VFE version log spam

PATCH In review Johan Hovold 2 participants 2 messages Apr 7, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: qcom: camss: vfe: suppress VFE version log spam

A recent commit refactored the printing of the VFE hardware version, but (without it being mentioned) also changed the log level from debug to info.

This results in several hundred lines of repeated log spam during boot and use, for example, on the Lenovo ThinkPad X13s:

	qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
	...

Suppress the version logging by demoting to debug level again.

Cc Depeng Shao <[email protected]>
Fixes 10693fed125d ("media: qcom: camss: vfe: Move common code into vfe core")
---
 drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-vfe.c +1 -1
index cf0e8f5c004a..1ed2518c7a6b 100644
@@ -428,7 +428,7 @@ u32 vfe_hw_version(struct vfe_device *vfe)
 	u32 rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
 	u32 step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
 
-	dev_info(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
+	dev_dbg(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
 		 vfe->id, gen, rev, step);
 
 	return hw_version;
Signature · 1 line
2.49.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 36 lines · Johan Hovold

A recent commit refactored the printing of the VFE hardware version, but (without it being mentioned) also changed the log level from debug to info.

This results in several hundred lines of repeated log spam during boot and use, for example, on the Lenovo ThinkPad X13s:

	qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
	qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
	...

Suppress the version logging by demoting to debug level again.

Cc Depeng Shao <[email protected]>
Fixes 10693fed125d ("media: qcom: camss: vfe: Move common code into vfe core")
---
  drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-vfe.c +0 -0
index cf0e8f5c004a..1ed2518c7a6b 100644

drivers/media/platform/qcom/camss/camss-vfe.c u32 vfe_hw_version(struct vfe_device *vfe) · line 434

Quoted 8 lines
drivers/media/platform/qcom/camss/camss-vfe.c +1 -1
@@ -428,7 +428,7 @@ u32 vfe_hw_version(struct vfe_device *vfe)
  	u32 rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
  	u32 step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
 
-	dev_info(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
+	dev_dbg(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
  		 vfe->id, gen, rev, step);
 
  	return hw_version;