cpufreq/amd-pstate: Fix min_limit perf and freq updation for performance governor
Subsystems (2)
PATCH 1/1 cpufreq/amd-pstate: Fix min_limit perf and freq updation for performance governor
The min_limit perf and freq values can get disconnected with performance governor, as we only modify the perf value in the special case. Fix that by modifying the perf and freq values together
Fixes 009d1c29a451 ("cpufreq/amd-pstate: Move perf values into a union")
Signed-off-by Dhananjay Ugwekar <[email protected]>
--- drivers/cpufreq/amd-pstate.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/cpufreq/amd-pstate.c +7 -4
@@ -607,13 +607,16 @@ static void amd_pstate_update_min_max_limit(struct cpufreq_policy *policy)union perf_cached perf =READ_ONCE (cpudata->perf); perf.max_limit_perf =freq_to_perf (perf, cpudata->nominal_freq, policy->max); - perf.min_limit_perf =freq_to_perf (perf, cpudata->nominal_freq, policy->min); +WRITE_ONCE (cpudata->max_limit_freq, policy->max); -if (cpudata->policy ==CPUFREQ_POLICY_PERFORMANCE ) +if (cpudata->policy ==CPUFREQ_POLICY_PERFORMANCE ) { perf.min_limit_perf =min (perf.nominal_perf, perf.max_limit_perf); +WRITE_ONCE (cpudata->min_limit_freq,min (cpudata->nominal_freq, cpudata->max_limit_freq)); + }else { + perf.min_limit_perf =freq_to_perf (perf, cpudata->nominal_freq, policy->min); +WRITE_ONCE (cpudata->min_limit_freq, policy->min); + } -WRITE_ONCE (cpudata->max_limit_freq, policy->max); -WRITE_ONCE (cpudata->min_limit_freq, policy->min);WRITE_ONCE (cpudata->perf, perf); }
Signature · 1 line
2.34.1
Quoted 6 lines · Dhananjay Ugwekar
The
min_limitperf and freq values can get disconnected with performance governor, as we only modify the perf value in the special case. Fix that by modifying the perf and freq values togetherFixes 009d1c29a451 ("cpufreq/amd-pstate: Move perf values into a union")Signed-off-by Dhananjay Ugwekar <[email protected]>
Reviewed-by Mario Limonciello <[email protected]>
Thanks! I'll get this added to bleeding-edge and move it to fixes in a few days.
Quoted 29 lines
--- drivers/cpufreq/amd-pstate.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)drivers/cpufreq/amd-pstate.c +7
-4@@ -607,13 +607,16 @@ static void amd_pstate_update_min_max_limit(struct cpufreq_policy *policy)union perf_cached perf =READ_ONCE (cpudata->perf); perf.max_limit_perf =freq_to_perf (perf, cpudata->nominal_freq, policy->max); - perf.min_limit_perf =freq_to_perf (perf, cpudata->nominal_freq, policy->min); +WRITE_ONCE (cpudata->max_limit_freq, policy->max); -if (cpudata->policy ==CPUFREQ_POLICY_PERFORMANCE ) +if (cpudata->policy ==CPUFREQ_POLICY_PERFORMANCE ) { perf.min_limit_perf =min (perf.nominal_perf, perf.max_limit_perf); +WRITE_ONCE (cpudata->min_limit_freq,min (cpudata->nominal_freq, cpudata->max_limit_freq)); + }else { + perf.min_limit_perf =freq_to_perf (perf, cpudata->nominal_freq, policy->min); +WRITE_ONCE (cpudata->min_limit_freq, policy->min); + } -WRITE_ONCE (cpudata->max_limit_freq, policy->max); -WRITE_ONCE (cpudata->min_limit_freq, policy->min);WRITE_ONCE (cpudata->perf, perf); }