net: ena: Support persistent per-NAPI config.
Subsystems (3)
PATCH 1/1 net: ena: Support persistent per-NAPI config.
Let's pass the queue index to netif_napi_add_config() to preserve per-NAPI config.
Test:
Set 100 to defer-hard-irqs (default is 0) and check the value after link down & up.
$ cat /sys/class/net/enp39s0/napi_defer_hard_irqs 0
$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
--dump napi-get --json='{"ifindex": 2}'
[{'defer-hard-irqs': 0,
'gro-flush-timeout': 0,
'id': 65,
'ifindex': 2,
'irq': 29,
'irq-suspend-timeout': 0}] $ sudo ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
--do napi-set --json='{"id": 65, "defer-hard-irqs": 100}'$ sudo ip link set enp39s0 down && sudo ip link set enp39s0 up
Without patch:
$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
--dump napi-get --json='{"ifindex": 2}'
[{'defer-hard-irqs': 0, <------------------- Reset to 0
'gro-flush-timeout': 0,
'id': 66, <------------------------------- New ID
'ifindex': 2,
'irq': 29,
'irq-suspend-timeout': 0}]With patch:
$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
--dump napi-get --json='{"ifindex": 2}'
[{'defer-hard-irqs': 100, <--------------+-- Preserved
'gro-flush-timeout': 0, |
'id': 65, <----------------------------'
'ifindex': 2,
'irq': 29,
'irq-suspend-timeout': 0}]--- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/amazon/ena/ena_netdev.c +1 -1
@@ -1777,7 +1777,7 @@ static void ena_init_napi_in_range(struct ena_adapter *adapter,if (ENA_IS_XDP_INDEX (adapter, i)) napi_handler = ena_xdp_io_poll; -netif_napi_add (adapter->netdev, &napi->napi, napi_handler); +netif_napi_add_config (adapter->netdev, &napi->napi, napi_handler, i);if (!ENA_IS_XDP_INDEX (adapter, i)) napi->rx_ring = rx_ring;
Signature · 1 line
2.48.1
Quoted 47 lines · Kuniyuki Iwashima
Let's pass the queue index to
netif_napi_add_config()to preserve per-NAPI config.Test:
Set 100 to defer-hard-irqs (default is 0) and check the value after link down & up.
$ cat /sys/class/net/enp39s0/napi_defer_hard_irqs 0$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \ --dump napi-get --json='{"ifindex": 2}' [{'defer-hard-irqs': 0, 'gro-flush-timeout': 0, 'id': 65, 'ifindex': 2, 'irq': 29, 'irq-suspend-timeout': 0}]$ sudo ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \ --do napi-set --json='{"id": 65, "defer-hard-irqs": 100}'$ sudo ip link set enp39s0 down && sudo ip link set enp39s0 upWithout patch:
$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \ --dump napi-get --json='{"ifindex": 2}' [{'defer-hard-irqs': 0, <------------------- Reset to 0 'gro-flush-timeout': 0, 'id': 66, <------------------------------- New ID 'ifindex': 2, 'irq': 29, 'irq-suspend-timeout': 0}]With patch:
$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \ --dump napi-get --json='{"ifindex": 2}' [{'defer-hard-irqs': 100, <--------------+-- Preserved 'gro-flush-timeout': 0, | 'id': 65, <----------------------------' 'ifindex': 2, 'irq': 29, 'irq-suspend-timeout': 0}]
Quoted 4 lines
Signed-off-by Kuniyuki Iwashima <[email protected]>--- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you for adding support for this!
Quoted 8 lines · Kuniyuki
Let's pass the queue index to
netif_napi_add_config()to preserve per-NAPI config.Signed-off-by Kuniyuki Iwashima <[email protected]>--- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you for submitting this patch!
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Mon, 7 Apr 2025 09:47:59 -0700 you wrote:
Let's pass the queue index to
netif_napi_add_config()to preserve per-NAPI config.Test:
Set 100 to defer-hard-irqs (default is 0) and check the value after link down & up.
[...]
Here is the summary with links:
- [v1,net-next] net: ena: Support persistent per-NAPI config.
https://git.kernel.org/netdev/net-next/c/0f681b0ecd19
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html