staging: rtl8723bs: Use % 4096u instead of & 0xfff
PATCH v3 1/1 staging: rtl8723bs: Use % 4096u instead of & 0xfff
The sequence number is constrained to a range of [0, 4095], which is a total of 4096 values. The bitmask operation using 0xfff is used to perform this wrap-around. While this is functionally correct, it obscures the intended semantic of a 4096-based wrap.
Using a modulo operation with 4096u makes the wrap-around logic explicit and easier to understand. It clearly signals that the sequence number cycles though a range of 4096 values.
The use of 4096u also guarantees that the modulo operation is performed with unsigned arithmetic, preventing potential issues with signed types.
David Laight <[email protected]>
---
Changes in v2:
- Changed the commit message to a more descriptive message which makes it clear why the patch does the change.
- Changed the subject title to include 4096u to show that an unsigned module is used.
Changes in v1:
- Added more patch recipients.
drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +3 -3
@@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (psta) { psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=0xFFF ; + psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=4096u ; pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];SetSeqNum (hdr, pattrib->seqnum);
@@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (SN_LESS (pattrib->seqnum, tx_seq)) { pattrib->ampdu_en = false;/* AGG BK */ }else if (SN_EQUAL (pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq+1 )&4096u ; pattrib->ampdu_en = true;/* AGG EN */ }else { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum+1 )&4096u ; pattrib->ampdu_en = true;/* AGG EN */ } }
Signature · 1 line
2.34.1
Quoted 6 lines · Abraham Samuel Adekunle
The sequence number is constrained to a range of [0, 4095], which is a total of 4096 values. The bitmask operation using
0xfffis used to perform this wrap-around. While this is functionally correct, it obscures the intended semantic of a 4096-based wrap.
Quoted 6 lines
Using a modulo operation with
4096umakes the wrap-around logic explicit and easier to understand. It clearly signals that the sequence number cycles though a range of 4096 values.The use of
4096ualso guarantees that the modulo operation is performed with unsigned arithmetic, preventing potential issues with signed types.
Also there are a couple of important things about modulo vs. AND:
The modulo use for wrapping around is making code robust against potential changes of the upper range, especially when it becomes non-power-of-2 value, the AND works solely for power-of-2 values. The modulo in case of power-of-2 is optimised by the compiler to the same or equivalent code.
Quoted 2 lines
Suggested-by Andy Shevchenko <[email protected]>David Laight <[email protected]>
Not sure what tag David's name is meant for.
Quoted 1 line
This blank line shouldn't be here. It's a tag block where we don't put blank lines.
Quoted 1 line
Signed-off-by Abraham Samuel Adekunle <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko
Greg Kroah-Hartman
maintainerQuoted 25 lines · Abraham Samuel Adekunle
The sequence number is constrained to a range of [0, 4095], which is a total of 4096 values. The bitmask operation using
0xfffis used to perform this wrap-around. While this is functionally correct, it obscures the intended semantic of a 4096-based wrap.Using a modulo operation with
4096umakes the wrap-around logic explicit and easier to understand. It clearly signals that the sequence number cycles though a range of 4096 values.The use of
4096ualso guarantees that the modulo operation is performed with unsigned arithmetic, preventing potential issues with signed types.Suggested-by Andy Shevchenko <[email protected]>David Laight <[email protected]>
Signed-off-by Abraham Samuel Adekunle <[email protected]>---
Changes in v2:
- Changed the commit message to a more descriptive message which makes it clear why the patch does the change.
- Changed the subject title to include4096uto show that an unsigned module is used.
Changes in v1:
- Added more patch recipients.
Quoted 1 line
drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
Any specific reason you did not include the staging mailing list like scripts/get_maintainers.pl asks you to?
thanks,
greg k-h
Quoted 27 lines · Greg Kroah-Hartman
Quoted 25 lines · Abraham Samuel Adekunle
The sequence number is constrained to a range of [0, 4095], which is a total of 4096 values. The bitmask operation using
0xfffis used to perform this wrap-around. While this is functionally correct, it obscures the intended semantic of a 4096-based wrap.Using a modulo operation with
4096umakes the wrap-around logic explicit and easier to understand. It clearly signals that the sequence number cycles though a range of 4096 values.The use of
4096ualso guarantees that the modulo operation is performed with unsigned arithmetic, preventing potential issues with signed types.Suggested-by Andy Shevchenko <[email protected]>David Laight <[email protected]>
Signed-off-by Abraham Samuel Adekunle <[email protected]>---
Changes in v2:
- Changed the commit message to a more descriptive message which makes it clear why the patch does the change.
- Changed the subject title to include4096uto show that an unsigned module is used.
Changes in v1:
- Added more patch recipients.
Quoted 4 lines
Quoted 1 line
drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---Any specific reason you did not include the staging mailing list like
scripts/get_maintainers.plasks you to?
Thank you, Greg.
I have sent an updated patch.
Adekunle