Skip to contentSkip to conversation

nfs: add a refcount tracker for struct net as held by the nfs_client

PATCH New Jeff Layton 1 participant 1 message Apr 8, 2025

Subsystems (2)
lore
Share & tools
lore

Jeff Layton

author maintainer
#0 lore raw

PATCH v2 1/1 nfs: add a refcount tracker for struct net as held by the nfs_client

These are long-held references to the netns, so make sure the refcount tracker is aware of them.

---
 fs/nfs/client.c           | 4 ++--
 include/linux/nfs_fs_sb.h | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
fs/nfs/client.c +2 -2
index 02c916a550205f3ccbe9551686e92700900dc176..9500b46005b0148a5a9a7d464095ca944de06bb5 100644
@@ -180,7 +180,7 @@ struct nfs_client *nfs_alloc_client(const struct nfs_client_initdata *cl_init)
 	clp->cl_proto = cl_init->proto;
 	clp->cl_nconnect = cl_init->nconnect;
 	clp->cl_max_connect = cl_init->max_connect ? cl_init->max_connect : 1;
-	clp->cl_net = get_net(cl_init->net);
+	clp->cl_net = get_net_track(cl_init->net, &clp->cl_ns_tracker, GFP_KERNEL);
 
 #if IS_ENABLED(CONFIG_NFS_LOCALIO)
 	seqlock_init(&clp->cl_boot_lock);
@@ -250,7 +250,7 @@ void nfs_free_client(struct nfs_client *clp)
 	if (!IS_ERR(clp->cl_rpcclient))
 		rpc_shutdown_client(clp->cl_rpcclient);
 
-	put_net(clp->cl_net);
+	put_net_track(clp->cl_net, &clp->cl_ns_tracker);
 	put_nfs_version(clp->cl_nfs_mod);
 	kfree(clp->cl_hostname);
 	kfree(clp->cl_acceptor);
include/linux/nfs_fs_sb.h +1 -0
index 71319637a84e61c848a296910109828c2c245d67..a5dd543494de9a59db1ec6e1efb6e3ffda2246ee 100644
@@ -125,6 +125,7 @@ struct nfs_client {
 	 */
 	char			cl_ipaddr[48];
 	struct net		*cl_net;
+	netns_tracker		cl_ns_tracker;
 	struct list_head	pending_cb_stateids;
 	struct rcu_head		rcu;
 

---
base-commit: ee1c801410b2649b2a1c71e0fb5fe1b16fd20e86
change-id: 20250408-nfs-testing-08fa6f66b45d

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>