Skip to contentSkip to conversation

kbuild: add dependency from vmlinux to sorttable

PATCH New Sasha Levin 1 participant 2 messages Apr 8, 2025

Subsystems (2)
lore
Share & tools
lore

Sasha Levin

author maintainer
#0 lore raw

PATCH 1/2 kbuild: add dependency from vmlinux to sorttable

From: Xi Ruoyao <[email protected]>

[ Upstream commit 82c09de2d4c472ab1b973e6e033671020691e637 ]

Without this dependency it's really puzzling when we bisect for a "bad" commit in a series of sorttable change: when "git bisect" switches to another commit, "make" just does nothing to vmlinux.

---
 scripts/Makefile.vmlinux | 4 ++++
 1 file changed, 4 insertions(+)
scripts/Makefile.vmlinux +4 -0
index 1284f05555b97..0c2494ffcaf87 100644
@@ -33,6 +33,10 @@ targets += vmlinux
 vmlinux: scripts/link-vmlinux.sh vmlinux.o $(KBUILD_LDS) FORCE
 	+$(call if_changed_dep,link_vmlinux)
 
+ifdef CONFIG_BUILDTIME_TABLE_SORT
+vmlinux: scripts/sorttable
+endif
+
 # module.builtin.ranges
 # ---------------------------------------------------------------------------
 ifdef CONFIG_BUILTIN_MODULE_RANGES
Signature · 1 line
2.39.5
author maintainer
#1 lore raw

PATCH 2/2 sched/isolation: Make CONFIG_CPU_ISOLATION depend on CONFIG_SMP

From: Oleg Nesterov <[email protected]>

[ Upstream commit 975776841e689dd8ba36df9fa72ac3eca3c2957a ]

kernel/sched/isolation.c obviously makes no sense without CONFIG_SMP, but the Kconfig entry we have right now:

	config CPU_ISOLATION
		bool "CPU isolation"
		depends on SMP || COMPILE_TEST

allows the creation of pointless .config's which cause build failures.

---
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/Kconfig +1 -1
index 293c565c62168..f3d2a9b50d76e 100644
@@ -703,7 +703,7 @@ endmenu # "CPU/Task time and stats accounting"
 
 config CPU_ISOLATION
 	bool "CPU isolation"
-	depends on SMP || COMPILE_TEST
+	depends on SMP
 	default y
 	help
 	  Make sure that CPUs running critical tasks are not disturbed by
Signature · 1 line
2.39.5