perf test: Allow tolerance for leader sampling test
Subsystems (2)
PATCH v2 1/1 perf test: Allow tolerance for leader sampling test
V2: Changed bc invocation to return 0 on success and 1 on error.
There is a known issue that the leader sampling is inconsistent, since throttle only affect leader, not the slave. The detail is in [1]. To maintain test coverage, this patch sets a tolerance rate of 80% to accommodate the throttled samples and prevent test failures due to throttling.
[1] lore.kernel.org/[email protected]
--- tools/perf/tests/shell/record.sh | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-)
tools/perf/tests/shell/record.sh +20 -6
@@ -238,22 +238,36 @@ test_leader_sampling() { err=1 return fi + perf script -i "${perfdata}" | grep brstack > $script_output + # Check if the two instruction counts are equal in each record. + # However, the throttling code doesn't consider event grouping. During throttling, only the + # leader is stopped, causing the slave's counts significantly higher. To temporarily solve this, + # let's set the tolerance rate to 80%. + # TODO: Revert the code for tolerance once the throttling mechanism is fixed. index=0 - perf script -i "${perfdata}" > $script_output + valid_counts=0 + invalid_counts=0 + tolerance_rate=0.8 while IFS= read -r line do - # Check if the two instruction counts are equal in each record cycles=$(echo $line | awk '{for(i=1;i<=NF;i++) if($i=="cycles:") print $(i-1)}') if [ $(($index%2)) -ne 0 ] && [ ${cycles}x != ${prev_cycles}x ] then - echo "Leader sampling [Failed inconsistent cycles count]" - err=1 - return + invalid_counts=$(($invalid_counts+1)) + else + valid_counts=$(($valid_counts+1)) fi index=$(($index+1)) prev_cycles=$cycles done < $script_output - echo "Basic leader sampling test [Success]" + isok=$(echo "scale=2; val=$invalid_counts/($invalid_counts+$valid_counts); if (val < (1-$tolerance_rate)) { 0 } else { 1 };" | bc -q) + if [ $isok -eq 1 ] + then + echo "Leader sampling [Failed inconsistent cycles count]" + err=1 + else + echo "Basic leader sampling test [Success]" + fi } test_topdown_leader_sampling() {
Signature · 1 line
2.49.0
Quoted 45 lines · Thomas Richter
V2: Changed bc invocation to return 0 on success and 1 on error.
There is a known issue that the leader sampling is inconsistent, since throttle only affect leader, not the slave. The detail is in [1]. To maintain test coverage, this patch sets a tolerance rate of 80% to accommodate the throttled samples and prevent test failures due to throttling.
[1] lore.kernel.org/[email protected]
Signed-off-by Chun-Tse Shao <[email protected]>Suggested-by Ian Rogers <[email protected]>Suggested-by Thomas Richter <[email protected]>Tested-by Thomas Richter <[email protected]>Signed-off-by Thomas Richter <[email protected]>--- tools/perf/tests/shell/record.sh | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-)tools/perf/tests/shell/record.sh +9
-3@@ -238,22 +238,36 @@ test_leader_sampling() { err=1 return fi + perf script -i "${perfdata}" | grep brstack > $script_output + # Check if the two instruction counts are equal in each record. + # However, the throttling code doesn't consider event grouping. During throttling, only the + # leader is stopped, causing the slave's counts significantly higher. To temporarily solve this, + # let's set the tolerance rate to 80%. + # TODO: Revert the code for tolerance once the throttling mechanism is fixed. index=0 - perf script -i "${perfdata}" > $script_output + valid_counts=0 + invalid_counts=0 + tolerance_rate=0.8 while IFS= read -r line do - # Check if the two instruction counts are equal in each record cycles=$(echo $line | awk '{for(i=1;i<=NF;i++) if($i=="cycles:") print $(i-1)}') if [ $(($index%2)) -ne 0 ] && [ ${cycles}x != ${prev_cycles}x ] then - echo "Leader sampling [Failed inconsistent cycles count]"
tools/perf/tests/shell/record.sh test_leader_sampling() { · line 256
Quoted 10 lines
tools/perf/tests/shell/record.sh +3
-3- err=1 - return + invalid_counts=$(($invalid_counts+1)) + else + valid_counts=$(($valid_counts+1)) fi index=$(($index+1)) prev_cycles=$cycles done < $script_output - echo "Basic leader sampling test [Success]"
Would you like to add an simple division by 0 check?
total_counts=$(bc <<< "$invalid_counts+$valid_counts")
if (( $(bc <<< "$total_counts <= 0") ))
then
echo "Leader sampling [No sample generated]"
err=1
return
fiAnd then $invalid_counts+$valid_counts can be replaced by $total_counts
Thanks,
CT
Quoted 14 lines
tools/perf/tests/shell/record.sh +8
-1+ isok=$(echo "scale=2; val=$invalid_counts/($invalid_counts+$valid_counts); if (val < (1-$tolerance_rate)) { 0 } else { 1 };" | bc -q) + if [ $isok -eq 1 ] + then + echo "Leader sampling [Failed inconsistent cycles count]" + err=1 + else + echo "Basic leader sampling test [Success]" + fi } test_topdown_leader_sampling() { --2.49.0