Skip to contentSkip to conversation

staging: gpib: Removing undefined CamelCase functions

PATCH New Michael Rubin 1 participant 7 messages Apr 9, 2025 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: gpib: Removing undefined CamelCase functions

checkpatch reported Camelcase routines in gpib_proto.h. These routines did not adhere to Linux coding style and also were not defined. This patch series removes these functions.

* Patch 1 - Patch 6: Removing undefined functions

Reported by checkpatch.pl as CamelCase where function is never defined.

Michael Rubin (6):
staging: gpib: Removing function osInit
staging: gpib: Removing function osReset
staging: gpib: Removing function osSendEOI
staging: gpib: Removing function ibAPWait
staging: gpib: Removing function ibaPrsp
staging: gpib: Removing function ibAPE

 drivers/staging/gpib/include/gpib_proto.h | 7 -------
 1 file changed, 7 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/6 staging: gpib: Removing function osInit

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <osInit>

Removing undefined function.

---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/include/gpib_proto.h +0 -1
index 333f5c62da9e..43d655ee324a 100644
@@ -8,7 +8,6 @@
 int ibopen(struct inode *inode, struct file *filep);
 int ibclose(struct inode *inode, struct file *file);
 long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg);
-int osInit(void);
 void osReset(void);
 void os_start_timer(struct gpib_board *board, unsigned int usec_timeout);
 void os_remove_timer(struct gpib_board *board);
Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/6 staging: gpib: Removing function osReset

In reply to Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <osReset>

Removing undefined function.

---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/include/gpib_proto.h +0 -1
index 43d655ee324a..0b32404d699c 100644
@@ -8,7 +8,6 @@
 int ibopen(struct inode *inode, struct file *filep);
 int ibclose(struct inode *inode, struct file *file);
 long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg);
-void osReset(void);
 void os_start_timer(struct gpib_board *board, unsigned int usec_timeout);
 void os_remove_timer(struct gpib_board *board);
 void osSendEOI(void);
Signature · 1 line
2.43.0
#3 lore raw

PATCH 3/6 staging: gpib: Removing function osSendEOI

In reply to Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <osSendEOI>

Removing undefined function which appears twice.

---
 drivers/staging/gpib/include/gpib_proto.h | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/gpib/include/gpib_proto.h +0 -2
index 0b32404d699c..247a73846cfc 100644
@@ -10,8 +10,6 @@ int ibclose(struct inode *inode, struct file *file);
 long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg);
 void os_start_timer(struct gpib_board *board, unsigned int usec_timeout);
 void os_remove_timer(struct gpib_board *board);
-void osSendEOI(void);
-void osSendEOI(void);
 void init_gpib_board(struct gpib_board *board);
 static inline unsigned long usec_to_jiffies(unsigned int usec)
 {
Signature · 1 line
2.43.0
#4 lore raw

PATCH 4/6 staging: gpib: Removing function ibAPWait

In reply to Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <ibaAPWait>

Removing undefined function.

---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/include/gpib_proto.h +0 -1
index 247a73846cfc..73d7c7ed25fc 100644
@@ -22,7 +22,6 @@ int serial_poll_all(struct gpib_board *board, unsigned int usec_timeout);
 void init_gpib_descriptor(struct gpib_descriptor *desc);
 int dvrsp(struct gpib_board *board, unsigned int pad, int sad,
 	  unsigned int usec_timeout, uint8_t *result);
-int ibAPWait(struct gpib_board *board, int pad);
 int ibAPrsp(struct gpib_board *board, int padsad, char *spb);
 void ibAPE(struct gpib_board *board, int pad, int v);
 int ibcac(struct gpib_board *board, int sync, int fallback_to_async);
Signature · 1 line
2.43.0
#5 lore raw

PATCH 5/6 staging: gpib: Removing function ibaPrsp

In reply to Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <ibaPrsp>

Removing undefined function.

---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/include/gpib_proto.h +0 -1
index 73d7c7ed25fc..fce33f5715fb 100644
@@ -22,7 +22,6 @@ int serial_poll_all(struct gpib_board *board, unsigned int usec_timeout);
 void init_gpib_descriptor(struct gpib_descriptor *desc);
 int dvrsp(struct gpib_board *board, unsigned int pad, int sad,
 	  unsigned int usec_timeout, uint8_t *result);
-int ibAPrsp(struct gpib_board *board, int padsad, char *spb);
 void ibAPE(struct gpib_board *board, int pad, int v);
 int ibcac(struct gpib_board *board, int sync, int fallback_to_async);
 int ibcmd(struct gpib_board *board, uint8_t *buf, size_t length, size_t *bytes_written);
Signature · 1 line
2.43.0
#6 lore raw

PATCH 6/6 staging: gpib: Removing function ibAPE

In reply to Michael Rubin

Reported by checkpatch.pl as CamelCase where function is undefined.

CHECK: Avoid CamelCase: <ibAPE>

Removing undefined function.

---
 drivers/staging/gpib/include/gpib_proto.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/include/gpib_proto.h +0 -1
index fce33f5715fb..4c01c436b9a7 100644
@@ -22,7 +22,6 @@ int serial_poll_all(struct gpib_board *board, unsigned int usec_timeout);
 void init_gpib_descriptor(struct gpib_descriptor *desc);
 int dvrsp(struct gpib_board *board, unsigned int pad, int sad,
 	  unsigned int usec_timeout, uint8_t *result);
-void ibAPE(struct gpib_board *board, int pad, int v);
 int ibcac(struct gpib_board *board, int sync, int fallback_to_async);
 int ibcmd(struct gpib_board *board, uint8_t *buf, size_t length, size_t *bytes_written);
 int ibgts(struct gpib_board *board);
Signature · 1 line
2.43.0