Skip to contentSkip to conversation

drm/nouveau: Remove forgotten TODO

PATCH In review Philipp Stanner 3 participants 4 messages Apr 9, 2025 – Jul 31, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau: Remove forgotten TODO

commit ebb945a94bba ("drm/nouveau: port all engines to new engine module format") introduced a TODO to nouveau_chan.h, stating that an unspecified rework would take place in the "near future".

Almost 13 years have passed since this "near future", so it can be safely assumed that the TODO is not needed anymore. Besides, its content is useless anyways since it does not specify *what* should have been done.

Remove the TODO.

---
 drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -1
index 016f668c0bc1..3b73ec91c4ff 100644
@@ -33,7 +33,6 @@ struct nouveau_channel {
 		u64 addr;
 	} push;
 
-	/* TODO: this will be reworked in the near future */
 	bool accel_done;
 	void *fence;
 	struct {
Signature · 1 line
2.48.1
maintainer
#1 lore raw

(+ Ben)

Quoted 21 lines · Philipp Stanner

commit ebb945a94bba ("drm/nouveau: port all engines to new engine module format") introduced a TODO to nouveau_chan.h, stating that an unspecified rework would take place in the "near future".

Almost 13 years have passed since this "near future", so it can be safely assumed that the TODO is not needed anymore. Besides, its content is useless anyways since it does not specify *what* should have been done.

Remove the TODO.

---
 drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -0
index 016f668c0bc1..3b73ec91c4ff 100644

drivers/gpu/drm/nouveau/nouveau_chan.h struct nouveau_channel { · line 36

Quoted 5 lines
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -1
@@ -33,7 +33,6 @@ struct nouveau_channel {
 		u64 addr;
 	} push;
 
-	/* TODO: this will be reworked in the near future */
 	bool accel_done;

After having a brief look, it seems that it may has actually been reworked; there is only a single use of accel_done, which is in FIRE_RING(), where it is set to true. But it doesn't seem to be read from anywhere.

So, I think we should remove both, the TODO and the accel_done field.

@Ben: Maybe you remember the history of this.

- Danilo

#2 lore raw
Quoted 34 lines · Danilo Krummrich

(+ Ben)

Quoted 25 lines · Philipp Stanner

commit ebb945a94bba ("drm/nouveau: port all engines to new engine module format") introduced a TODO to nouveau_chan.h, stating that an unspecified rework would take place in the "near future".

Almost 13 years have passed since this "near future", so it can be safely assumed that the TODO is not needed anymore. Besides, its content is useless anyways since it does not specify *what* should have been done.

Remove the TODO.

---
 drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -

 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -0
index 016f668c0bc1..3b73ec91c4ff 100644
@@ -33,7 +33,6 @@ struct nouveau_channel {
  		u64 addr;
  	} push;

drivers/gpu/drm/nouveau/nouveau_chan.h +0 -1
-	/* TODO: this will be reworked in the near future */
Quoted 1 line

  bool accel_done;

After having a brief look, it seems that it may has actually been reworked; there is only a single use of accel_done, which is in FIRE_RING(), where it is set to true. But it doesn't seem to be read from anywhere.

Quoted 3 lines

So, I think we should remove both, the TODO and the accel_done field.

@Ben: Maybe you remember the history of this.

Since we didn't get an answer – how do we want to continue with that, Danilo?

P.

Quoted 2 lines

- Danilo

maintainer
#3 lore raw
Quoted 35 lines · Philipp Stanner
Quoted 34 lines · Danilo Krummrich

(+ Ben)

Quoted 21 lines · Philipp Stanner

commit ebb945a94bba ("drm/nouveau: port all engines to new engine module format") introduced a TODO to nouveau_chan.h, stating that an unspecified rework would take place in the "near future".

Almost 13 years have passed since this "near future", so it can be safely assumed that the TODO is not needed anymore. Besides, its content is useless anyways since it does not specify *what* should have been done.

Remove the TODO.

---
  drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -0
index 016f668c0bc1..3b73ec91c4ff 100644

drivers/gpu/drm/nouveau/nouveau_chan.h struct nouveau_channel { · line 36

Quoted 5 lines
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -1
@@ -33,7 +33,6 @@ struct nouveau_channel {
  		u64 addr;
  	} push;
 
-	/* TODO: this will be reworked in the near future */
  	bool accel_done;

After having a brief look, it seems that it may has actually been reworked; there is only a single use of accel_done, which is in FIRE_RING(), where it is set to true. But it doesn't seem to be read from anywhere.

Quoted 6 lines
Quoted 3 lines

So, I think we should remove both, the TODO and the accel_done field.

@Ben: Maybe you remember the history of this.

Since we didn't get an answer – how do we want to continue with that, Danilo?

Removing the unused accel_done and the corresponding TODO should be fine, let's do that.