locking/lockdep: Prevent abuse of lockdep subclass
Waiman Long
reviewerPATCH 1/1 locking/lockdep: Prevent abuse of lockdep subclass
As I have seen code trying to use a subclass value >= MAX_LOCKDEP_SUBCLASSES (8), add a DEBUG_LOCKS_WARN_ON() statement to notify the users that such a large value is not allowed.
Signed-off-by Waiman Long <[email protected]>
--- kernel/locking/lockdep.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/locking/lockdep.c +3 -0
@@ -5101,6 +5101,9 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,lockevent_inc (lockdep_nocheck); } +if (DEBUG_LOCKS_WARN_ON (subclass >=MAX_LOCKDEP_SUBCLASSES )) +return 0 ; +if (subclass <NR_LOCKDEP_CACHING_CLASSES ) class = lock->class_cache[subclass];/*
Signature · 1 line
2.48.1
Boqun Feng
AppliedQuoted 5 lines · Waiman Long
As I have seen code trying to use a subclass value >=
MAX_LOCKDEP_SUBCLASSES(8), add aDEBUG_LOCKS_WARN_ON()statement to notify the users that such a large value is not allowed.Signed-off-by Waiman Long <[email protected]>
Queued for 6.16, thanks!
Regards,
Boqun
Quoted 21 lines
--- kernel/locking/lockdep.c | 3 +++ 1 file changed, 3 insertions(+)kernel/locking/lockdep.c +3
-0@@ -5101,6 +5101,9 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,lockevent_inc (lockdep_nocheck); } +if (DEBUG_LOCKS_WARN_ON (subclass >=MAX_LOCKDEP_SUBCLASSES )) +return 0 ; +if (subclass <NR_LOCKDEP_CACHING_CLASSES ) class = lock->class_cache[subclass];/* Signature · 1 line
2.48.1