Skip to contentSkip to conversation

podman: Fix QA error for invalid PACKAGECONFIG

PATCH In review Theodore A. Roth 2 participants 3 messages Apr 9, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 podman: Fix QA error for invalid PACKAGECONFIG

The insane.bbclass now flags as errors when PACKAGECONFIG contains a value that does not have a setting.

For example, setting a value like this:

    PACKAGECONFIG += "foo"

without something like this in the recipe:

PACKAGECONFIG[foo] = "stuff"

will result in QA errors like the following:

ERROR: podman-v5.4.1-r0 do_recipe_qa: QA Issue: podman:
invalid PACKAGECONFIG(s): docker rootless [invalid-packageconfig]
ERROR: podman-v5.4.1-r0 do_recipe_qa: Fatal QA errors were found, failing task.

---
 recipes-containers/podman/podman_git.bb | 3 +++
 1 file changed, 3 insertions(+)
recipes-containers/podman/podman_git.bb +3 -0
index be85e512..9f886ed4 100644
@@ -70,6 +70,9 @@ EXTRA_OEMAKE = " \
 # packageconfig, the podman package will rconfict with docker.
 PACKAGECONFIG ?= "docker"
 
+PACKAGECONFIG[docker] ?= ""
+PACKAGECONFIG[rootless] ?= ""
+
 do_compile() {
 	cd ${S}/src
 	rm -rf .gopath
Signature · 1 line
2.34.1
#1 lore raw

I went a different way with this.

docker shouldnt' really be a packageconfig, and rootless was adding an rdepends later .. when it could have just been done in a compliant way in the PACKAGECONFIG.

Bruce

In message: [meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG

Quoted 50 lines · on 09/04/2025 Theodore A. Roth via lists.yoctoproject.org wrote:

The insane.bbclass now flags as errors when PACKAGECONFIG contains a value that does not have a setting.

For example, setting a value like this:

    PACKAGECONFIG += "foo"

without something like this in the recipe:

PACKAGECONFIG[foo] = "stuff"

will result in QA errors like the following:

ERROR: podman-v5.4.1-r0 do_recipe_qa: QA Issue: podman:
invalid PACKAGECONFIG(s): docker rootless [invalid-packageconfig]
ERROR: podman-v5.4.1-r0 do_recipe_qa: Fatal QA errors were found, failing task.

---
 recipes-containers/podman/podman_git.bb | 3 +++
 1 file changed, 3 insertions(+)
recipes-containers/podman/podman_git.bb +3 -0
index be85e512..9f886ed4 100644
@@ -70,6 +70,9 @@ EXTRA_OEMAKE = " \
 # packageconfig, the podman package will rconfict with docker.
 PACKAGECONFIG ?= "docker"
 
+PACKAGECONFIG[docker] ?= ""
+PACKAGECONFIG[rootless] ?= ""
+
 do_compile() {
 	cd ${S}/src
 	rm -rf .gopath
Signature · 11 lines
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9211): https://lists.yoctoproject.org/g/meta-virtualization/message/9211
Mute This Topic: https://lists.yoctoproject.org/mt/112173803/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
#2 lore raw

I like your fix over mine. Mine felt hacky and with your changes it doesn't feel like the PACKAGECONFIG mechanism is being abused.

Thanks!

Ted Roth

Quoted 69 lines · Bruce Ashfield

I went a different way with this.

docker shouldnt' really be a packageconfig, and rootless was adding an rdepends later .. when it could have just been done in a compliant way in the PACKAGECONFIG.

Bruce

In message: [meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG

Quoted 7 lines · on 09/04/2025 Theodore A. Roth via lists.yoctoproject.org wrote:

The insane.bbclass now flags as errors when PACKAGECONFIG contains a value that does not have a setting.

For example, setting a value like this:

    PACKAGECONFIG += "foo"
Quoted 8 lines

without something like this in the recipe:

PACKAGECONFIG[foo] = "stuff"

will result in QA errors like the following:

ERROR: podman-v5.4.1-r0 do_recipe_qa: QA Issue: podman:
invalid PACKAGECONFIG(s): docker rootless

[invalid-packageconfig]

Quoted 1 line

ERROR: podman-v5.4.1-r0 do_recipe_qa: Fatal QA errors were found,

failing task.

Review

Quoted 8 lines
---
 recipes-containers/podman/podman_git.bb | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/recipes-containers/podman/podman_git.bb

Quoted 18 lines

index be85e512..9f886ed4 100644

recipes-containers/podman/podman_git.bb +3 -1
@@ -70,6 +70,9 @@ EXTRA_OEMAKE = " \
 # packageconfig, the podman package will rconfict with docker.
 PACKAGECONFIG ?= "docker"
 
+PACKAGECONFIG[docker] ?= ""
+PACKAGECONFIG[rootless] ?= ""
+
 do_compile() {
      cd ${S}/src
      rm -rf .gopath
--

2.34.1

Quoted 3 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#9211):

https://lists.yoctoproject.org/g/meta-virtualization/message/9211

Quoted 3 lines

Mute This Topic: https://lists.yoctoproject.org/mt/112173803/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub

[[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-