clocksource: atmel_tcb: fix kconfig dependency
PATCH v3 1/1 clocksource: atmel_tcb: fix kconfig dependency
From: Arnd Bergmann <[email protected]>
Build-testing this driver on arm without CONFIG_OF produces a warning:
drivers/clocksource/timer-atmel-tcb.c:368:34: error: 'atmel_tcb_of_match' defined but not used [-Werror=unused-const-variable=]
368 | static const struct of_device_id atmel_tcb_of_match[] = {
| ^~~~~~~~~~~~~~~~~~Change the dependency to require CONFIG_OF for build testing to avoid the warning. Testing remains possible on all architectures as CONFIG_OF is user-selectable.
---
v3: update changelog text
v2: fix build regression from dropped CONFIG_ARM dependency
--- drivers/clocksource/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clocksource/Kconfig +2 -2
@@ -437,8 +437,8 @@ config ATMEL_ST config ATMEL_TCB_CLKSRC bool "Atmel TC Block timer driver" if COMPILE_TEST - depends on ARM && HAS_IOMEM - select TIMER_OF if OF + depends on ARM && OF && HAS_IOMEM + select TIMER_OF help Support for Timer Counter Blocks on Atmel SoCs.
Signature · 1 line
2.39.5
Daniel Lezcano
AppliedQuoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Build-testing this driver on arm without
CONFIG_OFproduces a warning:
drivers/clocksource/timer-atmel-tcb.c:368:34: error: 'atmel_tcb_of_match' defined but not used [-Werror=unused-const-variable=]368 | static const struct of_device_id atmel_tcb_of_match[] = { | ^~~~~~~~~~~~~~~~~~Change the dependency to require
CONFIG_OFfor build testing to avoid the warning. Testing remains possible on all architectures asCONFIG_OFis user-selectable.
Quoted 5 lines
Cc Nicolas Ferre <[email protected]>Cc Claudiu Beznea <[email protected]>Reviewed-by Alexandre Belloni <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>---
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
[tip: timers/clocksource] clocksource/drivers/atmel_tcb: Fix kconfig dependency
In reply to Arnd BergmannThe following commit has been merged into the timers/clocksource branch of tip:
The following commit has been merged into the timers/clocksource branch of tip:
Commit-ID: b8239054194ad67aff7d244185ef46890c5ae71a Gitweb: https://git.kernel.org/tip/b8239054194ad67aff7d244185ef46890c5ae71a Author: Arnd Bergmann <[email protected]> AuthorDate: Wed, 09 Apr 2025 17:53:08 +02:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Fri, 16 May 2025 11:10:32 +02:00
clocksource/drivers/atmel_tcb: Fix kconfig dependency
Build-testing this driver on arm without CONFIG_OF produces a warning:
drivers/clocksource/timer-atmel-tcb.c:368:34: error: 'atmel_tcb_of_match' defined but not used [-Werror=unused-const-variable=]
368 | static const struct of_device_id atmel_tcb_of_match[] = {
| ^~~~~~~~~~~~~~~~~~Change the dependency to require CONFIG_OF for build testing to avoid the warning. Testing remains possible on all architectures as CONFIG_OF is user-selectable.
--- drivers/clocksource/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clocksource/Kconfig +2 -2
@@ -437,8 +437,8 @@ config ATMEL_ST config ATMEL_TCB_CLKSRC bool "Atmel TC Block timer driver" if COMPILE_TEST - depends on ARM && HAS_IOMEM - select TIMER_OF if OF + depends on ARM && OF && HAS_IOMEM + select TIMER_OF help Support for Timer Counter Blocks on Atmel SoCs.