Skip to contentSkip to conversation

amd-xgbe: Convert to SPDX identifier

PATCH Applied Raju Rangoju 4 participants 6 messages Apr 7, 2025 – Apr 9, 2025

Subsystems (3)
lore
Share & tools
lore

Raju Rangoju

author maintainer
#0 lore raw

PATCH 1/1 amd-xgbe: Convert to SPDX identifier

Use SPDX-License-Identifier accross all the files of the xgbe driver to ensure compliance with Linux kernel standards, thus removing the boiler-plate template license text.

---
 drivers/net/ethernet/amd/xgbe/xgbe-common.h   | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-dcb.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c  | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-desc.c     | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-dev.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c  | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-i2c.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-main.c     | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-mdio.c     | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-pci.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v1.c   | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c   | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-ptp.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe.h          | 117 +-----------------
 16 files changed, 64 insertions(+), 1808 deletions(-)
drivers/net/ethernet/amd/xgbe/xgbe-common.h +4 -113
index 3b70f6737633..e3d33f5b9642 100644
@@ -1,117 +1,8 @@
+// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-3-Clause)
 /*
- * AMD 10Gb Ethernet driver
- *
- * This file is available to you under your choice of the following two
- * licenses:
- *
- * License 1: GPLv2
- *
- * Copyright (c) 2014-2016 Advanced Micro Devices, Inc.
- *
- * This file is free software; you may copy, redistribute and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 2 of the License, or (at
- * your option) any later version.
- *
- * This file is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *     The Synopsys DWC ETHER XGMAC Software Driver and documentation
- *     (hereinafter "Software") is an unsupported proprietary work of Synopsys,
- *     Inc. unless otherwise expressly agreed to in writing between Synopsys
- *     and you.
- *
- *     The Software IS NOT an item of Licensed Software or Licensed Product
- *     under any End User Software License Agreement or Agreement for Licensed
- *     Product with Synopsys or any supplement thereto.  Permission is hereby
- *     granted, free of charge, to any person obtaining a copy of this software
- *     annotated with this license and the Software, to deal in the Software
- *     without restriction, including without limitation the rights to use,
- *     copy, modify, merge, publish, distribute, sublicense, and/or sell copies
- *     of the Software, and to permit persons to whom the Software is furnished
- *     to do so, subject to the following conditions:
- *
- *     The above copyright notice and this permission notice shall be included
- *     in all copies or substantial portions of the Software.
- *
- *     THIS SOFTWARE IS BEING DISTRIBUTED BY SYNOPSYS SOLELY ON AN "AS IS"
- *     BASIS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
- *     TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
- *     PARTICULAR PURPOSE ARE HEREBY DISCLAIMED. IN NO EVENT SHALL SYNOPSYS
- *     BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- *     CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- *     SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- *     INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- *     CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- *     ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- *     THE POSSIBILITY OF SUCH DAMAGE.
- *
- *
- * License 2: Modified BSD
- *
- * Copyright (c) 2014-2016 Advanced Micro Devices, Inc.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in the
- *       documentation and/or other materials provided with the distribution.
- *     * Neither the name of Advanced Micro Devices, Inc. nor the
- *       names of its contributors may be used to endorse or promote products
- *       derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL <COPYRIGHT HOLDER> BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *     The Synopsys DWC ETHER XGMAC Software Driver and documentation
- *     (hereinafter "Software") is an unsupported proprietary work of Synopsys,
- *     Inc. unless otherwise expressly agreed to in writing between Synopsys
- *     and you.
- *
- *     The Software IS NOT an item of Licensed Software or Licensed Product
- *     under any End User Software License Agreement or Agreement for Licensed
- *     Product with Synopsys or any supplement thereto.  Permission is hereby
- *     granted, free of charge, to any person obtaining a copy of this software
- *     annotated with this license and the Software, to deal in the Software
- *     without restriction, including without limitation the rights to use,
- *     copy, modify, merge, publish, distribute, sublicense, and/or sell copies
- *     of the Software, and to permit persons to whom the Software is furnished
- *     to do so, subject to the following conditions:
- *
- *     The above copyright notice and this permission notice shall be included
- *     in all copies or substantial portions of the Software.
- *
- *     THIS SOFTWARE IS BEING DISTRIBUTED BY SYNOPSYS SOLELY ON AN "AS IS"
- *     BASIS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
- *     TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
- *     PARTICULAR PURPOSE ARE HEREBY DISCLAIMED. IN NO EVENT SHALL SYNOPSYS
- *     BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- *     CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- *     SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- *     INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- *     CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- *     ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- *     THE POSSIBILITY OF SUCH DAMAGE.
+ * Copyright (c) 2014-2025, Advanced Micro Devices, Inc.
+ * Copyright (c) 2014, Synopsys, Inc.
+ * All rights reserved
  */
 
 #ifndef __XGBE_COMMON_H__
drivers/net/ethernet/amd/xgbe/xgbe-dcb.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-desc.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-dev.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-drv.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-i2c.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-main.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-pci.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-phy-v1.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-platform.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe-ptp.c +4 -113

121 lines not on this page · raw message

drivers/net/ethernet/amd/xgbe/xgbe.h +4 -113

121 lines not on this page · raw message

Signature · 1 line
2.34.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Raju Rangoju

Use SPDX-License-Identifier accross all the files of the xgbe driver to ensure compliance with Linux kernel standards, thus removing the boiler-plate template license text.

I note that this patch changes both the licences and copyright information, and not just the representation of that information, for the files it updates. And that the patch is from and reviewed by people at AMD. So I assume those changes are intentional.

Quoted 18 lines
---
 drivers/net/ethernet/amd/xgbe/xgbe-common.h   | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-dcb.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c  | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-desc.c     | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-dev.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c  | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-i2c.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-main.c     | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-mdio.c     | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-pci.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v1.c   | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c   | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe-ptp.c      | 117 +-----------------
 drivers/net/ethernet/amd/xgbe/xgbe.h          | 117 +-----------------
 16 files changed, 64 insertions(+), 1808 deletions(-)

...

author maintainer
#2 lore raw
Quoted 5 lines · Simon Horman
Quoted 4 lines · Raju Rangoju

Use SPDX-License-Identifier accross all the files of the xgbe driver to ensure compliance with Linux kernel standards, thus removing the boiler-plate template license text.

Quoted 8 lines
Quoted 2 lines

I note that this patch changes both the licences and copyright information, and not just the representation of that information, for the files it updates. And that the patch is from and reviewed by people at AMD. So I assume those changes are intentional.

Yes, it was reviewed by people at AMD.

Quoted 22 lines
Quoted 18 lines
---
  drivers/net/ethernet/amd/xgbe/xgbe-common.h   | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-dcb.c      | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c  | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-desc.c     | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-dev.c      | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-drv.c      | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c  | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-i2c.c      | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-main.c     | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-mdio.c     | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-pci.c      | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-phy-v1.c   | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c   | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe-ptp.c      | 117 +-----------------
  drivers/net/ethernet/amd/xgbe/xgbe.h          | 117 +-----------------
  16 files changed, 64 insertions(+), 1808 deletions(-)

...

reviewer
#3 lore raw
Quoted 11 lines · Raju
Quoted 8 lines · Simon Horman
Quoted 6 lines · Raju Rangoju

Use SPDX-License-Identifier accross all the files of the xgbe driver to ensure compliance with Linux kernel standards, thus removing the boiler-plate template license text.

Quoted 7 lines
Quoted 5 lines

I note that this patch changes both the licences and copyright information, and not just the representation of that information, for the files it updates. And that the patch is from and reviewed by people at AMD. So I assume those changes are intentional.

Yes, it was reviewed by people at AMD.

Thanks for the confirmation, much appreciated.

#5 lore raw
In reply to Raju Rangoju
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Mon, 7 Apr 2025 15:59:13 +0530 you wrote:

Use SPDX-License-Identifier accross all the files of the xgbe driver to ensure compliance with Linux kernel standards, thus removing the boiler-plate template license text.

[...]

Here is the summary with links:
- [net] amd-xgbe: Convert to SPDX identifier

    https://git.kernel.org/netdev/net-next/c/34a07c5b2574

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html