Skip to contentSkip to conversation

btdev: Fix checking for BR/EDR scan enable rather than LE for PA

PATCH Applied Luiz Augusto von Dentz 3 participants 3 messages Apr 9, 2025 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 btdev: Fix checking for BR/EDR scan enable rather than LE for PA

From: Luiz Augusto von Dentz <[email protected]>

PA is exclusive to LE so le_scan_enable flag shall be checked not scan_enable.

---
 emulator/btdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
emulator/btdev.c +1 -1
index 1b7b75c21399..7e4cb9393593 100644
@@ -5750,7 +5750,7 @@ static int cmd_pa_create_sync_complete(struct btdev *dev, const void *data,
 	 * synchronization can only occur when scanning is enabled. While
 	 * scanning is disabled, no attempt to synchronize will take place.
 	 */
-	if (!dev->scan_enable)
+	if (!dev->le_scan_enable)
 		return 0;
 
 	remote = find_btdev_by_bdaddr_type(cmd->addr, cmd->addr_type);
Signature · 1 line
2.49.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=951703

---Test result---

Test Summary:

CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.18 seconds
BuildEll                      PASS      37.77 seconds
BluezMake                     PASS      2614.64 seconds
MakeCheck                     PENDING   58.97 seconds
MakeDistcheck                 PASS      200.97 seconds
CheckValgrind                 PASS      274.93 seconds
CheckSmatch                   PENDING   363.72 seconds
bluezmakeextell               PASS      128.57 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      908.94 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: MakeCheck - PENDING
Desc: Run Bluez Make Check Output:

##############################
Test: CheckSmatch - PENDING
Desc: Run smatch tool with source Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 7 lines · On Wed, 9 Apr 2025 15:21:48 -0400 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

PA is exclusive to LE so le_scan_enable flag shall be checked not scan_enable.

---
 emulator/btdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ,v1] btdev: Fix checking for BR/EDR scan enable rather than LE for PA

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f8e7bcfdfb83

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html