crypto: ccp: Fix __sev_snp_shutdown_locked()
Subsystems (3)
Ashish Kalra
maintainerPATCH 1/1 crypto: ccp: Fix __sev_snp_shutdown_locked()
From: Ashish Kalra <[email protected]>
Fix smatch warning:
drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked() error: uninitialized symbol 'dfflush_error'.
Fixes 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Ashish Kalra <[email protected]>
--- drivers/crypto/ccp/sev-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/ccp/sev-dev.c +1 -1
@@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic) ret =__sev_do_cmd_locked (SEV_CMD_SNP_SHUTDOWN_EX , &data, error);/* SHUTDOWN may require DF_FLUSH */ if (*error ==SEV_RET_DFFLUSH_REQUIRED ) { -int dfflush_error; +int dfflush_error =SEV_RET_NO_FW_CALL ; ret =__sev_do_cmd_locked (SEV_CMD_SNP_DF_FLUSH ,NULL , &dfflush_error);if (ret) {
Signature · 1 line
2.34.1
Quoted 10 lines · Ashish Kalra
From: Ashish Kalra <[email protected]>
Fix smatch warning:
drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked() error: uninitialized symbol 'dfflush_error'.Fixes 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")Reported-by Dan Carpenter <[email protected]>Signed-off-by Ashish Kalra <[email protected]>
Acked-by Tom Lendacky <[email protected]>
Quoted 17 lines
--- drivers/crypto/ccp/sev-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/ccp/sev-dev.c +1
-1@@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic) ret =__sev_do_cmd_locked (SEV_CMD_SNP_SHUTDOWN_EX , &data, error);/* SHUTDOWN may require DF_FLUSH */ if (*error ==SEV_RET_DFFLUSH_REQUIRED ) { -int dfflush_error; +int dfflush_error =SEV_RET_NO_FW_CALL ; ret =__sev_do_cmd_locked (SEV_CMD_SNP_DF_FLUSH ,NULL , &dfflush_error);if (ret) {
Herbert Xu
maintainerQuoted 6 lines · Ashish Kalra
From: Ashish Kalra <[email protected]>
Fix smatch warning:
drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked() error: uninitialized symbol 'dfflush_error'.
Quoted 7 lines
Fixes 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")Reported-by Dan Carpenter <[email protected]>Signed-off-by Ashish Kalra <[email protected]>--- drivers/crypto/ccp/sev-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt