Skip to contentSkip to conversation

arm64: dts: rockchip: px30-engicam: Use "regulator-fixed" for vcc3v3-btreg

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Apr 9, 2025 – Apr 10, 2025

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: px30-engicam: Use "regulator-fixed" for vcc3v3-btreg

The vcc3v3-btreg regulator only has 1 state and no state gpios defined, so "regulator-gpio" is not the correct binding to use. "regulator-fixed" is the correct binding to use. It supports an enable GPIO which is needed in this case.

---
 arch/arm64/boot/dts/rockchip/px30-engicam-common.dtsi          | 3 +--
 arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi         | 2 +-
 .../boot/dts/rockchip/px30-engicam-px30-core-edimm2.2.dts      | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/rockchip/px30-engicam-common.dtsi +1 -2
index 1edfd643b25a..a334ef0629d1 100644
@@ -31,7 +31,7 @@ sdio_pwrseq: sdio-pwrseq {
 	};
 
 	vcc3v3_btreg: vcc3v3-btreg {
-		compatible = "regulator-gpio";
+		compatible = "regulator-fixed";
 		enable-active-high;
 		pinctrl-names = "default";
 		pinctrl-0 = <&bt_enable_h>;
@@ -39,7 +39,6 @@ vcc3v3_btreg: vcc3v3-btreg {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		regulator-always-on;
-		states = <3300000 0x0>;
 	};
 
 	vcc3v3_rf_aux_mod: regulator-vcc3v3-rf-aux-mod {
arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi +1 -1
index 80db778c9684..b60e68faa83a 100644
@@ -26,5 +26,5 @@ &sdio_pwrseq {
 };
 
 &vcc3v3_btreg {
-	enable-gpios = <&gpio1 RK_PC3 GPIO_ACTIVE_HIGH>;
+	gpios = <&gpio1 RK_PC3 GPIO_ACTIVE_HIGH>;
 };
arch/arm64/boot/dts/rockchip/px30-engicam-px30-core-edimm2.2.dts +1 -1
index 165d09ccb942..5886b802c520 100644
@@ -39,5 +39,5 @@ &sdio_pwrseq {
 };
 
 &vcc3v3_btreg {
-	enable-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
+	gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
 };
Signature · 1 line
2.47.2
maintainer Applied
#1 lore raw
Quoted 6 lines · Rob Herring (Arm)

The vcc3v3-btreg regulator only has 1 state and no state gpios defined, so "regulator-gpio" is not the correct binding to use. "regulator-fixed" is the correct binding to use. It supports an enable GPIO which is needed in this case.

Applied, thanks!

[1/1] arm64: dts: rockchip: px30-engicam: Use "regulator-fixed" for vcc3v3-btreg

      commit: c8c59bcac9300c22abf1afd7e236978a413c3644

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>