gdb: add source-highlight PACKAGECONFIG option
PATCH 1/2 gdb: add source-highlight PACKAGECONFIG option
From: Etienne Cordonnier <[email protected]>
From gdb documentation:
Quoted 5 lines
There are two ways that highlighting can be done. First, if gdb was linked with the GNU Source Highlight library, then it is used. Otherwise, if gdb was configured with Python scripting support, and if the Python Pygments package is available, then it will be used.
--- meta/recipes-devtools/gdb/gdb-common.inc | 1 + 1 file changed, 1 insertion(+)
meta/recipes-devtools/gdb/gdb-common.inc +1 -0
@@ -38,6 +38,7 @@ PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" PACKAGECONFIG[tui] = "--enable-tui,--disable-tui,,ncurses-terminfo-base" PACKAGECONFIG[xz] = "--with-lzma --with-liblzma-prefix=${STAGING_DIR_HOST},--without-lzma,xz" PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils" +PACKAGECONFIG[source-highlight] = "--enable-source-highlight,--disable-source-highlight,source-highlight" GDBPROPREFIX = "--program-prefix=''"
Signature · 1 line
2.43.0
PATCH 2/2 source-highlight: re-add recipe
From: Etienne Cordonnier <[email protected]>
source-highlight version 3.1.8 was removed in https://web.git.yoctoproject.org/poky/commit/?id=6560db9ddfd39a2715ede96430228306b00f53dd in June 2019 because the was no user left, however there is now a gdb PACKAGECONFIG option which uses it. Since the last release was in 2019, let's rather use the latest git version.
--- meta/conf/distro/include/maintainers.inc | 1 + .../source-highlight/source-highlight_git.bb | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 meta/recipes-support/source-highlight/source-highlight_git.bb
meta/conf/distro/include/maintainers.inc +1 -0
@@ -777,6 +777,7 @@ RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <[email protected] RECIPE_MAINTAINER:pn-signing-keys = "Richard Purdie <[email protected]>" RECIPE_MAINTAINER:pn-slang = "Yi Zhao <[email protected]>" RECIPE_MAINTAINER:pn-socat = "Hongxu Jia <[email protected]>" +RECIPE_MAINTAINER:pn-source-highlight = "Etienne Cordonnier <[email protected]>" RECIPE_MAINTAINER:pn-speex = "Michael Opdenacker <[email protected]>" RECIPE_MAINTAINER:pn-speexdsp = "Michael Opdenacker <[email protected]>" RECIPE_MAINTAINER:pn-spirv-headers = "Jose Quaresma <[email protected]>"
meta/recipes-support/source-highlight/source-highlight_git.bb new file +36 -0
@@ -0,0 +1,36 @@ +SUMMARY = "Syntax highlight utility" +DESCRIPTION = "Source-highlight converts source code to formatted text with syntax highlighting." +HOMEPAGE = "https://www.gnu.org/software/src-highlite/" +LICENSE = "GPL-3.0-only" +SECTION = "libs" +LIC_FILES_CHKSUM = "file://COPYING;;md5=ff95bfe019feaf92f524b73dd79e76eb" + +SRCREV = "894cacd0799ca60afa359a63782729dec76cbb79" +PV = "3.1.9+git" +SRC_URI = "git://git.savannah.gnu.org/git/src-highlite.git;protocol=https;branch=master" +S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +DEPENDS:append = " bison-native boost" + +DEPENDS:append:class-target = " ${PN}-native" + +EXTRA_OECONF="--with-boost-regex=boost_regex" + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES += "${PN}-tools ${PN}-data" + +RDEPENDS:${PN} = "boost-regex ${PN}-data" +RDEPENDS:${PN}-tools = "${PN} ${PN}-data bash" + +FILES:${PN} = "${libdir}/*${SOLIBS}" +FILES:${PN}-data = "${datadir}/source-highlight" +FILES:${PN}-tools = "${bindir} ${sysconfdir}/bash_completion.d" + +# source-highlight is using its own binary from the build tree to make documentation +# let's substitute the native binary instead +do_configure:prepend:class-target () { + sed -i -e 's,^SRCHILITEEXE = $(top_builddir).*,SRCHILITEEXE = source-highlight,' ${S}/doc/Makefile.am +}
Signature · 1 line
2.43.0
Re: [OE-core] [PATCH 2/2] source-highlight: re-add recipe
Unless you want to enable it by default in gdb (and the other patch shows that is not the case), source-highlight does not have to be in core. We have plenty of recipes in core with options that require items from meta-oe or other layers.
Alex
Quoted 79 lines · Etienne Cordonnier via lists.openembedded.org
From: Etienne Cordonnier <[email protected]>
source-highlight version 3.1.8 was removed in https://web.git.yoctoproject.org/poky/commit/?id=6560db9ddfd39a2715ede96430228306b00f53dd in June 2019 because the was no user left, however there is now a gdb PACKAGECONFIG option which uses it. Since the last release was in 2019, let's rather use the latest git version.
Signed-off-by Etienne Cordonnier <[email protected]>--- meta/conf/distro/include/maintainers.inc | 1 + .../source-highlight/source-highlight_git.bb | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 meta/recipes-support/source-highlight/source-highlight_git.bbmeta/conf/distro/include/maintainers.inc +1
-0@@ -777,6 +777,7 @@ RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <[email protected] RECIPE_MAINTAINER:pn-signing-keys = "Richard Purdie <[email protected]>" RECIPE_MAINTAINER:pn-slang = "Yi Zhao <[email protected]>" RECIPE_MAINTAINER:pn-socat = "Hongxu Jia <[email protected]>" +RECIPE_MAINTAINER:pn-source-highlight = "Etienne Cordonnier <[email protected]>" RECIPE_MAINTAINER:pn-speex = "Michael Opdenacker <[email protected]>" RECIPE_MAINTAINER:pn-speexdsp = "Michael Opdenacker <[email protected]>" RECIPE_MAINTAINER:pn-spirv-headers = "Jose Quaresma <[email protected]>"meta/recipes-support/source-highlight/source-highlight_git.bb new file +36
-1@@ -0,0 +1,36 @@ +SUMMARY = "Syntax highlight utility" +DESCRIPTION = "Source-highlight converts source code to formatted text with syntax highlighting." +HOMEPAGE = "https://www.gnu.org/software/src-highlite/" +LICENSE = "GPL-3.0-only" +SECTION = "libs" +LIC_FILES_CHKSUM = "file://COPYING;;md5=ff95bfe019feaf92f524b73dd79e76eb" + +SRCREV = "894cacd0799ca60afa359a63782729dec76cbb79" +PV = "3.1.9+git" +SRC_URI = "git://git.savannah.gnu.org/git/src-highlite.git;protocol=https;branch=master" +S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +DEPENDS:append = " bison-native boost" + +DEPENDS:append:class-target = " ${PN}-native" + +EXTRA_OECONF="--with-boost-regex=boost_regex" + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES += "${PN}-tools ${PN}-data" + +RDEPENDS:${PN} = "boost-regex ${PN}-data" +RDEPENDS:${PN}-tools = "${PN} ${PN}-data bash" + +FILES:${PN} = "${libdir}/*${SOLIBS}" +FILES:${PN}-data = "${datadir}/source-highlight" +FILES:${PN}-tools = "${bindir} ${sysconfdir}/bash_completion.d" + +# source-highlight is using its own binary from the build tree to make documentation +# let's substitute the native binary instead +do_configure:prepend:class-target () { + sed -i -e 's,^SRCHILITEEXE = $(top_builddir).*,SRCHILITEEXE = source-highlight,' ${S}/doc/Makefile.am +} --2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#214702): https://lists.openembedded.org/g/openembedded-core/message/214702
Mute This Topic: https://lists.openembedded.org/mt/112197845/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] source-highlight: re-add recipe
That's fair enough. My thinking was to try to upstream first to core, since it used to be there before it was removed, and to also get feedback on whether you would want to enable this per default gdb. I can also move it to meta-oe if you think it is better.
Étienne
Quoted 114 lines · Alexander Kanavin
Unless you want to enable it by default in gdb (and the other patch shows that is not the case), source-highlight does not have to be in core. We have plenty of recipes in core with options that require items from meta-oe or other layers.
Alex
Quoted 4 lines · Etienne Cordonnier via lists.openembedded.org
From: Etienne Cordonnier <[email protected]>
source-highlight version 3.1.8 was removed in
https://urldefense.proofpoint.com/v2/url?u=https-3A__web.git.yoctoproject.org_poky_commit_-3Fid-3D6560db9ddfd39a2715ede96430228306b00f53dd&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=GDekE4em2Y0dcrW5i9p81jWBM-rLGDqNCZJM66b8ZzI&e=
in June 2019 because the was no user left,Quoted 1 line
however there is now a gdb PACKAGECONFIG option which uses it. Since the
last release was in 2019, let's rather use the latest git version.
Quoted 7 lines
Signed-off-by Etienne Cordonnier <[email protected]>--- meta/conf/distro/include/maintainers.inc | 1 + .../source-highlight/source-highlight_git.bb | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 meta/recipes-support/source-highlight/source-highlight_git.bb
Review
Quoted 2 lines
(quoted diff) +0
-0b/meta/conf/distro/include/maintainers.inc
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <
Quoted 4 lines
index
2b47d3103c0..831494312b6100644meta/conf/distro/include/maintainers.inc +0
-0@@ -777,6 +777,7 @@ RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned < · line 777
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-signing-keys = "Richard Purdie <meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <[email protected]
Quoted 3 lines
meta/conf/distro/include/maintainers.inc +1
-0RECIPE_MAINTAINER:pn-slang = "Yi Zhao <[email protected]>" RECIPE_MAINTAINER:pn-socat = "Hongxu Jia <[email protected]>" +RECIPE_MAINTAINER:pn-source-highlight = "Etienne Cordonnier <meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned < · line 781
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-speex = "Michael Opdenacker <meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned < · line 782
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-speexdsp = "Michael Opdenacker <meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned < · line 783
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-spirv-headers = "Jose Quaresma <Review
Quoted 1 line
(quoted diff) +0
-0source-highlight_git.bb b/meta/recipes-support/source-highlight/ source-highlight_git.bb
meta/recipes-support/source-highlight/source-highlight_git.bb line 2
Quoted 7 lines
new file mode 100644
index 00000000000..ad5085250cbmeta/recipes-support/source-highlight/source-highlight_git.bb new file +2
-0@@ -0,0 +1,36 @@ +SUMMARY = "Syntax highlight utility" +DESCRIPTION = "Source-highlight converts source code to formatted textwith syntax highlighting."
meta/recipes-support/source-highlight/source-highlight_git.bb line 3
Quoted 1 line
meta/recipes-support/source-highlight/source-highlight_git.bb new file +1
-0+HOMEPAGE = "meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +3
-0+LICENSE = "GPL-3.0-only" +SECTION = "libs" +LIC_FILES_CHKSUM ="file://COPYING;;md5=ff95bfe019feaf92f524b73dd79e76eb"
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 4 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +4
-0+ +SRCREV = "894cacd0799ca60afa359a63782729dec76cbb79" +PV = "3.1.9+git" +SRC_URI = "git://git.savannah.gnu.org/git/src-highlite.git;protocol=https;branch=master"
Quoted 12 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +12
-0+S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +DEPENDS:append = " bison-native boost" + +DEPENDS:append:class-target = " ${PN}-native" + +EXTRA_OECONF="--with-boost-regex=boost_regex" + +BBCLASSEXTEND = "native nativesdk" +meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 10 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +10
-0+PACKAGES += "${PN}-tools ${PN}-data" + +RDEPENDS:${PN} = "boost-regex ${PN}-data" +RDEPENDS:${PN}-tools = "${PN} ${PN}-data bash" + +FILES:${PN} = "${libdir}/*${SOLIBS}" +FILES:${PN}-data = "${datadir}/source-highlight" +FILES:${PN}-tools = "${bindir} ${sysconfdir}/bash_completion.d" + +# source-highlight is using its own binary from the build tree to makedocumentation
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +3
-0+# let's substitute the native binary instead +do_configure:prepend:class-target () { + sed -i -e 's,^SRCHILITEEXE = $(top_builddir).*,SRCHILITEEXE =source-highlight,' ${S}/doc/Makefile.am
Quoted 8 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +1
-1+} --2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#214702):Quoted 1 line
Mute This Topic:
Quoted 2 lines
Group Owner: [email protected] Unsubscribe:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=JcEYIhnX11pblaVhmSRW-5aSQ5QHO6L9M7ugjPg0uWU&e=
[[email protected]]Quoted 2 lines
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] source-highlight: re-add recipe
I don;t think source highlighting in gdb quite qualifies as a core embedded functionality? I'd say meta-oe is better.
Alex
Quoted 96 lines · Etienne Cordonnier
That's fair enough. My thinking was to try to upstream first to core, since it used to be there before it was removed, and to also get feedback on whether you would want to enable this per default gdb. I can also move it to meta-oe if you think it is better.
Étienne
Quoted 90 lines · Alexander Kanavin
Unless you want to enable it by default in gdb (and the other patch shows that is not the case), source-highlight does not have to be in core. We have plenty of recipes in core with options that require items from meta-oe or other layers.
Alex
Quoted 79 lines · Etienne Cordonnier via lists.openembedded.org
From: Etienne Cordonnier <[email protected]>
source-highlight version 3.1.8 was removed in https://urldefense.proofpoint.com/v2/url?u=https-3A__web.git.yoctoproject.org_poky_commit_-3Fid-3D6560db9ddfd39a2715ede96430228306b00f53dd&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=GDekE4em2Y0dcrW5i9p81jWBM-rLGDqNCZJM66b8ZzI&e= in June 2019 because the was no user left, however there is now a gdb PACKAGECONFIG option which uses it. Since the last release was in 2019, let's rather use the latest git version.
Signed-off-by Etienne Cordonnier <[email protected]>--- meta/conf/distro/include/maintainers.inc | 1 + .../source-highlight/source-highlight_git.bb | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 meta/recipes-support/source-highlight/source-highlight_git.bbmeta/conf/distro/include/maintainers.inc +1
-0@@ -777,6 +777,7 @@ RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <[email protected] RECIPE_MAINTAINER:pn-signing-keys = "Richard Purdie <[email protected]>" RECIPE_MAINTAINER:pn-slang = "Yi Zhao <[email protected]>" RECIPE_MAINTAINER:pn-socat = "Hongxu Jia <[email protected]>" +RECIPE_MAINTAINER:pn-source-highlight = "Etienne Cordonnier <[email protected]>" RECIPE_MAINTAINER:pn-speex = "Michael Opdenacker <[email protected]>" RECIPE_MAINTAINER:pn-speexdsp = "Michael Opdenacker <[email protected]>" RECIPE_MAINTAINER:pn-spirv-headers = "Jose Quaresma <[email protected]>"meta/recipes-support/source-highlight/source-highlight_git.bb new file +36
-1@@ -0,0 +1,36 @@ +SUMMARY = "Syntax highlight utility" +DESCRIPTION = "Source-highlight converts source code to formatted text with syntax highlighting." +HOMEPAGE = "https://urldefense.proofpoint.com/v2/url?u=https-3A__www.gnu.org_software_src-2Dhighlite_&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=lwbvDkI4fDkloLf3cs3QeCgqOBF_LRpfobo2v-EYtEc&e= " +LICENSE = "GPL-3.0-only" +SECTION = "libs" +LIC_FILES_CHKSUM = "file://COPYING;;md5=ff95bfe019feaf92f524b73dd79e76eb" + +SRCREV = "894cacd0799ca60afa359a63782729dec76cbb79" +PV = "3.1.9+git" +SRC_URI = "git://git.savannah.gnu.org/git/src-highlite.git;protocol=https;branch=master" +S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +DEPENDS:append = " bison-native boost" + +DEPENDS:append:class-target = " ${PN}-native" + +EXTRA_OECONF="--with-boost-regex=boost_regex" + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES += "${PN}-tools ${PN}-data" + +RDEPENDS:${PN} = "boost-regex ${PN}-data" +RDEPENDS:${PN}-tools = "${PN} ${PN}-data bash" + +FILES:${PN} = "${libdir}/*${SOLIBS}" +FILES:${PN}-data = "${datadir}/source-highlight" +FILES:${PN}-tools = "${bindir} ${sysconfdir}/bash_completion.d" + +# source-highlight is using its own binary from the build tree to make documentation +# let's substitute the native binary instead +do_configure:prepend:class-target () { + sed -i -e 's,^SRCHILITEEXE = $(top_builddir).*,SRCHILITEEXE = source-highlight,' ${S}/doc/Makefile.am +} --2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#214702): https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_214702&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=59gbMbCXZ3BY1pfUB3UCI5Czkn6drHSb9wkgR4-e3Ls&e=
Mute This Topic: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_112197845_1686489&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=Ll_TLcnLKTlhI4Rm2kaZpieo_LWka4TfPLOsJ6o8ER4&e=
Group Owner: [email protected]
Unsubscribe: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=JcEYIhnX11pblaVhmSRW-5aSQ5QHO6L9M7ugjPg0uWU&e= [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] source-highlight: re-add recipe
OK, in that case except if I receive other opinions, I would propose to merge the patch adding the PACKAGECONFIG option to gdb, and I'll send another PR adding source-highlight to meta-oe.
Étienne
Quoted 133 lines · Alexander Kanavin
I don;t think source highlighting in gdb quite qualifies as a core embedded functionality? I'd say meta-oe is better.
Alex
Quoted 2 lines · Etienne Cordonnier
That's fair enough. My thinking was to try to upstream first to core,
since it used to be there before it was removed, and to also get feedback on whether you would want to enable this per default gdb. I can also move it to meta-oe if you think it is better.
Quoted 4 lines
Étienne
On Thu, Apr 10, 2025 at 9:28 PM Alexander Kanavin <
Quoted 8 lines · [email protected]> wrote:
Quoted 8 lines
Unless you want to enable it by default in gdb (and the other patch shows that is not the case), source-highlight does not have to be in core. We have plenty of recipes in core with options that require items from meta-oe or other layers.
Alex
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines · Etienne Cordonnier via lists.openembedded.org
From: Etienne Cordonnier <[email protected]>
source-highlight version 3.1.8 was removed in
https://urldefense.proofpoint.com/v2/url?u=https-3A__web.git.yoctoproject.org_poky_commit_-3Fid-3D6560db9ddfd39a2715ede96430228306b00f53dd&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=GDekE4em2Y0dcrW5i9p81jWBM-rLGDqNCZJM66b8ZzI&e=
in June 2019 because the was no user left,Quoted 1 line
Quoted 1 line
Quoted 1 line
however there is now a gdb PACKAGECONFIG option which uses it. Since
the last release was in 2019, let's rather use the latest git version.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Signed-off-by Etienne Cordonnier <[email protected]>--- meta/conf/distro/include/maintainers.inc | 1 + .../source-highlight/source-highlight_git.bb | 36+++++++++++++++++++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
2 files changed, 37 insertions(+) create mode 100644 meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 2 lines
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +0
-0b/meta/conf/distro/include/maintainers.inc
Quoted 4 lines
Quoted 4 lines
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop =
Quoted 4 lines
index
2b47d3103c0..831494312b6100644meta/conf/distro/include/maintainers.inc +0
-0@@ -777,6 +777,7 @@ RECIPE_MAINTAINER:pn-shutdown-desktop ="Unassigned <[email protected]
Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 777
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-signing-keys = "Richard Purdie <Quoted 3 lines
Quoted 3 lines
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = "Unassigned <[email protected]
Quoted 3 lines
meta/conf/distro/include/maintainers.inc +1
-0RECIPE_MAINTAINER:pn-slang = "Yi Zhao <[email protected]>" RECIPE_MAINTAINER:pn-socat = "Hongxu Jia <[email protected]>" +RECIPE_MAINTAINER:pn-source-highlight = "Etienne Cordonnier <Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 781
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-speex = "Michael Opdenacker <Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 782
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-speexdsp = "Michael Opdenacker <Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 783
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-spirv-headers = "Jose Quaresma <Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0source-highlight_git.bb b/meta/recipes-support/source-highlight/ source-highlight_git.bb
Quoted 7 lines
Quoted 7 lines
meta/recipes-support/source-highlight/source-highlight_git.bb line 2
Quoted 7 lines
new file mode 100644
index 00000000000..ad5085250cbmeta/recipes-support/source-highlight/source-highlight_git.bb new file +2
-0@@ -0,0 +1,36 @@ +SUMMARY = "Syntax highlight utility" +DESCRIPTION = "Source-highlight converts source code to formattedtext with syntax highlighting."
Quoted 1 line
Quoted 1 line
meta/recipes-support/source-highlight/source-highlight_git.bb line 3
Quoted 1 line
meta/recipes-support/source-highlight/source-highlight_git.bb new file +1
-0+HOMEPAGE = "Quoted 3 lines
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +3
-0+LICENSE = "GPL-3.0-only" +SECTION = "libs" +LIC_FILES_CHKSUM ="file://COPYING;;md5=ff95bfe019feaf92f524b73dd79e76eb"
Quoted 4 lines
Quoted 4 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 4 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +4
-0+ +SRCREV = "894cacd0799ca60afa359a63782729dec76cbb79" +PV = "3.1.9+git" +SRC_URI = "git://git.savannah.gnu.org/git/src-highlite.git;protocol=https;branch=master"
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +14
-0+S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +DEPENDS:append = " bison-native boost" + +DEPENDS:append:class-target = " ${PN}-native" + +EXTRA_OECONF="--with-boost-regex=boost_regex" + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES += "${PN}-tools ${PN}-data" +Quoted 8 lines
Quoted 8 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 8 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +8
-0+RDEPENDS:${PN} = "boost-regex ${PN}-data" +RDEPENDS:${PN}-tools = "${PN} ${PN}-data bash" + +FILES:${PN} = "${libdir}/*${SOLIBS}" +FILES:${PN}-data = "${datadir}/source-highlight" +FILES:${PN}-tools = "${bindir} ${sysconfdir}/bash_completion.d" + +# source-highlight is using its own binary from the build tree tomake documentation
Quoted 3 lines
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +3
-0+# let's substitute the native binary instead +do_configure:prepend:class-target () { + sed -i -e 's,^SRCHILITEEXE = $(top_builddir).*,SRCHILITEEXE =source-highlight,' ${S}/doc/Makefile.am
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +1
-1+} --2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#214702):Quoted 1 line
Quoted 1 line
Quoted 1 line
Mute This Topic:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Group Owner: [email protected] Unsubscribe:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=JcEYIhnX11pblaVhmSRW-5aSQ5QHO6L9M7ugjPg0uWU&e=
[[email protected]]Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
-=-=-=-=-=-=-=-=-=-=-=-
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [OE-core] [PATCH 2/2] source-highlight: re-add recipe
The recipe has been merged in meta-oe, thus this patch 2/2 "source-highlight: re-add recipe" should not be merged in oe-core. I would still like to merge the patch 1/2 "gdb: add source-highlight PACKAGECONFIG option" into oe-core however.
Étienne
Quoted 156 lines · Etienne Cordonnier via lists.openembedded.org
OK, in that case except if I receive other opinions, I would propose to merge the patch adding the PACKAGECONFIG option to gdb, and I'll send another PR adding source-highlight to meta-oe.
Étienne
Quoted 121 lines · Alexander Kanavin
I don;t think source highlighting in gdb quite qualifies as a core embedded functionality? I'd say meta-oe is better.
Alex
Quoted 2 lines · Etienne Cordonnier
That's fair enough. My thinking was to try to upstream first to core,
since it used to be there before it was removed, and to also get feedback on whether you would want to enable this per default gdb. I can also move it to meta-oe if you think it is better.
Quoted 4 lines
Étienne
On Thu, Apr 10, 2025 at 9:28 PM Alexander Kanavin <
Quoted 10 lines · [email protected]> wrote:
Quoted 10 lines
Unless you want to enable it by default in gdb (and the other patch shows that is not the case), source-highlight does not have to be in core. We have plenty of recipes in core with options that require items from meta-oe or other layers.
Alex
On Thu, 10 Apr 2025 at 21:26, Etienne Cordonnier via lists.openembedded.org
<https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openembedded.org&d=DwMFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=t2HL6XaHbnfyOul6lHPhmnc0jRotjdxDqaD0W3qUQ2k&e=>
<[email protected]>Quoted 5 lines
Quoted 5 lines
Quoted 4 lines · wrote:
From: Etienne Cordonnier <[email protected]>
source-highlight version 3.1.8 was removed in
https://urldefense.proofpoint.com/v2/url?u=https-3A__web.git.yoctoproject.org_poky_commit_-3Fid-3D6560db9ddfd39a2715ede96430228306b00f53dd&d=DwIBaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=jBI-VlyTB1xFAWS9hMggBpmdK5DJQqcmgvLfhQ68ddzZf4_yp3Vldzt83qQW4zvi&s=GDekE4em2Y0dcrW5i9p81jWBM-rLGDqNCZJM66b8ZzI&e=
in June 2019 because the was no user left,Quoted 1 line
Quoted 1 line
Quoted 1 line
however there is now a gdb PACKAGECONFIG option which uses it. Since
the last release was in 2019, let's rather use the latest git version.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Signed-off-by Etienne Cordonnier <[email protected]>--- meta/conf/distro/include/maintainers.inc | 1 +.../source-highlight/source-highlight_git.bb
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
2 files changed, 37 insertions(+) create mode 100644 meta/recipes-support/source-highlight/Quoted 2 lines
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +0
-0b/meta/conf/distro/include/maintainers.inc
Quoted 4 lines
Quoted 4 lines
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop =
Quoted 4 lines
index
2b47d3103c0..831494312b6100644meta/conf/distro/include/maintainers.inc +0
-0@@ -777,6 +777,7 @@ RECIPE_MAINTAINER:pn-shutdown-desktop ="Unassigned <[email protected]
Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 777
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-signing-keys = "Richard Purdie <Quoted 4 lines
Quoted 2 lines
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 779
Quoted 2 lines
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-slang = "Yi Zhao <[email protected]>" RECIPE_MAINTAINER:pn-socat = "Hongxu Jia <[email protected]"
Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc +1
-0+RECIPE_MAINTAINER:pn-source-highlight = "Etienne Cordonnier <Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 781
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-speex = "Michael Opdenacker <Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 782
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-speexdsp = "Michael Opdenacker <Quoted 1 line
Quoted 1 line
meta/conf/distro/include/maintainers.inc RECIPE_MAINTAINER:pn-shutdown-desktop = · line 783
Quoted 1 line
meta/conf/distro/include/maintainers.inc +0
-0RECIPE_MAINTAINER:pn-spirv-headers = "Jose Quaresma <Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0source-highlight_git.bb
<https://urldefense.proofpoint.com/v2/url?u=http-3A__source-2Dhighlight-5Fgit.bb&d=DwMFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=N4_1lMw_iULEa5kI0yuDTOxIdU2snOyXIDqnmJzcglk&e=>
b/meta/recipes-support/source-highlight/source-highlight_git.bb
<https://urldefense.proofpoint.com/v2/url?u=http-3A__source-2Dhighlight-5Fgit.bb&d=DwMFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=N4_1lMw_iULEa5kI0yuDTOxIdU2snOyXIDqnmJzcglk&e=>Quoted 4 lines
Quoted 4 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 4 lines
new file mode 100644
index 00000000000..ad5085250cbmeta/recipes-support/source-highlight/source-highlight_git.bb new file +0
-0Quoted 3 lines
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb line 2
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +2
-0@@ -0,0 +1,36 @@ +SUMMARY = "Syntax highlight utility" +DESCRIPTION = "Source-highlight converts source code to formattedtext with syntax highlighting."
Quoted 1 line
Quoted 1 line
meta/recipes-support/source-highlight/source-highlight_git.bb line 3
Quoted 1 line
meta/recipes-support/source-highlight/source-highlight_git.bb new file +1
-0+HOMEPAGE = "Quoted 3 lines
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +3
-0+LICENSE = "GPL-3.0-only" +SECTION = "libs" +LIC_FILES_CHKSUM ="file://COPYING;;md5=ff95bfe019feaf92f524b73dd79e76eb"
Quoted 4 lines
Quoted 4 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 4 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +4
-0+ +SRCREV = "894cacd0799ca60afa359a63782729dec76cbb79" +PV = "3.1.9+git" +SRC_URI = "git://git.savannah.gnu.org/git/src-highlite.git;protocol=https;branch=master
<https://urldefense.proofpoint.com/v2/url?u=http-3A__git.savannah.gnu.org_git_src-2Dhighlite.git-3Bprotocol-3Dhttps-3Bbranch-3Dmaster&d=DwMFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=br3YXbaxuyHAty0PKTXl9dyDgQdvPpIiJloBrrqTsOg&e=>
"Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +14
-0+S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +DEPENDS:append = " bison-native boost" + +DEPENDS:append:class-target = " ${PN}-native" + +EXTRA_OECONF="--with-boost-regex=boost_regex" + +BBCLASSEXTEND = "native nativesdk" + +PACKAGES += "${PN}-tools ${PN}-data" +Quoted 8 lines
Quoted 8 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 8 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +8
-0+RDEPENDS:${PN} = "boost-regex ${PN}-data" +RDEPENDS:${PN}-tools = "${PN} ${PN}-data bash" + +FILES:${PN} = "${libdir}/*${SOLIBS}" +FILES:${PN}-data = "${datadir}/source-highlight" +FILES:${PN}-tools = "${bindir} ${sysconfdir}/bash_completion.d" + +# source-highlight is using its own binary from the build tree tomake documentation
Quoted 12 lines
Quoted 3 lines
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb
Quoted 3 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +3
-0+# let's substitute the native binary instead +do_configure:prepend:class-target () { + sed -i -e 's,^SRCHILITEEXE = $(top_builddir).*,SRCHILITEEXE =source-highlight,' ${S}/doc/Makefile.am
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta/recipes-support/source-highlight/source-highlight_git.bb new file +1
-1+} --2.43.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#214718):
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_214718&d=DwIFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=djq36a_AhIUqATKwgJZ04sTfLa3fDmS3XP5zNHUf5gc&e=
Mute This Topic:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_112197845_7048771&d=DwIFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=zDx6WY1qU45V-oTmByaiPVl1Jwya48XRdV0JNKgCpa4&e=
Group Owner: [email protected] Unsubscribe:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIFaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ImlpzOYPYvdpW2UCTlhBGFCg4PcUQJXyRCS-oYVlmmSXFs_Llqej2MWMKkIVrLzf&s=UbC2G3fAWcrzu-oU-WelpYgh4gurV0G68EJtqUvlFBU&e=
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-