Skip to contentSkip to conversation

KVM: powerpc: Enable commented out BUILD_BUG_ON() assertion

PATCH RESEND New Thorsten Blum 1 participant 1 message Apr 11, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 KVM: powerpc: Enable commented out BUILD_BUG_ON() assertion

The BUILD_BUG_ON() assertion was commented out in commit 38634e676992 ("powerpc/kvm: Remove problematic BUILD_BUG_ON statement") and fixed in commit c0a187e12d48 ("KVM: powerpc: Fix BUILD_BUG_ON condition"), but not enabled. Enable it now that this no longer breaks and remove the comment.

---
 arch/powerpc/kvm/timing.h | 4 ----
 1 file changed, 4 deletions(-)
arch/powerpc/kvm/timing.h +0 -4
index 45817ab82bb4..14b0e23f601f 100644
@@ -38,11 +38,7 @@ static inline void kvmppc_set_exit_type(struct kvm_vcpu *vcpu, int type) {}
 static inline void kvmppc_account_exit_stat(struct kvm_vcpu *vcpu, int type)
 {
 	/* type has to be known at build time for optimization */
-
-	/* The BUILD_BUG_ON below breaks in funny ways, commented out
-	 * for now ... -BenH
 	BUILD_BUG_ON(!__builtin_constant_p(type));
-	*/
 	switch (type) {
 	case EXT_INTR_EXITS:
 		vcpu->stat.ext_intr_exits++;
Signature · 1 line
2.49.0