Skip to contentSkip to conversation

tty: serial: 8250: Fix uninitialized variable warnings in pci_oxsemi_tornado_get_divisor

PATCH In review Purva Yeshi 2 participants 2 messages Apr 11, 2025 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty: serial: 8250: Fix uninitialized variable warnings in pci_oxsemi_tornado_get_divisor

Fix Smatch-detected issue:

drivers/tty/serial/8250/8250_pci.c:1233 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'tcr'. drivers/tty/serial/8250/8250_pci.c:1234 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'quot'. drivers/tty/serial/8250/8250_pci.c:1238 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'quot'. drivers/tty/serial/8250/8250_pci.c:1242 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'cpr'. drivers/tty/serial/8250/8250_pci.c:1252 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'cpr'.

Fix uninitialized variable usage in pci_oxsemi_tornado_get_divisor() that was triggering sparse warnings and potential undefined behavior. The variables tcr, cpr, and quot were used before being explicitly assigned values, leading to smatch warning in multiple lines of the function.

Initialize quot to 1, tcr to 16, and cpr to OXSEMI_TORNADO_CPR_DEF at the point of declaration. This ensures safe fallback values are used when these variables are not conditionally set later in the function, avoiding uninitialized access.

---
 drivers/tty/serial/8250/8250_pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/tty/serial/8250/8250_pci.c +3 -3
index 73c200127b08..ba4dedccc29e 100644
@@ -1187,9 +1187,9 @@ static unsigned int pci_oxsemi_tornado_get_divisor(struct uart_port *port,
 	unsigned int sdiv = DIV_ROUND_CLOSEST(sclk, baud);
 	unsigned int best_squot;
 	unsigned int squot;
-	unsigned int quot;
-	u16 cpr;
-	u8 tcr;
+	unsigned int quot = 1;
+	u16 cpr = OXSEMI_TORNADO_CPR_DEF;  /* Default Control Prescaler Register */
+	u8 tcr = 16;  /* Typical default value for the Timer Control Register */
 	int i;
 
 	/* Old custom speed handling.  */
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 13 lines · Purva Yeshi

Fix Smatch-detected issue:

drivers/tty/serial/8250/8250_pci.c:1233 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'tcr'. drivers/tty/serial/8250/8250_pci.c:1234 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'quot'. drivers/tty/serial/8250/8250_pci.c:1238 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'quot'. drivers/tty/serial/8250/8250_pci.c:1242 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'cpr'. drivers/tty/serial/8250/8250_pci.c:1252 pci_oxsemi_tornado_get_divisor()
error: uninitialized symbol 'cpr'.

Quoted 4 lines

Fix uninitialized variable usage in pci_oxsemi_tornado_get_divisor() that was triggering sparse warnings and potential undefined behavior. The variables tcr, cpr, and quot were used before being explicitly assigned values, leading to smatch warning in multiple lines of the function.

Are you really sure? If you follow through the logic, it looks fine to me. What am I missing? And why doesn't gcc or clang catch this?

Quoted 4 lines

Initialize quot to 1, tcr to 16, and cpr to OXSEMI_TORNADO_CPR_DEF at the point of declaration. This ensures safe fallback values are used when these variables are not conditionally set later in the function, avoiding uninitialized access.

Where did these magic values come from?

thanks,

greg k-h