Skip to contentSkip to conversation

drm/amdgpu/gfx: replace a comma with a semicolon

PATCH In review Alex Deucher 3 participants 3 messages Apr 11, 2025

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/gfx: replace a comma with a semicolon

Not techincally wrong, but I think a semicolon was intended here.

Fixes 6cc6e61788f7 ("drm/amdgpu: use a dummy owner for sysfs triggered cleaner shaders v3")
Cc Christian König <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +1 -1
index f1b87b177f4e3..c206c3b371ad0 100644
@@ -1460,7 +1460,7 @@ static int amdgpu_gfx_run_cleaner_shader_job(struct amdgpu_ring *ring)
 	 * the cleaner shader on each submission. The value just need to change
 	 * for each submission and is otherwise meaningless.
 	 */
-	owner = (void *)(unsigned long)atomic_inc_return(&counter),
+	owner = (void *)(unsigned long)atomic_inc_return(&counter);
 
 	r = amdgpu_job_alloc_with_ib(ring->adev, &entity, owner,
 				     64, 0, &job);
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Alex Deucher

Not techincally wrong, but I think a semicolon was intended here.

Fixes 6cc6e61788f7 ("drm/amdgpu: use a dummy owner for sysfs triggered cleaner shaders v3")
Cc Christian König <[email protected]>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +0 -0
index f1b87b177f4e3..c206c3b371ad0 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c static int amdgpu_gfx_run_cleaner_shader_job(struct amdgpu_ring *ring) · line 1466

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +1 -1
@@ -1460,7 +1460,7 @@ static int amdgpu_gfx_run_cleaner_shader_job(struct amdgpu_ring *ring)
  	 * the cleaner shader on each submission. The value just need to change
  	 * for each submission and is otherwise meaningless.
  	 */
-	owner = (void *)(unsigned long)atomic_inc_return(&counter),
+	owner = (void *)(unsigned long)atomic_inc_return(&counter);
 
  	r = amdgpu_job_alloc_with_ib(ring->adev, &entity, owner,
  				     64, 0, &job);
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Alex Deucher

Am 11.04.25 um 16:20 schrieb Alex Deucher:

Quoted 6 lines

Not techincally wrong, but I think a semicolon was intended here.

Fixes 6cc6e61788f7 ("drm/amdgpu: use a dummy owner for sysfs triggered cleaner shaders v3")
Cc Christian König <[email protected]>
Quoted 17 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +1 -1
index f1b87b177f4e3..c206c3b371ad0 100644
@@ -1460,7 +1460,7 @@ static int amdgpu_gfx_run_cleaner_shader_job(struct amdgpu_ring *ring)
 	 * the cleaner shader on each submission. The value just need to change
 	 * for each submission and is otherwise meaningless.
 	 */
-	owner = (void *)(unsigned long)atomic_inc_return(&counter),
+	owner = (void *)(unsigned long)atomic_inc_return(&counter);
 
 	r = amdgpu_job_alloc_with_ib(ring->adev, &entity, owner,
 				     64, 0, &job);