Skip to contentSkip to conversation

MAINTAINERS: Add mmap trace events to MEMORY MAPPING

PATCH Applied Liam R. Howlett 4 participants 6 messages Apr 11, 2025 – Apr 15, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add mmap trace events to MEMORY MAPPING

MEMORY MAPPING does not list the mmap.h trace point file, but does list the mmap.c file. Couple the trace points with the users and authors of the trace points for notifications of updates.

Cc Andrew Morton <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Jann Horn <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 4c7fdc41a6bfb..d8e9a10adc81d 100644
@@ -15571,6 +15571,7 @@ L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h
 F:	mm/mlock.c
 F:	mm/mmap.c
 F:	mm/mprotect.c
Signature · 1 line
2.43.0
#1 lore raw
Quoted 9 lines · On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <[email protected]>…

MEMORY MAPPING does not list the mmap.h trace point file, but does list the mmap.c file. Couple the trace points with the users and authors of the trace points for notifications of updates.

Cc Andrew Morton <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Jann Horn <[email protected]>

MAINTAINERS L: [email protected] · line 15574

Quoted 13 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 4c7fdc41a6bfb..d8e9a10adc81d 100644
@@ -15571,6 +15571,7 @@ L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h

Should mmap_lock.h also be added here?

Quoted 5 lines
MAINTAINERS +0 -0
 F:	mm/mlock.c
 F:	mm/mmap.c
 F:	mm/mprotect.c
Signature · 1 line
2.43.0

Thanks,
SJ

#2 lore raw
Quoted 18 lines · SeongJae Park
Quoted 9 lines · On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <[email protected]>…

MEMORY MAPPING does not list the mmap.h trace point file, but does list the mmap.c file. Couple the trace points with the users and authors of the trace points for notifications of updates.

Cc Andrew Morton <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Jann Horn <[email protected]>
Quoted 4 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

MAINTAINERS L: [email protected] · line 15574

Quoted 9 lines
MAINTAINERS +1 -0
index 4c7fdc41a6bfb..d8e9a10adc81d 100644
@@ -15571,6 +15571,7 @@ L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h

Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with mm/mmap_lock.c, which also isn't listed here. Both exist for tracing as well.

There is also include/linux/mmap_lock.h, which is the locking itself. The mmap lock is used more broadly than just these files: mm/pagewalk.c and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Thanks for bringing this up,
Liam

#3 lore raw
Quoted 1 line · On Sat, 12 Apr 2025 09:17:21 -0400 "Liam R. Howlett" <[email protected]>…

* SeongJae Park <[email protected]> [250411 13:47]:

[...]

Quoted 14 lines
Quoted 7 lines

MAINTAINERS L: [email protected] · line 15574

Quoted 5 lines
MAINTAINERS +1 -0
@@ -15571,6 +15571,7 @@ L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h

Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with mm/mmap_lock.c, which also isn't listed here. Both exist for tracing as well.

Quoted 5 lines

There is also include/linux/mmap_lock.h, which is the locking itself. The mmap lock is used more broadly than just these files: mm/pagewalk.c and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Makes perfect sense. Thank you for kindly clarifying this.

Thanks,
SJ

[...]

maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Liam R. Howlett
Quoted 18 lines · On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <[email protected]>…

MEMORY MAPPING does not list the mmap.h trace point file, but does list the mmap.c file. Couple the trace points with the users and authors of the trace points for notifications of updates.

Cc Andrew Morton <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Jann Horn <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 4c7fdc41a6bfb..d8e9a10adc81d 100644

MAINTAINERS L: [email protected] · line 15574

Quoted 4 lines
MAINTAINERS +1 -0
@@ -15571,6 +15571,7 @@ L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h

-- Steve

Quoted 3 lines
MAINTAINERS +0 -0
 F:	mm/mlock.c
 F:	mm/mmap.c
 F:	mm/mprotect.c
Acked-by on v1 1/1
#5 lore raw
In reply to Liam R. Howlett
Quoted 9 lines · Liam R. Howlett

MEMORY MAPPING does not list the mmap.h trace point file, but does list the mmap.c file. Couple the trace points with the users and authors of the trace points for notifications of updates.

Cc Andrew Morton <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Jann Horn <[email protected]>
Quoted 16 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 4c7fdc41a6bfb..d8e9a10adc81d 100644
@@ -15571,6 +15571,7 @@ L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h
 F:	mm/mlock.c
 F:	mm/mmap.c
 F:	mm/mprotect.c