Skip to contentSkip to conversation

dt-bindings: media: convert fsl-vdoa.txt to yaml format

PATCH In review Frank Li 3 participants 7 messages Apr 11, 2025 – Jun 16, 2025

Subsystems (3)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: media: convert fsl-vdoa.txt to yaml format

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++
 .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------
 2 files changed, 42 insertions(+), 21 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt
Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml new file +42 -0
new file mode 100644
index 0000000000000..511ac0d67a7f2
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/fsl,imx6q-vdoa.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale Video Data Order Adapter
+
+description:
+  The Video Data Order Adapter (VDOA) is present on the i.MX6q. Its sole purpose
+  is to reorder video data from the macroblock tiled order produced by the CODA
+  960 VPU to the conventional raster-scan order for scanout.
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    const: "fsl,imx6q-vdoa"
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/clock/imx6qdl-clock.h>
+
+    vdoa@21e4000 {
+        compatible = "fsl,imx6q-vdoa";
+        reg = <0x021e4000 0x4000>;
+        interrupts = <0 18 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&clks IMX6QDL_CLK_VDOA>;
+    };
Documentation/devicetree/bindings/media/fsl-vdoa.txt deleted +0 -21
deleted file mode 100644
index 6c5628530bb7b..0000000000000
@@ -1,21 +0,0 @@
-Freescale Video Data Order Adapter
-==================================
-
-The Video Data Order Adapter (VDOA) is present on the i.MX6q. Its sole purpose
-is to reorder video data from the macroblock tiled order produced by the CODA
-960 VPU to the conventional raster-scan order for scanout.
-
-Required properties:
-- compatible: must be "fsl,imx6q-vdoa"
-- reg: the register base and size for the device registers
-- interrupts: the VDOA interrupt
-- clocks: the vdoa clock
-
-Example:
-
-vdoa@21e4000 {
-        compatible = "fsl,imx6q-vdoa";
-        reg = <0x021e4000 0x4000>;
-        interrupts = <0 18 IRQ_TYPE_LEVEL_HIGH>;
-        clocks = <&clks IMX6QDL_CLK_VDOA>;
-};
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Frank Li

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

Quoted 8 lines
---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++
 .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------
 2 files changed, 42 insertions(+), 21 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt
author maintainer
#2 lore raw
Quoted 16 lines · Rob Herring (Arm)
Quoted 5 lines · Frank Li

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

Quoted 8 lines
---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++
 .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------
 2 files changed, 42 insertions(+), 21 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt
Quoted 1 line

All:
Anyone pick this patch?

Frank

Quoted 1 line
#3 lore raw

Hi Frank,

Le jeudi 22 mai 2025 à 14:49 -0400, Frank Li a écrit :

Quoted 17 lines · Rob Herring (Arm)
Quoted 16 lines · Frank Li
Quoted 13 lines

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++ .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------

 2 files changed, 42 insertions(+), 21 deletions(-)

 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt

Quoted 4 lines
Quoted 1 line

All:
Anyone pick this patch?

Thanks for the highlight, this is stuff from before my time and I had not associated it with CODA initially. I've picked it now.

regards,
Nicolas

Quoted 3 lines

Frank

Quoted 1 line
#4 lore raw

Hi again,

Le jeudi 22 mai 2025 à 14:57 -0400, Nicolas Dufresne a écrit :

Quoted 20 lines

Hi Frank,

Le jeudi 22 mai 2025 à 14:49 -0400, Frank Li a écrit :

Quoted 17 lines · Rob Herring (Arm)
Quoted 16 lines · Frank Li
Quoted 13 lines

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++ .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------

 2 files changed, 42 insertions(+), 21 deletions(-)

 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

All:
Anyone pick this patch?

Thanks for the highlight, this is stuff from before my time and I had not associated it with CODA initially. I've picked it now.

Actually, before I do so, any of the following warnings should be addressed ? I effectively don't see a clear entry for that bindings, but could have miss-read and there is a second warning, which based on having Rb is likely false positive ?

---
[[ATTACHMENT|junit/./0001-dt-bindings-media-convert-fsl-vdoa.txt-to-yaml-forma.patch checkpatch.err.txt]]
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting- patches.rst

total: 0 errors, 2 warnings, 0 checks, 42 lines checked
---

Nicolas

Quoted 7 lines

regards,
Nicolas

Quoted 3 lines

Frank

Quoted 1 line
author maintainer
#5 lore raw
Quoted 28 lines · Nicolas Dufresne

Hi again,

Le jeudi 22 mai 2025 à 14:57 -0400, Nicolas Dufresne a écrit :

Quoted 25 lines

Hi Frank,

Le jeudi 22 mai 2025 à 14:49 -0400, Frank Li a écrit :

Quoted 21 lines · Rob Herring (Arm)
Quoted 16 lines · Frank Li
Quoted 5 lines

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

Quoted 8 lines

---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++ .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------

 2 files changed, 42 insertions(+), 21 deletions(-)

 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt

Quoted 1 line

All:
Anyone pick this patch?

Quoted 6 lines
Quoted 2 lines

Thanks for the highlight, this is stuff from before my time and I had not associated it with CODA initially. I've picked it now.

Actually, before I do so, any of the following warnings should be addressed ? I effectively don't see a clear entry for that bindings, but could have miss-read and there is a second warning, which based on having Rb is likely false positive ?

The second warning is false alarm. When convert txt to yaml, only need update MAINTAINS only when old txt entry already in MAINTAINERS.

Quoted 9 lines

---
[[ATTACHMENT|junit/./0001-dt-bindings-media-convert-fsl-vdoa.txt-to-yaml-forma.patch checkpatch.err.txt]]
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting- patches.rst

This one is check patch script issue. I met many similar issues at convert txt to yaml.

Frank

Quoted 13 lines

total: 0 errors, 2 warnings, 0 checks, 42 lines checked
---

Nicolas

Quoted 7 lines

regards,
Nicolas

Quoted 3 lines

Frank

Quoted 1 line
author maintainer
#6 lore raw
Quoted 46 lines · Frank Li
Quoted 28 lines · Nicolas Dufresne

Hi again,

Le jeudi 22 mai 2025 à 14:57 -0400, Nicolas Dufresne a écrit :

Quoted 25 lines

Hi Frank,

Le jeudi 22 mai 2025 à 14:49 -0400, Frank Li a écrit :

Quoted 21 lines · Rob Herring (Arm)
Quoted 16 lines · Frank Li
Quoted 5 lines

Convert fsl-vdoa.txt to yaml format.

Additional changes:
- Add irq.h and imx6qdl-clock.h in example.

Quoted 8 lines

---
 .../bindings/media/fsl,imx6q-vdoa.yaml        | 42 +++++++++++++++++++ .../devicetree/bindings/media/fsl-vdoa.txt    | 21 ----------

 2 files changed, 42 insertions(+), 21 deletions(-)

 create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt

Quoted 1 line

All:
Anyone pick this patch?

Quoted 6 lines
Quoted 2 lines

Thanks for the highlight, this is stuff from before my time and I had not associated it with CODA initially. I've picked it now.

Actually, before I do so, any of the following warnings should be addressed ? I effectively don't see a clear entry for that bindings, but could have miss-read and there is a second warning, which based on having Rb is likely false positive ?

The second warning is false alarm. When convert txt to yaml, only need update MAINTAINS only when old txt entry already in MAINTAINERS.

Quoted 7 lines

---
[[ATTACHMENT|junit/./0001-dt-bindings-media-convert-fsl-vdoa.txt-to-yaml-forma.patch checkpatch.err.txt]]
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644

Quoted 5 lines
Quoted 2 lines

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting- patches.rst

This one is check patch script issue. I met many similar issues at convert txt to yaml.

Nicolas Dufresne:

Do you have still concern to pick up this patch?

Frank Li

Quoted 16 lines

Frank

Quoted 13 lines

total: 0 errors, 2 warnings, 0 checks, 42 lines checked
---

Nicolas

Quoted 7 lines

regards,
Nicolas

Quoted 3 lines

Frank

Quoted 1 line