Skip to contentSkip to conversation

rbtree: Fix typo in header comment

PATCH Superseded Po-Ying Chiu 2 participants 3 messages Apr 12, 2025 – Apr 15, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rbtree: Fix typo in header comment

Correct "drammatically" to "dramatically" in the rbtree.h header comment. This improves the readability of the header comment.

---
 include/linux/rbtree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/rbtree.h +1 -1
index 8d2ba3749866..78a7a260c36f 100644
@@ -7,7 +7,7 @@
   linux/include/linux/rbtree.h
 
   To use rbtrees you'll have to implement your own insert and search cores.
-  This will avoid us to use callbacks and to drop drammatically performances.
+  This will avoid us to use callbacks and to drop dramatically performances.
   I know it's not the cleaner way,  but in C (not in C++) to get
   performances and genericity...
 

base-commit: 2eb959eeecc64fa56e9f89a5fc496da297585cbe

Signature · 1 line
2.43.0
#1 lore raw
Quoted 13 lines · Po-Ying Chiu

Correct "drammatically" to "dramatically" in the rbtree.h header comment. This improves the readability of the header comment.

---
 include/linux/rbtree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/rbtree.h +0 -0
index 8d2ba3749866..78a7a260c36f 100644

include/linux/rbtree.h line 12

Quoted 7 lines
include/linux/rbtree.h +1 -1
@@ -7,7 +7,7 @@
   linux/include/linux/rbtree.h
 
   To use rbtrees you'll have to implement your own insert and search cores.
-  This will avoid us to use callbacks and to drop drammatically performances.
+  This will avoid us to use callbacks and to drop dramatically performances.
   I know it's not the cleaner way,  but in C (not in C++) to get
   performances and genericity...

Maybe the paragraph can be rephrased entierely, "drop dramatically performances" does not sound right to me.

#2 lore raw

PATCH v2 1/1 rbtree: Fix typo in header comment

Correct "drammatically" to "dramatically" in the rbtree.h header comment. This improves the readability of the header comment.

---
Changes since v1:
* Rephrased the whole paragraph to imporve readability.

 include/linux/rbtree.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/rbtree.h +4 -4
index 8d2ba3749866..02b6733cce55 100644
@@ -6,10 +6,10 @@
 
   linux/include/linux/rbtree.h
 
-  To use rbtrees you'll have to implement your own insert and search cores.
-  This will avoid us to use callbacks and to drop drammatically performances.
-  I know it's not the cleaner way,  but in C (not in C++) to get
-  performances and genericity...
+  To use rbtrees, you'll have to implement your own insert and search cores.
+  This avoids the need for callbacks, which would otherwise significantly reduce performance.
+  It may not be the cleanest approach, but in C (as opposed to C++), it is often
+  necessary to achieve both performance and genericity.
 
   See Documentation/core-api/rbtree.rst for documentation and samples.
 */
Signature · 1 line
2.43.0