Skip to contentSkip to conversation

PCI: fix the printed delay amount in info print

PATCH Superseded Wilfred Mallawa 2 participants 3 messages Apr 12, 2025 – Apr 14, 2025 PCI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: fix the printed delay amount in info print

From: Wilfred Mallawa <[email protected]>

Print the delay amount that pcie_wait_for_link_delay() is invoked with instead of the hardcoded 1000ms value in the debug info print.

Fixes 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait

time for slow links")

---
 drivers/pci/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci.c +1 -1
index 869d204a70a3..8139b70cafa9 100644
@@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
 		delay);
 	if (!pcie_wait_for_link_delay(dev, true, delay)) {
 		/* Did not train, no need to wait any further */
-		pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
+		pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
 		return -ENOTTY;
 	}
 
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Wilfred Mallawa

From: Wilfred Mallawa <[email protected]>

Print the delay amount that pcie_wait_for_link_delay() is invoked with instead of the hardcoded 1000ms value in the debug info print.

Fixes 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait

time for slow links")

Please remove the blank line here and do not wrap the Fixes tag line. With that fixed, looks OK to me. So feel free to add:

Quoted 18 lines
---
 drivers/pci/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci.c +1 -1
index 869d204a70a3..8139b70cafa9 100644
@@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
 		delay);
 	if (!pcie_wait_for_link_delay(dev, true, delay)) {
 		/* Did not train, no need to wait any further */
-		pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
+		pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
 		return -ENOTTY;
 	}
 
Signature · 2 lines
Damien Le Moal
Western Digital Research
#2 lore raw
Quoted 12 lines · Damien Le Moal
Quoted 10 lines · Wilfred Mallawa

From: Wilfred Mallawa <[email protected]>

Print the delay amount that pcie_wait_for_link_delay() is invoked with
instead of the hardcoded 1000ms value in the debug info print.

Fixes 7b3ba09febf4 ("PCI/PM: Shorten

pci_bridge_wait_for_secondary_bus() wait
time for slow links")

Quoted 4 lines

Please remove the blank line here and do not wrap the Fixes tag line. With that fixed, looks OK to me. So feel free to add:

Thanks! fixed in V2.

Wilfred

Quoted 24 lines
Quoted 22 lines

---
 drivers/pci/pci.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci.c +1 -1
index 869d204a70a3..8139b70cafa9 100644
@@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct
 pci_dev *dev, char *reset_type)
  		delay);
  	if (!pcie_wait_for_link_delay(dev, true, delay)) {
  		/* Did not train, no need to wait any further */
-		pci_info(dev, "Data Link Layer Link Active not set
 in 1000 msec\n");
+		pci_info(dev, "Data Link Layer Link Active not set
 in %d msec\n", delay);

  return -ENOTTY;
  }