bcachefs: Add missing error handling
PATCH 1/1 bcachefs: Add missing error handling
Reported-by [email protected]
Signed-off-by Alan Huang <[email protected]>
--- fs/bcachefs/recovery.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/bcachefs/recovery.c +4 -1
@@ -1125,7 +1125,10 @@ int bch2_fs_initialize(struct bch_fs *c)* journal_res_get() will crash if called before this has * set up the journal.pin FIFO and journal.cur pointer: */ -bch2_fs_journal_start (&c->journal,1 ); + ret =bch2_fs_journal_start (&c->journal,1 ); +if (ret) + goto err; +set_bit (BCH_FS_accounting_replay_done, &c->flags);bch2_journal_set_replay_done (&c->journal);
Signature · 1 line
2.48.1
Quoted 2 lines · Alan Huang
Reported-by [email protected]Signed-off-by Alan Huang <[email protected]>
This was a silly mistake.
In the past I've thought about going through and marking huge swaths of functions as __must_check, maybe that would actually be worth doing?
Quoted 23 lines
--- fs/bcachefs/recovery.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)fs/bcachefs/recovery.c +4
-1@@ -1125,7 +1125,10 @@ int bch2_fs_initialize(struct bch_fs *c)* journal_res_get() will crash if called before this has * set up the journal.pin FIFO and journal.cur pointer: */ -bch2_fs_journal_start (&c->journal,1 ); + ret =bch2_fs_journal_start (&c->journal,1 ); +if (ret) + goto err; +set_bit (BCH_FS_accounting_replay_done, &c->flags);bch2_journal_set_replay_done (&c->journal);Signature · 1 line
2.48.1
Quoted 9 lines · Kent Overstreet
Quoted 2 lines · Alan Huang
Reported-by [email protected]Signed-off-by Alan Huang <[email protected]>This was a silly mistake.
In the past I've thought about going through and marking huge swaths of functions as
__must_check, maybe that would actually be worth doing?
Yeah, that’s a good idea.
Quoted 24 lines
Quoted 24 lines
---
fs/bcachefs/recovery.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)fs/bcachefs/recovery.c +4
-1@@ -1125,7 +1125,10 @@ int bch2_fs_initialize(struct bch_fs *c)* journal_res_get() will crash if called before this has * set up the journal.pin FIFO and journal.cur pointer: */ -bch2_fs_journal_start (&c->journal,1 ); + ret =bch2_fs_journal_start (&c->journal,1 ); +if (ret) + goto err; +set_bit (BCH_FS_accounting_replay_done, &c->flags);bch2_journal_set_replay_done (&c->journal);Signature · 1 line
2.48.1