Skip to contentSkip to conversation

selftests: gpio: gpio-aggregator: add a test case for _sysfs prefix reservation

PATCH Applied Koichiro Den 2 participants 2 messages Apr 12, 2025 – Apr 14, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: gpio: gpio-aggregator: add a test case for _sysfs prefix reservation

The kernel doc for gpio-aggregator configfs interface, which was recently added, states that users should not be able to create an aggregator with a name prefixed by "_sysfs" via configfs. However, it was found that this guard does not function as expected (thanks to Dan Carpenter for identifying and fixing the issue).

Add a test case to verify the guard.

---
 tools/testing/selftests/gpio/gpio-aggregator.sh | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/gpio/gpio-aggregator.sh +4 -0
index f1bab62c4cd2..9b6f80ad9f8a 100755
@@ -335,6 +335,10 @@ test "$(cat "$CONFIGFS_AGG_DIR/agg0/live")" = 0 || \
 agg_remove_line   agg0 line0
 agg_remove_chip   agg0
 
+echo "1.1.6. Can't instantiate a chip with _sysfs prefix"
+mkdir "$CONFIGFS_AGG_DIR/_sysfs" 2> /dev/null && fail "chip _sysfs unexpectedly created"
+mkdir "$CONFIGFS_AGG_DIR/_sysfs.foo" 2> /dev/null && fail "chip _sysfs.foo unexpectedly created"
+
 echo "1.2. Creation/deletion via sysfs"
 
 echo "1.2.1. Minimum creation/deletion"
Signature · 1 line
2.45.2
#1 lore raw
Quoted 9 lines · Koichiro Den

The kernel doc for gpio-aggregator configfs interface, which was recently added, states that users should not be able to create an aggregator with a name prefixed by "_sysfs" via configfs. However, it was found that this guard does not function as expected (thanks to Dan Carpenter for identifying and fixing the issue).

Add a test case to verify the guard.

[...]

Applied, thanks!

[1/1] selftests: gpio: gpio-aggregator: add a test case for _sysfs prefix reservation

      https://git.kernel.org/brgl/linux/c/290ffcfe3042dcd5b701a98edd48d7962d35556b

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>