hw/arm: Attach PSPI module to NPCM8XX SoC
PATCH 1/1 hw/arm: Attach PSPI module to NPCM8XX SoC
Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Attach it to the NPCM8XX.
Tested:
NPCM8XX PSPI driver probed successfully from dmesg log.
--- hw/arm/npcm8xx.c | 11 ++++++++++- include/hw/arm/npcm8xx.h | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-)
hw/arm/npcm8xx.c +10 -1
@@ -67,6 +67,9 @@/* SDHCI Modules */ #define NPCM8XX_MMC_BA 0xf0842000 +/* PSPI Modules */ +#define NPCM8XX_PSPI_BA 0xf0201000 +/* Run PLL1 at 1600 MHz */ #define NPCM8XX_PLLCON1_FIXUP_VAL 0x00402101/* Run the CPU from PLL1 and UART from PLL2 */
@@ -83,6 +86,7 @@ enum NPCM8xxInterrupt {NPCM8XX_PECI_IRQ =6 ,NPCM8XX_KCS_HIB_IRQ =9 ,NPCM8XX_MMC_IRQ =26 , +NPCM8XX_PSPI_IRQ =28 ,NPCM8XX_TIMER0_IRQ =32 ,/* Timer Module 0 */ NPCM8XX_TIMER1_IRQ , NPCM8XX_TIMER2_IRQ,
@@ -441,6 +445,7 @@ static void npcm8xx_init(Object *obj) }object_initialize_child (obj,"mmc" , &s->mmc,TYPE_NPCM7XX_SDHCI ); +object_initialize_child (obj,"pspi" , &s->pspi,TYPE_NPCM_PSPI ); }static void npcm8xx_realize (DeviceState *dev,Error **errp)
@@ -705,6 +710,11 @@ static void npcm8xx_realize(DeviceState *dev, Error **errp)sysbus_connect_irq (SYS_BUS_DEVICE (&s->mmc),0 ,npcm8xx_irq (s,NPCM8XX_MMC_IRQ )); +/* PSPI */ +sysbus_realize (SYS_BUS_DEVICE (&s->pspi), &error_abort); +sysbus_mmio_map (SYS_BUS_DEVICE (&s->pspi),0 ,NPCM8XX_PSPI_BA ); +sysbus_connect_irq (SYS_BUS_DEVICE (&s->pspi),0 , +npcm8xx_irq (s,NPCM8XX_PSPI_IRQ ));create_unimplemented_device ("npcm8xx.shm" ,0xc0001000 ,4 * KiB);create_unimplemented_device ("npcm8xx.gicextra" ,0xdfffa000 ,24 * KiB);
@@ -720,7 +730,6 @@ static void npcm8xx_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("npcm8xx.siox[1]" ,0xf0101000 ,4 * KiB);create_unimplemented_device ("npcm8xx.siox[2]" ,0xf0102000 ,4 * KiB);create_unimplemented_device ("npcm8xx.tmps" ,0xf0188000 ,4 * KiB); -create_unimplemented_device ("npcm8xx.pspi" ,0xf0201000 ,4 * KiB);create_unimplemented_device ("npcm8xx.viru1" ,0xf0204000 ,4 * KiB);create_unimplemented_device ("npcm8xx.viru2" ,0xf0205000 ,4 * KiB);create_unimplemented_device ("npcm8xx.jtm1" ,0xf0208000 ,4 * KiB);
include/hw/arm/npcm8xx.h +2 -0
@@ -36,6 +36,7 @@#include "hw/usb/hcd-ehci.h" #include "hw/usb/hcd-ohci.h" #include "target/arm/cpu.h" +#include "hw/ssi/npcm_pspi.h" #define NPCM8XX_MAX_NUM_CPUS (4)
@@ -99,6 +100,7 @@ struct NPCM8xxState {OHCISysBusState ohci[2 ];NPCM7xxFIUState fiu[3 ];NPCM7xxSDHCIState mmc; +NPCMPSPIState pspi; };struct NPCM8xxClass {
Signature · 1 line
2.34.1
Quoted 11 lines · Tim Lee
Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Attach it to the NPCM8XX.
Tested:
NPCM8XX PSPI driver probed successfully from dmesg log.Signed-off-by Tim Lee <[email protected]>--- hw/arm/npcm8xx.c | 11 ++++++++++- include/hw/arm/npcm8xx.h | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-)
Hao Wu
Reviewed-byQuoted 7 lines · Philippe Mathieu-Daudé
Quoted 6 lines · Tim Lee
Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Attach it to the NPCM8XX.
Tested:
NPCM8XX PSPI driver probed successfully from dmesg log.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Tim Lee <[email protected]>--- hw/arm/npcm8xx.c | 11 ++++++++++- include/hw/arm/npcm8xx.h | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-)Reviewed-by Philippe Mathieu-Daudé <[email protected]>
From: Hao Wu <[email protected]>
Sent: Wednesday, April 23, 2025 5:09 AM
To: Philippe Mathieu-Daudé <[email protected]>
Cc: Tim Lee <[email protected]>; [email protected]; CS20 KFTing <[email protected]>; CS20 CHLi30 <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH] hw/arm: Attach PSPI module to NPCM8XX SoC
On Mon, Apr 14, 2025 at 3:43 AM Philippe Mathieu-Daudé <mailto:[email protected]> wrote:
Quoted 11 lines · Tim Lee
Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Attach it to the NPCM8XX.
Tested:
NPCM8XX PSPI driver probed successfully from dmesg log.Signed-off-by Tim Lee <mailto:[email protected]>--- hw/arm/npcm8xx.c | 11 ++++++++++- include/hw/arm/npcm8xx.h | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-)
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
Peter Maydell
AppliedQuoted 8 lines · Tim Lee
Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Attach it to the NPCM8XX.
Tested:
NPCM8XX PSPI driver probed successfully from dmesg log.Signed-off-by Tim Lee <[email protected]>
Applied to target-arm.next; thanks to everybody who reviewed this.
-- PMM