HID: wacom: handle kzalloc() allocation failure in wacom_wac_queue_flush()
Subsystems (2)
PATCH RESEND 1/1 HID: wacom: handle kzalloc() allocation failure in wacom_wac_queue_flush()
During wacom_wac_queue_flush() the code calls kzalloc() to allocate a zero initialised buffer which it uses as a storage buffer to get data from the fifo via kfifo_out(). However it does not check kzalloc() for allocation failure which returns NULL and could potentially lead to a NULL deref.
Fix this by checking for kzalloc() failure and skipping the current entry if allocation failure occurs.
--- drivers/hid/wacom_sys.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/hid/wacom_sys.c +7 -1
@@ -70,10 +70,16 @@ static void wacom_wac_queue_flush(struct hid_device *hdev, {while (!kfifo_is_empty (fifo)) {int size =kfifo_peek_len (fifo); -u8 *buf =kzalloc (size,GFP_KERNEL ); +u8 *buf;unsigned int count;int err; + buf =kzalloc (size,GFP_KERNEL ); +if (!buf) { +kfifo_skip (fifo); +continue ; + } + count =kfifo_out (fifo, buf, size);if (count != size) {// Hard to say what is the "right" action in this
Signature · 1 line
2.39.5
…
Quoted 3 lines
from the fifo via
kfifo_out(). However it does not checkkzalloc()for allocation failure which returns NULL and could potentially lead to a NULL deref.
…
pointer dereference?
I guess that word wrapping can occasionally become a bit nicer for text lines which may be longer than 52 characters.
Regards,
Markus