Skip to contentSkip to conversation

btrfs: fix comment in reserved space warning

PATCH In review Dan Johnson 2 participants 3 messages Apr 15, 2025 – May 28, 2025 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: fix comment in reserved space warning

mkfs.btrfs up to v4.14 actually can leave a chunk inside the reserved space when invoked with -m single, fixed by 997f9977c24397eb6980bb9 ("mkfs: Prevent temporary system chunk to use space in reserved 1M range") released with v4.15.

---
 fs/btrfs/volumes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/volumes.c +1 -1
index 4d5c5908300..28521015d01 100644
@@ -7989,7 +7989,7 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info,
 	}
 
 	/*
-	 * Very old mkfs.btrfs (before v4.1) will not respect the reserved
+	 * Very old mkfs.btrfs (before v4.15) will not respect the reserved
 	 * space. Although kernel can handle it without problem, better to warn
 	 * the users.
 	 */
Signature · 1 line
2.49.0
#1 lore raw

Gentle bump here, it looks like this got missed? I did a bunch of digging to figure that out and wanted to make sure to share it with others.

Quoted 27 lines · Dan Johnson

mkfs.btrfs up to v4.14 actually can leave a chunk inside the reserved space when invoked with -m single, fixed by 997f9977c24397eb6980bb9 ("mkfs: Prevent temporary system chunk to use space in reserved 1M range") released with v4.15.

---
 fs/btrfs/volumes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/volumes.c +1 -2
index 4d5c5908300..28521015d01 100644
@@ -7989,7 +7989,7 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info,
        }
 
        /*
-        * Very old mkfs.btrfs (before v4.1) will not respect the reserved
+        * Very old mkfs.btrfs (before v4.15) will not respect the reserved
         * space. Although kernel can handle it without problem, better to warn
         * the users.
         */
--

2.49.0

#2 lore raw
Quoted 3 lines · Dan Johnson

Gentle bump here, it looks like this got missed? I did a bunch of digging to figure that out and wanted to make sure to share it with others.

Not missed, but the timing near release and start of merge window can cause delays for patches that are not urgent fixes or such. Patch now added to for-next, thanks.