Skip to contentSkip to conversation

irqdomain: ppc: Switch to of_fwnode_handle()

PATCH In review Jiri Slaby (SUSE) 2 participants 3 messages Apr 15, 2025 – May 14, 2025 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqdomain: ppc: Switch to of_fwnode_handle()

of_node_to_fwnode() is irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.

Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Naveen N Rao <[email protected]>

---
This is an indepent patch, please apply directly.

The patch was previously a part of a large series [1], but I would like maintainers to feed the independent parts through their trees.

[1] https://lore.kernel.org/all/[email protected]/

---
 arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
 arch/powerpc/platforms/pseries/msi.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/powernv/pci-ioda.c +1 -1
index ae4b549b5ca0..d8ccf2c9b98a 100644
@@ -1897,7 +1897,7 @@ static int __init pnv_msi_allocate_domains(struct pci_controller *hose, unsigned
 		return -ENOMEM;
 	}
 
-	hose->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(hose->dn),
+	hose->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(hose->dn),
 						     &pnv_msi_domain_info,
 						     hose->dev_domain);
 	if (!hose->msi_domain) {
arch/powerpc/platforms/pseries/msi.c +1 -1
index f9d80111c322..5b191f70c088 100644
@@ -628,7 +628,7 @@ static int __pseries_msi_allocate_domains(struct pci_controller *phb,
 		return -ENOMEM;
 	}
 
-	phb->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(phb->dn),
+	phb->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(phb->dn),
 						    &pseries_msi_domain_info,
 						    phb->dev_domain);
 	if (!phb->msi_domain) {
Signature · 1 line
2.49.0
Reviewed-by Mahesh Salgaonkar on v1 1/1
#1 lore raw
Quoted 11 lines · Jiri Slaby (SUSE)

of_node_to_fwnode() is irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.

Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Naveen N Rao <[email protected]>
Quoted 5 lines

---
This is an indepent patch, please apply directly.

The patch was previously a part of a large series [1], but I would like maintainers to feed the independent parts through their trees.

Looks good to me.

Thanks,
-Mahesh.

Quoted 37 lines

[1] https://lore.kernel.org/all/[email protected]/

---
 arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
 arch/powerpc/platforms/pseries/msi.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/powernv/pci-ioda.c +1 -1
index ae4b549b5ca0..d8ccf2c9b98a 100644
@@ -1897,7 +1897,7 @@ static int __init pnv_msi_allocate_domains(struct pci_controller *hose, unsigned
 		return -ENOMEM;
 	}
 
-	hose->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(hose->dn),
+	hose->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(hose->dn),
 						     &pnv_msi_domain_info,
 						     hose->dev_domain);
 	if (!hose->msi_domain) {
arch/powerpc/platforms/pseries/msi.c +1 -1
index f9d80111c322..5b191f70c088 100644
@@ -628,7 +628,7 @@ static int __pseries_msi_allocate_domains(struct pci_controller *phb,
 		return -ENOMEM;
 	}
 
-	phb->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(phb->dn),
+	phb->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(phb->dn),
 						    &pseries_msi_domain_info,
 						    phb->dev_domain);
 	if (!phb->msi_domain) {
Signature · 1 line
2.49.0
Signature · 1 line
Mahesh J Salgaonkar
#2 lore raw
Quoted 15 lines · Mahesh J Salgaonkar
Quoted 14 lines · Jiri Slaby (SUSE)

of_node_to_fwnode() is irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead.

Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Naveen N Rao <[email protected]>

---
This is an indepent patch, please apply directly.

Quoted 6 lines
Quoted 2 lines

The patch was previously a part of a large series [1], but I would like maintainers to feed the independent parts through their trees.

Looks good to me.

Sorry for old email id. Please read it as

Quoted 3 lines

Thanks,
-Mahesh.