hfs{plus}: add deprecation warning
Subsystems (3)
Christian Brauner
maintainerPATCH 1/1 hfs{plus}: add deprecation warning
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
--- fs/hfs/super.c | 2 ++ fs/hfsplus/super.c | 2 ++ 2 files changed, 4 insertions(+)
fs/hfs/super.c +2 -0
@@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc) {struct hfs_sb_info *hsb; +pr_warn ("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + hsb =kzalloc (sizeof (struct hfs_sb_info ),GFP_KERNEL );if (!hsb)return -ENOMEM ;
fs/hfsplus/super.c +2 -0
@@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc) {struct hfsplus_sb_info *sbi; +pr_warn ("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + sbi =kzalloc (sizeof (struct hfsplus_sb_info ),GFP_KERNEL );if (!sbi)return -ENOMEM ;
Signature · 1 line
2.47.2
Quoted 6 lines · Christian Brauner
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
Signed-off-by Christian Brauner <[email protected]>
Looks good. And I agree hopefully it sparks interest in the maintainership because this is not completely useless filesystem:
Honza
Quoted 34 lines
--- fs/hfs/super.c | 2 ++ fs/hfsplus/super.c | 2 ++ 2 files changed, 4 insertions(+)fs/hfs/super.c +2
-0@@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc) {struct hfs_sb_info *hsb; +pr_warn ("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + hsb =kzalloc (sizeof (struct hfs_sb_info ),GFP_KERNEL );if (!hsb)return -ENOMEM ;fs/hfsplus/super.c +2
-0@@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc) {struct hfsplus_sb_info *sbi; +pr_warn ("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + sbi =kzalloc (sizeof (struct hfsplus_sb_info ),GFP_KERNEL );if (!sbi)return -ENOMEM ;Signature · 1 line
2.47.2
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 16 lines · Christian Brauner
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
Signed-off-by Christian Brauner <[email protected]>--- fs/hfs/super.c | 2 ++ fs/hfsplus/super.c | 2 ++ 2 files changed, 4 insertions(+)fs/hfs/super.c +0
-0
fs/hfs/super.c static int hfs_init_fs_context(struct fs_context *fc) · line 407
Quoted 4 lines
fs/hfs/super.c +1
-0@@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc) {struct hfs_sb_info *hsb; +pr_warn ("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" );
Does this mean before or after the 2025 LTS kernel is released? I would say that we ought to let this circulate more widely among users, but OTOH I guess no maintainer for a decade is really bad.
--D
Quoted 21 lines
fs/hfs/super.c +1
-0+ hsb =kzalloc (sizeof (struct hfs_sb_info ),GFP_KERNEL );if (!hsb)return -ENOMEM ;fs/hfsplus/super.c +2
-0@@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc) {struct hfsplus_sb_info *sbi; +pr_warn ("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + sbi =kzalloc (sizeof (struct hfsplus_sb_info ),GFP_KERNEL );if (!sbi)return -ENOMEM ;Signature · 1 line
2.47.2
Christian Brauner
maintainerQuoted 20 lines · Darrick J. Wong
Quoted 19 lines · Christian Brauner
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
Signed-off-by Christian Brauner <[email protected]>--- fs/hfs/super.c | 2 ++ fs/hfsplus/super.c | 2 ++ 2 files changed, 4 insertions(+)fs/hfs/super.c +0
-0@@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc) {struct hfs_sb_info *hsb;
Quoted 3 lines
fs/hfs/super.c static int hfs_init_fs_context(struct fs_context *fc) · line 407
Quoted 1 line
fs/hfs/super.c +1
-0+pr_warn ("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" );Does this mean before or after the 2025 LTS kernel is released? I would
I would've tried before the LTS release...
Quoted 1 line
say that we ought to let this circulate more widely among users, but
which is a valid point. The removal of reiserfs and sysv has been pretty surgically clean. So at least from my POV it should be simple enough to revert the removal. But I'm not dealing with stable kernels so I have no intuition about the pain involved.
Quoted 25 lines
OTOH I guess no maintainer for a decade is really bad.
--D
Quoted 21 lines
fs/hfs/super.c +1
-0+ hsb =kzalloc (sizeof (struct hfs_sb_info ),GFP_KERNEL );if (!hsb)return -ENOMEM ;fs/hfsplus/super.c +2
-0@@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc) {struct hfsplus_sb_info *sbi; +pr_warn ("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + sbi =kzalloc (sizeof (struct hfsplus_sb_info ),GFP_KERNEL );if (!sbi)return -ENOMEM ;Signature · 1 line
2.47.2
Darrick J. Wong
Acked-byQuoted 21 lines · Christian Brauner
Quoted 20 lines · Darrick J. Wong
Quoted 19 lines · Christian Brauner
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
Signed-off-by Christian Brauner <[email protected]>--- fs/hfs/super.c | 2 ++ fs/hfsplus/super.c | 2 ++ 2 files changed, 4 insertions(+)fs/hfs/super.c +0
-0@@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc) {struct hfs_sb_info *hsb;
Quoted 5 lines
Quoted 3 lines
fs/hfs/super.c static int hfs_init_fs_context(struct fs_context *fc) · line 407
Quoted 1 line
fs/hfs/super.c +1
-0+pr_warn ("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" );Does this mean before or after the 2025 LTS kernel is released? I would
I would've tried before the LTS release...
Well you still could. No better way to get an oft-ignored filesystem back into maintenance by throwing down a deprecation notice. :)
Quoted 6 lines
Quoted 1 line
say that we ought to let this circulate more widely among users, but
which is a valid point. The removal of reiserfs and sysv has been pretty surgically clean. So at least from my POV it should be simple enough to revert the removal. But I'm not dealing with stable kernels so I have no intuition about the pain involved.
It'll probably cause a lot of pain for the distributions that support PPC Macs because that's the only fs that the OF knows how to read for bootfiles. For dual-boot Intel Macs, their EFI partition is usually HFS+ and contains various system files (+ grub), but their EFI actually can read FAT. I have an old 2012 Mac Mini that runs exclusively Debian, and a FAT32 ESP works just fine.
Quoted 1 line
Quoted 1 line
OTOH I guess no maintainer for a decade is really bad.
On those grounds,
--D
Quoted 24 lines
Quoted 24 lines
--D
Quoted 21 lines
fs/hfs/super.c +1
-0+ hsb =kzalloc (sizeof (struct hfs_sb_info ),GFP_KERNEL );if (!hsb)return -ENOMEM ;fs/hfsplus/super.c +2
-0@@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc) {struct hfsplus_sb_info *sbi; +pr_warn ("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + sbi =kzalloc (sizeof (struct hfsplus_sb_info ),GFP_KERNEL );if (!sbi)return -ENOMEM ;Signature · 1 line
2.47.2
Quoted 67 lines · Darrick J. Wong
Quoted 21 lines · Christian Brauner
Quoted 20 lines · Darrick J. Wong
Quoted 19 lines · Christian Brauner
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
Signed-off-by Christian Brauner <[email protected]>--- fs/hfs/super.c | 2 ++ fs/hfsplus/super.c | 2 ++ 2 files changed, 4 insertions(+)fs/hfs/super.c +0
-0@@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc) {struct hfs_sb_info *hsb;Quoted 5 lines
Quoted 3 lines
fs/hfs/super.c static int hfs_init_fs_context(struct fs_context *fc) · line 407
Quoted 1 line
fs/hfs/super.c +1
-0+pr_warn ("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" );Does this mean before or after the 2025 LTS kernel is released? I would
I would've tried before the LTS release...
Well you still could. No better way to get an oft-ignored filesystem back into maintenance by throwing down a deprecation notice. :)
Quoted 6 lines
Quoted 1 line
say that we ought to let this circulate more widely among users, but
which is a valid point. The removal of reiserfs and sysv has been pretty surgically clean. So at least from my POV it should be simple enough to revert the removal. But I'm not dealing with stable kernels so I have no intuition about the pain involved.
It'll probably cause a lot of pain for the distributions that support PPC Macs because that's the only fs that the OF knows how to read for bootfiles. For dual-boot Intel Macs, their EFI partition is usually HFS+ and contains various system files (+ grub), but their EFI actually can read FAT. I have an old 2012 Mac Mini that runs exclusively Debian, and a FAT32 ESP works just fine.
Quoted 1 line
Quoted 1 line
OTOH I guess no maintainer for a decade is really bad.
On those grounds,
--D
Quoted 15 lines
Quoted 15 lines
--D
Quoted 12 lines
fs/hfs/super.c +1
-0+ hsb =kzalloc (sizeof (struct hfs_sb_info ),GFP_KERNEL );if (!hsb)return -ENOMEM ;fs/hfsplus/super.c +0
-0@@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc) {struct hfsplus_sb_info *sbi;
Quoted 10 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
fs/hfsplus/super.c +2
-0+pr_warn ("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n" ); + sbi =kzalloc (sizeof (struct hfsplus_sb_info ),GFP_KERNEL );if (!sbi)return -ENOMEM ;Signature · 1 line
2.47.2
I contributed to HFS+ file system driver more than 10 years ago. And I was completely discouraged because nobody maintained the HFS+ code base. But I would prefer to see the HFS+ in kernel tree instead of complete removal. As far as I can see, we are still receiving some patches for HFS/HFS+ code base. Nowadays, I am mostly busy with CephFS and SSDFS file systems. But if we need more systematic activity on HFS/HFS+, then I can find some time for HFS/HFS+ testing, bug fix, and pathes review. I am not sure that I would have enough time for HFS+ active development. But is it really that nobody would like to be the maintainer of HFS/HFS+? Have we asked the contributors and reviewers of HFS/HFS+?
Thanks,
Slava.
John Paul Adrian Glaubitz
maintainerHello Viacheslav,
Quoted 9 lines · Viacheslav Dubeyko
I contributed to HFS+ file system driver more than 10 years ago. And I was completely discouraged because nobody maintained the HFS+ code base. But I would prefer to see the HFS+ in kernel tree instead of complete removal. As far as I can see, we are still receiving some patches for HFS/HFS+ code base. Nowadays, I am mostly busy with CephFS and SSDFS file systems. But if we need more systematic activity on HFS/HFS+, then I can find some time for HFS/HFS+ testing, bug fix, and pathes review. I am not sure that I would have enough time for HFS+ active development. But is it really that nobody would like to be the maintainer of HFS/HFS+? Have we asked the contributors and reviewers of HFS/HFS+?
If you're willing to step up as a maintainer, I would be happy to assist you by testing and reviewing patches. I have PowerMacs available for testing and it's also possible to just install Debian's 32-bit and 64-bit PowerPC on an emulated PowerMac on QEMU using the "mac99" machine types to test booting from an HFS/HFS+ partition [1].
I am Debian's primary maintainer of these PowerPC ports in Debian (not to be confused with the little-endian PowerPC port) and I can also easily build various test images if needed.
Please let me know if you're interested in working together on the HFS/HFS+ driver.
Adrian
Quoted 1 line
[1] https://cdimage.debian.org/cdimage/ports/snapshots/2025-04-01/
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi Adrian,
Quoted 19 lines · John Paul Adrian Glaubitz
Hello Viacheslav,
Quoted 9 lines · Viacheslav Dubeyko
I contributed to HFS+ file system driver more than 10 years ago. And I was completely discouraged because nobody maintained the HFS+ code base. But I would prefer to see the HFS+ in kernel tree instead of complete removal. As far as I can see, we are still receiving some patches for HFS/HFS+ code base. Nowadays, I am mostly busy with CephFS and SSDFS file systems. But if we need more systematic activity on HFS/HFS+, then I can find some time for HFS/HFS+ testing, bug fix, and pathes review. I am not sure that I would have enough time for HFS+ active development. But is it really that nobody would like to be the maintainer of HFS/HFS+? Have we asked the contributors and reviewers of HFS/HFS+?
If you're willing to step up as a maintainer, I would be happy to assist you by testing and reviewing patches. I have PowerMacs available for testing and it's also possible to just install Debian's 32-bit and 64-bit PowerPC on an emulated PowerMac on QEMU using the "mac99" machine types to test booting from an HFS/HFS+ partition [1].
Quoted 6 lines
I am Debian's primary maintainer of these PowerPC ports in Debian (not to be confused with the little-endian PowerPC port) and I can also easily build various test images if needed.
Please let me know if you're interested in working together on the HFS/HFS+ driver.
Sounds good! Yes, I am interested in working together on the HFS/HFS+ driver. :) And, yes, I can consider to be the maintainer of HFS/HFS+ driver. We can maintain the HFS/HFS+ driver together because two maintainers are better than one. Especially, if there is the practical need of having HFS/HFS+ driver in Linux kernel.
Thanks,
Slava.
John Paul Adrian Glaubitz
maintainerHi Slava,
Quoted 5 lines · Viacheslav Dubeyko
Sounds good! Yes, I am interested in working together on the HFS/HFS+ driver. :) And, yes, I can consider to be the maintainer of HFS/HFS+ driver. We can maintain the HFS/HFS+ driver together because two maintainers are better than one. Especially, if there is the practical need of having HFS/HFS+ driver in Linux kernel.
OK, then let's do this together! While I'm already a kernel maintainer (for arch/sh), I wouldn't call myself an expert on filesystems and I feel way more comfortable working on this when there is a second person around with experience with hacking on filesystems.
Can you send a patch to update MAINTAINERS?
My mail entry would be:
John Paul Adrian Glaubitz <[email protected]>
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi Adrian,
Quoted 9 lines · John Paul Adrian Glaubitz
Hi Slava,
Quoted 5 lines · Viacheslav Dubeyko
Sounds good! Yes, I am interested in working together on the HFS/HFS+ driver. :) And, yes, I can consider to be the maintainer of HFS/HFS+ driver. We can maintain the HFS/HFS+ driver together because two maintainers are better than one. Especially, if there is the practical need of having HFS/HFS+ driver in Linux kernel.
Quoted 6 lines
OK, then let's do this together! While I'm already a kernel maintainer (for
arch/sh), I wouldn't call myself an expert on filesystems and I feel way more comfortable working on this when there is a second person around with experience with hacking on filesystems.Can you send a patch to update
MAINTAINERS?
Sure. Let me prepare the patch.
Thanks,
Slava.
Quoted 5 lines
My mail entry would be:
John Paul Adrian Glaubitz <[email protected]>
Adrian
Yangtao Li
maintainerHi Slava and Adrian,
Quoted 8 lines
Quoted 2 lines
Please let me know if you're interested in working together on the HFS/HFS+ driver.
Sounds good! Yes, I am interested in working together on the HFS/HFS+ driver. :) And, yes, I can consider to be the maintainer of HFS/HFS+ driver. We can maintain the HFS/HFS+ driver together because two maintainers are better than one. Especially, if there is the practical need of having HFS/HFS+ driver in Linux kernel.
Do you mind if there is one more person?
I used to maintain Allwinner SoC cpufreq and thermal drivers and have some work experience in the F2FS file system.
I have a MacBook laptop and can help verify and maintain patches if needed.
Thx,
Yangtao
Hi Yangtao,
Quoted 11 lines · Yangtao Li
Hi Slava and Adrian,
Quoted 8 lines
Quoted 2 lines
Please let me know if you're interested in working together on the HFS/HFS+ driver.
Sounds good! Yes, I am interested in working together on the HFS/HFS+ driver. :) And, yes, I can consider to be the maintainer of HFS/HFS+ driver. We can maintain the HFS/HFS+ driver together because two maintainers are better than one. Especially, if there is the practical need of having HFS/HFS+ driver in Linux kernel.
Quoted 7 lines
Do you mind if there is one more person?
I used to maintain Allwinner SoC cpufreq and thermal drivers and have some work experience in the F2FS file system.
I have a MacBook laptop and can help verify and maintain patches if needed.
Sounds good! I believe that three persons could be better for patches verification and discussions. I have no objections. :)
Thanks,
Slava.
John Paul Adrian Glaubitz
maintainerHi Yangtao,
Quoted 5 lines · Yangtao Li
Hi Slava and Adrian,
Quoted 3 lines
Quoted 2 lines
Please let me know if you're interested in working together on the HFS/HFS+ driver.
Quoted 7 lines
Quoted 5 lines
Sounds good! Yes, I am interested in working together on the HFS/HFS+ driver. :) And, yes, I can consider to be the maintainer of HFS/HFS+ driver. We can maintain the HFS/HFS+ driver together because two maintainers are better than one. Especially, if there is the practical need of having HFS/HFS+ driver in Linux kernel.
Do you mind if there is one more person?
Absolutely not. The more people we have, the better. I suggest that Slava maintains the tree and we're working with him to review and test patches since we both have the hardware at hands.
Quoted 4 lines
I used to maintain Allwinner SoC cpufreq and thermal drivers and have some work experience in the F2FS file system.
I have a MacBook laptop and can help verify and maintain patches if needed.
Perfect!
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
John Paul Adrian Glaubitz
maintainerHello Christian,
Quoted 4 lines · Christian Brauner
Both the hfs and hfsplus filesystem have been orphaned since at least 2014, i.e., over 10 years. It's time to remove them from the kernel as they're exhibiting more and more issues and no one is stepping up to fixing them.
I might be willing to take over maintainership as we definitely need this driver to stay for Debian Ports as otherwise we won't be able to boot PowerMacs using GRUB.
Developers on the grub-devel mailing list might be interested in this discussion as well as GRUB won't be usable anymore on PowerMacs with HFS/HFS+ being removed from the kernel.
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913