Skip to contentSkip to conversation

arm64: dts: nuvoton: Add USB Hosts

PATCH In review William A. Kennington III 4 participants 6 messages Apr 16, 2025 – May 7, 2025

Subsystems (2)
Device tree bindings Arm/nuvoton npcm architecture
lore
Share & tools
lore

William A. Kennington III

author
#0 lore raw

PATCH 1/1 arm64: dts: nuvoton: Add USB Hosts

The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support already existing in the kernel.

Signed-off-by William A. Kennington III <[email protected]>
---
 .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi +28 -0
index ccebcb11c05e..b2595f5c146b 100644
@@ -63,6 +63,34 @@ mc: memory-controller@f0824000 {
 			status = "disabled";
 		};
 
+		ehci0: usb@f0828100 {
+			compatible = "nuvoton,npcm750-ehci";
+			reg = <0x0 0xf0828100 0x0 0xf00>;
+			interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		ehci1: usb@f082a100 {
+			compatible = "nuvoton,npcm750-ehci";
+			reg = <0x0 0xf082a100 0x0 0xf00>;
+			interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		ohci0: usb@f0829000 {
+			compatible = "generic-ohci";
+			reg = <0x0 0xf0829000 0x0 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		ohci1: usb@f082b000 {
+			compatible = "generic-ohci";
+			reg = <0x0 0xf082b000 0x0 0x1000>;
+			interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		apb {
 			#address-cells = <1>;
 			#size-cells = <1>;
Signature · 1 line
2.49.0.604.gff1f9ca942-goog
#1 lore raw
Quoted 6 lines · William A. Kennington III

The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support already existing in the kernel.

Signed-off-by William A. Kennington III <[email protected]>
---
 .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++

Please do not send 10 separate patches, but one patchset for given subsystem.

Quoted 1 line
 1 file changed, 28 insertions(+)

Best regards,
Krzysztof

maintainer
#2 lore raw

Hi Krzysztof,

Thanks a lot for your review.

Can we send one patch that includes all nodes that are existing NPCM8xx drivers in the kernel, or do you prefer a patchset that contains patches for each NPCM8xx driver?

Thanks,

Tomer

Quoted 18 lines · Krzysztof Kozlowski
Quoted 6 lines · William A. Kennington III

The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support already existing in the kernel.

Signed-off-by William A. Kennington III <[email protected]>
---
 .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++

Please do not send 10 separate patches, but one patchset for given subsystem.

Quoted 1 line
 1 file changed, 28 insertions(+)

Best regards,
Krzysztof

author
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 11 lines · Krzysztof Kozlowski
Quoted 6 lines · William A. Kennington III

The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support already existing in the kernel.

Signed-off-by William A. Kennington III <[email protected]>
---
 .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++

Please do not send 10 separate patches, but one patchset for given subsystem.

When I send a patchset should I add the reply-to tags for all of these previous reviews? Or just resend as a new review?

Quoted 7 lines
Quoted 2 lines
 1 file changed, 28 insertions(+)

Best regards,
Krzysztof

#4 lore raw
Quoted 10 lines · William Kennington
Quoted 9 lines · Krzysztof Kozlowski
Quoted 6 lines · William A. Kennington III

The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support already existing in the kernel.

Signed-off-by William A. Kennington III <[email protected]>
---
 .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++
Quoted 5 lines
Quoted 2 lines

Please do not send 10 separate patches, but one patchset for given subsystem.

When I send a patchset should I add the reply-to tags for all of these previous reviews? Or just resend as a new review?

I don't understand what you are asking me. You NEVER add manually in-reply to. You should use either git send-email or b4 or patman. Nothing else, no manual edits, no weird headers.

If you ask about review, that's entirely different topic - see submitting patches. BTW, kernel docs also explain how to actually send these emails...

Best regards,
Krzysztof