Skip to contentSkip to conversation

mkfs: fix blkid probe API violations causing weird output

PATCH In review Darrick J. Wong 2 participants 4 messages Apr 16, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mkfs: fix blkid probe API violations causing weird output

From: Darrick J. Wong <[email protected]>

The blkid_do_fullprobe function in libblkid 2.38.1 will try to read the last 512 bytes off the end of a block device. If the block device has a 2k LBA size, that read will fail. blkid_do_fullprobe passes the -EIO back to the caller (mkfs) even though the API documentation says it only returns 1, 0, or -1.

Change the "cannot detect existing fs" logic to look for any negative number. Otherwise, you get unhelpful output like this:

$ mkfs.xfs -l size=32m -b size=4096 /dev/loop3
mkfs.xfs: Use the -f option to force overwrite.
---
 libxfs/topology.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
libxfs/topology.c +2 -1
index 8c6affb4c4e436..96ee74b61b30f5 100644
@@ -205,7 +205,8 @@ check_overwrite(
 out:
 	if (pr)
 		blkid_free_probe(pr);
-	if (ret == -1)
+	/* libblkid 2.38.1 lies and can return -EIO */
+	if (ret < 0)
 		fprintf(stderr,
 			_("%s: probe of %s failed, cannot detect "
 			  "existing filesystem.\n"), progname, device);
Reviewed-by on v1 1/1
#1 lore raw

libxfs/topology.c check_overwrite( · line 208

Quoted 1 line · Darrick J. Wong
libxfs/topology.c +1 -0
+	/* libblkid 2.38.1 lies and can return -EIO */

Can you expand this comment be less terse using the wording in the commit message? Otherwise looks good:

Did you also report the bug to util-linux so that it gets fixed there?

#2 lore raw
Quoted 5 lines · Christoph Hellwig

libxfs/topology.c check_overwrite( · line 208

Quoted 1 line · Darrick J. Wong
libxfs/topology.c +1 -0
+	/* libblkid 2.38.1 lies and can return -EIO */

Can you expand this comment be less terse using the wording in the commit message? Otherwise looks good:

Ok.

Quoted 3 lines

Did you also report the bug to util-linux so that it gets fixed there?

I'm not even sure how to categorize it -- the API docs all say things like this:

* Returns: 0 on success, 1 if nothing is detected or -1 on case of error. */
int blkid_do_fullprobe(blkid_probe pr)

But then you look at the probe functions that it calls:

static int probe_xfs(blkid_probe pr, const struct blkid_idmag *mag)

{
	struct xfs_super_block *xs;

	xs = blkid_probe_get_sb(pr, mag, struct xfs_super_block);
	if (!xs)
		return errno ? -errno : 1;

or:

static int probe_apfs(blkid_probe pr, const struct blkid_idmag *mag)

{
	struct apfs_super_block *sb;

	sb = blkid_probe_get_sb(pr, mag, struct apfs_super_block);
	if (!sb)
		return errno ? -errno : BLKID_PROBE_NONE;

So I guess it's just ... super broken?

--D

#3 lore raw
Quoted 9 lines · Darrick J. Wong

static int probe_apfs(blkid_probe pr, const struct blkid_idmag *mag)

{
	struct apfs_super_block *sb;

	sb = blkid_probe_get_sb(pr, mag, struct apfs_super_block);
	if (!sb)
		return errno ? -errno : BLKID_PROBE_NONE;

So I guess it's just ... super broken?

Heh. Please just send this report to the util-linux list.