kunit: qemu_configs: Disable faulting tests on 32-bit SPARC
PATCH 1/1 kunit: qemu_configs: Disable faulting tests on 32-bit SPARC
The 32-bit sparc configuration (--arch sparc) crashes on
the kunit_fault_test. It's known that some architectures don't handle deliberate segfaults in kernel mode well, so there's a config switch to disable tests which rely upon it by default.
Use this for the sparc config, making sure the default config for it passes.
---
Another quick fix to the sparc qemu_config I noticed while testing [1].
--- tools/testing/kunit/qemu_configs/sparc.py | 1 + 1 file changed, 1 insertion(+)
tools/testing/kunit/qemu_configs/sparc.py +1 -0
@@ -2,6 +2,7 @@ from ..qemu_config import QemuArchParams QEMU_ARCH = QemuArchParams(linux_arch='sparc', kconfig=''' +CONFIG_KUNIT_FAULT_TEST=n CONFIG_SPARC32=y CONFIG_SERIAL_SUNZILOG=y CONFIG_SERIAL_SUNZILOG_CONSOLE=y
Signature · 1 line
2.49.0.604.gff1f9ca942-goog
Quoted 10 lines · David Gow
The 32-bit sparc configuration (--arch sparc) crashes on
thekunit_fault_test. It's known that some architectures don't handle deliberate segfaults in kernel mode well, so there's a config switch to disable tests which rely upon it by default.Use this for the sparc config, making sure the default config for it passes.
Fixes 87c9c1631788 ("kunit: tool: add support for QEMU")Signed-off-by David Gow <[email protected]>
Thanks!
I am wondering if this should instead be done in lib/kunit/Kconfig. Not all users of kunit are guaranteed to use kunit.py.
In any case:
FYI the usercopy test is also broken:
[12:05:43] # usercopy_test_valid: EXPECTATION FAILED at lib/tests/usercopy_kunit.c:209
[12:05:43] Expected val_u64 == 0x5a5b5c5d6a6b6c6d, but
[12:05:43] val_u64 == 1515936861 (0x5a5b5c5d)
[12:05:43] 0x5a5b5c5d6a6b6c6d == 6510899242581322861 (0x5a5b5c5d6a6b6c6d)
[12:05:43] legitimate get_user (u64) failed to do copy [12:05:43] [FAILED] usercopy_test_valid
I can send a patch for that later,
but if you are on it anyways that would work for me, too.
Quoted 23 lines
---
Another quick fix to the sparc
qemu_configI noticed while testing [1].--- tools/testing/kunit/qemu_configs/sparc.py | 1 + 1 file changed, 1 insertion(+)tools/testing/kunit/qemu_configs/sparc.py +1
-0@@ -2,6 +2,7 @@ from ..qemu_config import QemuArchParams QEMU_ARCH = QemuArchParams(linux_arch='sparc', kconfig=''' +CONFIG_KUNIT_FAULT_TEST=n CONFIG_SPARC32=y CONFIG_SERIAL_SUNZILOG=y CONFIG_SERIAL_SUNZILOG_CONSOLE=ySignature · 1 line
2.49.0.604.gff1f9ca942-goog