Skip to contentSkip to conversation

parser: fix f referenced before assignment

PATCH New [email protected] 1 participant 1 message Apr 16, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parser: fix f referenced before assignment

From: Thomas Perrot <[email protected]>

These changes fix the following error, which occurs because the variable "f" can be used without being properly assigned or initialized first:
File "Post/parser.py", line 98, in parse
num_similar_errors = f.get_similar_fails_count()
UnboundLocalError: local variable 'f' referenced before assignment

---
 Post/parser.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Post/parser.py +5 -1
index 536e87226189..2fedde665042 100644
@@ -68,6 +68,7 @@ class Parser:
         except Exception as e:
             return { 'error' : "Problem reading json payload, %s" % e.message }
 
+        f = None
         for fail in failures:
             if len(fail) > int(settings.MAX_UPLOAD_SIZE):
                 build_fails_logged.append({ 'id': -1, 'error' : "The size of the upload is too large" })
@@ -95,7 +96,10 @@ class Parser:
 
         build_url = request.build_absolute_uri(reverse('build_errors', args=[b.id]))
 
-        num_similar_errors = f.get_similar_fails_count()
+        if f is not None:
+            num_similar_errors = f.get_similar_fails_count()
+        else:
+            num_similar_errors = 0
 
         result = { 'build_id' : b.id,
                    'build_url' : build_url,
Signature · 1 line
2.49.0