xfs_protofile: fix permission octet when suid/guid is set
PATCH v3 1/1 xfs_protofile: fix permission octet when suid/guid is set
When encountering suid or sgid files, we already set the u or g property in the prototype file.
Given that proto.c only supports three numbers for permissions, we need to remove the redundant information from the permission, else it was incorrectly parsed.
[v1] -> [v2]
Improve masking as suggested
[v2] -> [v3]
Fix typo
Co-authored-by Luca Di Maio <[email protected]>
Co-authored-by Darrick J. Wong <[email protected]>
Reviewed-by "Darrick J. Wong" <[email protected]>
Signed-off-by Luca Di Maio <[email protected]>
--- mkfs/xfs_protofile.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
mkfs/xfs_protofile.in +3 -1
@@ -43,7 +43,9 @@ def stat_to_str(statbuf): else: sgid = '-' - perms = stat.S_IMODE(statbuf.st_mode) + # We already register suid in the proto string, no need + # to also represent it into the octet + perms = stat.S_IMODE(statbuf.st_mode) & 0o777 return '%s%s%s%03o %d %d' % (type, suid, sgid, perms, statbuf.st_uid, \ statbuf.st_gid)
--
2.49.0