cpufreq: fix compile-test defaults
Subsystems (2)
PATCH v3 1/1 cpufreq: fix compile-test defaults
Commit 3f66425a4fc8 ("cpufreq: Enable COMPILE_TEST on Arm drivers") enabled compile testing of most Arm CPUFreq drivers but left the existing default values unchanged so that many drivers are enabled by default whenever COMPILE_TEST is selected.
This specifically results in the S3C64XX CPUFreq driver being enabled and initialised during boot of non-S3C64XX platforms with the following error logged:
cpufreq: Unable to obtain ARMCLK: -2
Commit d4f610a9bafd ("cpufreq: Do not enable by default during compile testing") recently fixed most of the default values, but two entries were missed and two could use a more specific default condition.
Fix the default values for drivers that can be compile tested and that should be enabled by default when not compile testing.
---
Changes in v3:
- use stable backport dependency notation instead of a Fixes tag for the partial fix
Changes in v2:
- rebase on commit d4f610a9bafd ("cpufreq: Do not enable by default during compile testing")
drivers/cpufreq/Kconfig.arm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/cpufreq/Kconfig.arm +4 -4
@@ -76,7 +76,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_BRCMSTB_AVS_CPUFREQ tristate "Broadcom STB AVS CPUfreq driver" depends on (ARCH_BRCMSTB && !ARM_SCMI_CPUFREQ) || COMPILE_TEST - default ARCH_BRCMSTB + default y if ARCH_BRCMSTB && !ARM_SCMI_CPUFREQ help Some Broadcom STB SoCs use a co-processor running proprietary firmware ("AVS") to handle voltage and frequency scaling. This driver provides
@@ -88,7 +88,7 @@ config ARM_HIGHBANK_CPUFREQ tristate "Calxeda Highbank-based" depends on ARCH_HIGHBANK || COMPILE_TEST depends on CPUFREQ_DT && REGULATOR && PL320_MBOX - default m + default m if ARCH_HIGHBANK help This adds the CPUFreq driver for Calxeda Highbank SoC based boards.
@@ -133,7 +133,7 @@ config ARM_MEDIATEK_CPUFREQ config ARM_MEDIATEK_CPUFREQ_HW tristate "MediaTek CPUFreq HW driver" depends on ARCH_MEDIATEK || COMPILE_TEST - default m + default m if ARCH_MEDIATEK help Support for the CPUFreq HW driver. Some MediaTek chipsets have a HW engine to offload the steps
@@ -256,7 +256,7 @@ config ARM_TEGRA194_CPUFREQ tristate "Tegra194 CPUFreq support" depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || (64BIT && COMPILE_TEST) depends on TEGRA_BPMP - default ARCH_TEGRA + default ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC help This adds CPU frequency driver support for Tegra194 SOCs.
Signature · 1 line
2.49.0
Quoted 11 lines · Johan Hovold
Commit
3f66425a4fc8("cpufreq: EnableCOMPILE_TESTon Arm drivers") enabled compile testing of most Arm CPUFreq drivers but left the existing default values unchanged so that many drivers are enabled by default wheneverCOMPILE_TESTis selected.This specifically results in the S3C64XX CPUFreq driver being enabled and initialised during boot of non-S3C64XX platforms with the following error logged:
cpufreq: Unable to obtain ARMCLK: -2
Quoted 8 lines
Commit
d4f610a9bafd("cpufreq: Do not enable by default during compile testing") recently fixed most of the default values, but two entries were missed and two could use a more specific default condition.Fix the default values for drivers that can be compile tested and that should be enabled by default when not compile testing.
Fixes 3f66425a4fc8 ("cpufreq: Enable COMPILE_TEST on Arm drivers")
I would not consider original code a bug, but a feature, however I am fine with other choice as well, so to close discussion from my side:
Best regards,
Krzysztof
Quoted 19 lines · Krzysztof Kozlowski
Quoted 18 lines · Johan Hovold
Commit
3f66425a4fc8("cpufreq: EnableCOMPILE_TESTon Arm drivers") enabled compile testing of most Arm CPUFreq drivers but left the existing default values unchanged so that many drivers are enabled by default wheneverCOMPILE_TESTis selected.This specifically results in the S3C64XX CPUFreq driver being enabled and initialised during boot of non-S3C64XX platforms with the following error logged:
cpufreq: Unable to obtain ARMCLK: -2
Commit
d4f610a9bafd("cpufreq: Do not enable by default during compile testing") recently fixed most of the default values, but two entries were missed and two could use a more specific default condition.Fix the default values for drivers that can be compile tested and that should be enabled by default when not compile testing.
Quoted 6 lines
Quoted 1 line
Fixes 3f66425a4fc8 ("cpufreq: Enable COMPILE_TEST on Arm drivers")I would not consider original code a bug, but a feature, however I am fine with other choice as well, so to close discussion from my side:
Reviewed-by Krzysztof Kozlowski <[email protected]>
Applied. Thanks.
Signature · 1 line
viresh