Skip to contentSkip to conversation

i2c: ismt: Use non-hybrid PCI devres API

PATCH Applied Philipp Stanner 2 participants 3 messages Apr 17, 2025 – May 5, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 i2c: ismt: Use non-hybrid PCI devres API

ismt enables its PCI device with pcim_enable_device(). This, implicitly, switches the function pci_request_region() into managed mode, where it becomes a devres function.

The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_region() with one to the always-managed pcim_request_region().

---
 drivers/i2c/busses/i2c-ismt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-ismt.c +1 -1
index c93c02aa6ac8..7aaefb21416a 100644
@@ -933,7 +933,7 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		return err;
 	}
 
-	err = pci_request_region(pdev, SMBBAR, ismt_driver.name);
+	err = pcim_request_region(pdev, SMBBAR, ismt_driver.name);
 	if (err) {
 		dev_err(&pdev->dev,
 			"Failed to request SMBus region 0x%lx-0x%lx\n",
Signature · 1 line
2.48.1
#1 lore raw

PATCH 2/2 i2c: thunderx: Use non-hybrid PCI devres API

thunderx enables its PCI device with pcim_enable_device(). This, implicitly, switches the function pci_request_regions() into managed mode, where it becomes a devres function.

The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_regions() with one to the always-managed pcim_request_all_regions().

---
 drivers/i2c/busses/i2c-thunderx-pcidrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-thunderx-pcidrv.c +1 -1
index 143d012fa43e..93c18c99178d 100644
@@ -175,7 +175,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev,
 	if (ret)
 		return ret;
 
-	ret = pci_request_regions(pdev, DRV_NAME);
+	ret = pcim_request_all_regions(pdev, DRV_NAME);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.48.1
maintainer Applied
#2 lore raw
In reply to Philipp Stanner

Hi Philipp,

Quoted 4 lines · Philipp Stanner

ismt enables its PCI device with pcim_enable_device(). This, implicitly, switches the function pci_request_region() into managed mode, where it becomes a devres function.

Quoted 8 lines

The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_region() with one to the always-managed pcim_request_region().

merged to i2c/i2c-host.

Thanks,
Andi