Skip to contentSkip to conversation

mm/vmscan: Modify the assignment logic of the scan and total_scan variables

PATCH Applied Hao Ge 2 participants 2 messages Apr 17, 2025

Subsystems (3)
lore
Share & tools
lore

Hao Ge

author
#0 lore raw

PATCH 1/1 mm/vmscan: Modify the assignment logic of the scan and total_scan variables

From: Hao Ge <[email protected]>

The scan and total_scan variables can be initialized to 0 when they are defined, replacing the separate assignment statements.

---
 mm/vmscan.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
mm/vmscan.c +2 -4
index b620d74b0f66..bf360ac4f1cf 100644
@@ -1725,13 +1725,11 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan,
 	unsigned long nr_taken = 0;
 	unsigned long nr_zone_taken[MAX_NR_ZONES] = { 0 };
 	unsigned long nr_skipped[MAX_NR_ZONES] = { 0, };
-	unsigned long skipped = 0;
-	unsigned long scan, total_scan, nr_pages;
+	unsigned long skipped = 0, total_scan = 0, scan = 0;
+	unsigned long nr_pages;
 	unsigned long max_nr_skipped = 0;
 	LIST_HEAD(folios_skipped);
 
-	total_scan = 0;
-	scan = 0;
 	while (scan < nr_to_scan && !list_empty(src)) {
 		struct list_head *move_to = src;
 		struct folio *folio;
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Hao Ge

From: Hao Ge <[email protected]>

The scan and total_scan variables can be initialized to 0 when they are defined, replacing the separate assignment statements.

Quoted 24 lines
---
  mm/vmscan.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
mm/vmscan.c +2 -4
index b620d74b0f66..bf360ac4f1cf 100644
@@ -1725,13 +1725,11 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan,
  	unsigned long nr_taken = 0;
  	unsigned long nr_zone_taken[MAX_NR_ZONES] = { 0 };
  	unsigned long nr_skipped[MAX_NR_ZONES] = { 0, };
-	unsigned long skipped = 0;
-	unsigned long scan, total_scan, nr_pages;
+	unsigned long skipped = 0, total_scan = 0, scan = 0;
+	unsigned long nr_pages;
  	unsigned long max_nr_skipped = 0;
  	LIST_HEAD(folios_skipped);
 
-	total_scan = 0;
-	scan = 0;
  	while (scan < nr_to_scan && !list_empty(src)) {
  		struct list_head *move_to = src;
  		struct folio *folio;