Skip to contentSkip to conversation

powerpc: do not build ppc_save_regs.o always

PATCH Applied Jiri Slaby (SUSE) 3 participants 3 messages Apr 17, 2025 – May 4, 2025 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: do not build ppc_save_regs.o always

The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the conditions to enable the build of ppc_save_regs.o. But it failed to do so, in fact. The commit omitted to add a dollar sign.

Therefore, ppc_save_regs.o is built always these days (as "(CONFIG_PPC_BOOK3S)" is never an empty string).

Fix this by adding the missing dollar sign.

Fixes fc2a5a6161a2 ("powerpc/64s: ppc_save_regs is now needed for all 64s builds")
Cc Stephen Rothwell <[email protected]>
Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Naveen N Rao <[email protected]>
---
 arch/powerpc/kernel/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/Makefile +1 -1
index 6ac621155ec3..0c26b2412d17 100644
@@ -160,7 +160,7 @@ endif
 
 obj64-$(CONFIG_PPC_TRANSACTIONAL_MEM)	+= tm.o
 
-ifneq ($(CONFIG_XMON)$(CONFIG_KEXEC_CORE)(CONFIG_PPC_BOOK3S),)
+ifneq ($(CONFIG_XMON)$(CONFIG_KEXEC_CORE)$(CONFIG_PPC_BOOK3S),)
 obj-y				+= ppc_save_regs.o
 endif
 
Signature · 1 line
2.49.0
Acked-by on v1 1/1
#1 lore raw

Hi Jiri,

Quoted 10 lines · On Thu, 17 Apr 2025 12:53:05 +0200 "Jiri Slaby (SUSE)" <[email protected]>…

The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the conditions to enable the build of ppc_save_regs.o. But it failed to do so, in fact. The commit omitted to add a dollar sign.

Therefore, ppc_save_regs.o is built always these days (as "(CONFIG_PPC_BOOK3S)" is never an empty string).

Fix this by adding the missing dollar sign.

Quoted 9 lines
Fixes fc2a5a6161a2 ("powerpc/64s: ppc_save_regs is now needed for all 64s builds")
Cc Stephen Rothwell <[email protected]>
Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Naveen N Rao <[email protected]>

Thanks for that.

Only 7.5 years later :-) This shows why I should not have been fixing problems in linux-next, I should have only ever complained about them, like I do now :-)

Signature · 2 lines
Cheers,
Stephen Rothwell
maintainer Applied
#2 lore raw
In reply to Jiri Slaby (SUSE)
Quoted 8 lines · Jiri Slaby (SUSE)

The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the conditions to enable the build of ppc_save_regs.o. But it failed to do so, in fact. The commit omitted to add a dollar sign.

Therefore, ppc_save_regs.o is built always these days (as "(CONFIG_PPC_BOOK3S)" is never an empty string).

[...]

Applied to powerpc/next.

[1/1] powerpc: do not build ppc_save_regs.o always

      https://git.kernel.org/powerpc/c/497b7794aef03d525a5be05ae78dd7137c6861a5

Thanks