selftests/pcie_bwctrl: Fix test progs list
Subsystems (4)
Ilpo Järvinen
maintainerPATCH 1/1 selftests/pcie_bwctrl: Fix test progs list
The commit df6f8c4d72ae ("selftests/pcie_bwctrl: Add 'set_pcie_speed.sh' to TEST_PROGS") added set_pcie_speed.sh into TEST_PROGS but that script is a helper that is only being called by set_pcie_cooling_state.sh, not a test case itself. When set_pcie_speed.sh is in TEST_PROGS, selftest harness will execute also it leading to bwctrl selftest errors:
# selftests: pcie_bwctrl: set_pcie_speed.sh
# cat: /cur_state: No such file or directory
not ok 2 selftests: pcie_bwctrl: set_pcie_speed.sh # exit=1
Place set_pcie_speed.sh into TEST_FILES instead to have it included into installed test files but not execute it from the test harness.
---
I'm sorry I didn't realize this while the fix was submitted, I'm not that familiar with all the kselftest harness variables and the justification given for the fix sounded valid enough to raise any alarm bells in my mind that something would be off with the approach the fix patch used.
tools/testing/selftests/pcie_bwctrl/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/pcie_bwctrl/Makefile +2 -1
@@ -1,2 +1,3 @@ -TEST_PROGS = set_pcie_cooling_state.sh set_pcie_speed.sh +TEST_PROGS = set_pcie_cooling_state.sh +TEST_FILES = set_pcie_speed.sh include ../lib.mk
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
Signature · 1 line
2.39.5
Bjorn Helgaas
AppliedQuoted 11 lines · Ilpo Järvinen
The commit
df6f8c4d72ae("selftests/pcie_bwctrl: Add 'set_pcie_speed.sh' toTEST_PROGS") addedset_pcie_speed.shintoTEST_PROGSbut that script is a helper that is only being called byset_pcie_cooling_state.sh, not a test case itself. Whenset_pcie_speed.shis inTEST_PROGS, selftest harness will execute also it leading to bwctrl selftest errors:# selftests:
pcie_bwctrl:set_pcie_speed.sh
# cat: /cur_state: No such file or directory
not ok 2 selftests:pcie_bwctrl:set_pcie_speed.sh# exit=1
Quoted 6 lines
Place
set_pcie_speed.shintoTEST_FILESinstead to have it included into installed test files but not execute it from the test harness.Fixes df6f8c4d72ae ("selftests/pcie_bwctrl: Add 'set_pcie_speed.sh' to TEST_PROGS")Signed-off-by Ilpo Järvinen <[email protected]>
Applied to pci/for-linus for v6.15, thanks, Ilpo!
Quoted 24 lines
---
I'm sorry I didn't realize this while the fix was submitted, I'm not that familiar with all the kselftest harness variables and the justification given for the fix sounded valid enough to raise any alarm bells in my mind that something would be off with the approach the fix patch used.
tools/testing/selftests/pcie_bwctrl/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/testing/selftests/pcie_bwctrl/Makefile +2
-1@@ -1,2 +1,3 @@ -TEST_PROGS = set_pcie_cooling_state.sh set_pcie_speed.sh +TEST_PROGS = set_pcie_cooling_state.sh +TEST_FILES = set_pcie_speed.sh include ../lib.mkbase-commit:
0af2f6be1b4281385b618cb86ad946eded089ac8Signature · 1 line
2.39.5