Skip to contentSkip to conversation

bitmap-str: A couple of cleanups

PATCH Applied Andy Shevchenko 2 participants 4 messages Apr 17, 2025 – Apr 18, 2025 Bitmap API

lore
Share & tools
lore
#0 lore raw

v3 cover bitmap-str: A couple of cleanups

A couple of simple cleanups to the bitmap-str.h.

In v3:
- elaborated even more what is missing and why it's good to have (Yury)

In v2:
- filled the commit messages (Yury)

Andy Shevchenko (2):
bitmap-str: Get rid of 'extern' for function prototypes
bitmap-str: Add missing header(s)

 include/linux/bitmap-str.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Signature · 1 line
2.47.2
#1 lore raw

PATCH v3 1/2 bitmap-str: Get rid of 'extern' for function prototypes

The bitmap-str.h uses mixed style for function prototypes. Drop the 'extern' as it easier to read and makes style aligned with a new code in the kernel.

---
 include/linux/bitmap-str.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/bitmap-str.h +4 -4
index 17caeca94cab..d758b4809a3a 100644
@@ -4,10 +4,10 @@
 
 int bitmap_parse_user(const char __user *ubuf, unsigned int ulen, unsigned long *dst, int nbits);
 int bitmap_print_to_pagebuf(bool list, char *buf, const unsigned long *maskp, int nmaskbits);
-extern int bitmap_print_bitmask_to_buf(char *buf, const unsigned long *maskp,
-					int nmaskbits, loff_t off, size_t count);
-extern int bitmap_print_list_to_buf(char *buf, const unsigned long *maskp,
-					int nmaskbits, loff_t off, size_t count);
+int bitmap_print_bitmask_to_buf(char *buf, const unsigned long *maskp, int nmaskbits,
+				loff_t off, size_t count);
+int bitmap_print_list_to_buf(char *buf, const unsigned long *maskp, int nmaskbits,
+			     loff_t off, size_t count);
 int bitmap_parse(const char *buf, unsigned int buflen, unsigned long *dst, int nbits);
 int bitmap_parselist(const char *buf, unsigned long *maskp, int nmaskbits);
 int bitmap_parselist_user(const char __user *ubuf, unsigned int ulen,
Signature · 1 line
2.47.2
#2 lore raw

PATCH v3 2/2 bitmap-str: Add missing header(s)

In reply to Andy Shevchenko

bitmap-str.h is not self-contained, it uses bool type that is provided in types.h and it uses __user annotation that is guaranteed to be included with types.h. Add missing header(s) to follow IWYU (Include What You Use) principle.

---
 include/linux/bitmap-str.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/bitmap-str.h +2 -0
index d758b4809a3a..53d3e1b32d3d 100644
@@ -2,6 +2,8 @@
 #ifndef __LINUX_BITMAP_STR_H
 #define __LINUX_BITMAP_STR_H
 
+#include <linux/types.h>
+
 int bitmap_parse_user(const char __user *ubuf, unsigned int ulen, unsigned long *dst, int nbits);
 int bitmap_print_to_pagebuf(bool list, char *buf, const unsigned long *maskp, int nmaskbits);
 int bitmap_print_bitmask_to_buf(char *buf, const unsigned long *maskp, int nmaskbits,
Signature · 1 line
2.47.2
maintainer Applied
#3 lore raw
In reply to Andy Shevchenko
Quoted 1 line · Andy Shevchenko

A couple of simple cleanups to the bitmap-str.h.

Applied, thanks!

Thanks,
Yury

Quoted 15 lines

In v3:
- elaborated even more what is missing and why it's good to have (Yury)

In v2:
- filled the commit messages (Yury)

Andy Shevchenko (2):
bitmap-str: Get rid of 'extern' for function prototypes
bitmap-str: Add missing header(s)

 include/linux/bitmap-str.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Signature · 1 line
2.47.2