Skip to contentSkip to conversation

s390/crc32: Remove no-op module init and exit functions

PATCH In review Eric Biggers 2 participants 2 messages Apr 17, 2025 – Apr 21, 2025

Subsystems (2)
Crypto API s390
lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 s390/crc32: Remove no-op module init and exit functions

From: Eric Biggers <[email protected]>

Now that the crc32-s390 module init function is a no-op, there is no need to define it. Remove it. The removal of the init function also makes the exit function unnecessary, so remove that too.

Signed-off-by Eric Biggers <[email protected]>

---

I'll take this via the crc tree.

 arch/s390/lib/crc32-glue.c | 11 -----------
 1 file changed, 11 deletions(-)
arch/s390/lib/crc32-glue.c +0 -11
index 649ed7e8b99c..3c4b344417c1 100644
@@ -59,21 +59,10 @@
 
 DEFINE_CRC32_VX(crc32_le_arch, crc32_le_vgfm_16, crc32_le_base)
 DEFINE_CRC32_VX(crc32_be_arch, crc32_be_vgfm_16, crc32_be_base)
 DEFINE_CRC32_VX(crc32c_arch, crc32c_le_vgfm_16, crc32c_base)
 
-static int __init crc32_s390_init(void)
-{
-	return 0;
-}
-arch_initcall(crc32_s390_init);
-
-static void __exit crc32_s390_exit(void)
-{
-}
-module_exit(crc32_s390_exit);
-
 u32 crc32_optimizations(void)
 {
 	if (cpu_has_vx()) {
 		return CRC32_LE_OPTIMIZATION |
 		       CRC32_BE_OPTIMIZATION |

base-commit: 34a3ebfb22d694cc07addae5ce0a8f83139592bd

Signature · 1 line
2.49.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Now that the crc32-s390 module init function is a no-op, there is no need to define it. Remove it. The removal of the init function also makes the exit function unnecessary, so remove that too.

Quoted 7 lines
Signed-off-by Eric Biggers <[email protected]>

---

I'll take this via the crc tree.

 arch/s390/lib/crc32-glue.c | 11 -----------
 1 file changed, 11 deletions(-)
Acked-by Heiko Carstens <[email protected]>