FAILED: patch "[PATCH] thermal/drivers/mediatek/lvts: Disable Stage 3 thermal" failed to apply to 6.6-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x c612cbcdf603aefb3358b2e3964dcd5aa3f827a0
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025041721-net-slider-2204@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From c612cbcdf603aefb3358b2e3964dcd5aa3f827a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?=
<[email protected]>
Date: Mon, 13 Jan 2025 10:27:13 -0300
Subject: [PATCH] thermal/drivers/mediatek/lvts: Disable Stage 3 thermal
threshold
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The Stage 3 thermal threshold is currently configured during the controller initialization to 105 Celsius. From the kernel perspective, this configuration is harmful because:
* The stage 3 interrupt that gets triggered when the threshold is crossed is not handled in any way by the IRQ handler, it just gets cleared. Besides, the temperature used for stage 3 comes from the sensors, and the critical thermal trip points described in the Devicetree will already cause a shutdown when crossed (at a lower temperature, of 100 Celsius, for all SoCs currently using this driver).
* The only effect of crossing the stage 3 threshold that has been observed is that it causes the machine to no longer be able to enter suspend. Even if that was a result of a momentary glitch in the temperature reading of a sensor (as has been observed on the MT8192-based Chromebooks).
For those reasons, disable the Stage 3 thermal threshold configuration.
drivers/thermal/mediatek/lvts_thermal.c +2 -14
@@ -65,7 +65,7 @@#define LVTS_HW_FILTER 0x0#define LVTS_TSSEL_CONF 0x13121110#define LVTS_CALSCALE_CONF 0x300 -#define LVTS_MONINT_CONF 0x8300318C +#define LVTS_MONINT_CONF 0x0300318C#define LVTS_MONINT_OFFSET_SENSOR0 0xC#define LVTS_MONINT_OFFSET_SENSOR1 0x180
@@ -91,8 +91,6 @@#define LVTS_MSR_READ_TIMEOUT_US 400#define LVTS_MSR_READ_WAIT_US (LVTS_MSR_READ_TIMEOUT_US / 2) -#define LVTS_HW_TSHUT_TEMP 105000 -#define LVTS_MINIMUM_THRESHOLD 20000static int golden_temp =LVTS_GOLDEN_TEMP_DEFAULT ;
@@ -145,7 +143,6 @@ struct lvts_ctrl {struct lvts_sensor sensors[LVTS_SENSOR_MAX ];const struct lvts_data *lvts_data;u32 calibration[LVTS_SENSOR_MAX ]; -u32 hw_tshut_raw_temp;u8 valid_sensor_mask;int mode;void __iomem *base;
@@ -837,14 +834,6 @@ static int lvts_ctrl_init(struct device *dev, struct lvts_domain *lvts_td,*/ lvts_ctrl[i].mode = lvts_data->lvts_ctrl[i].mode; -/* -* The temperature to raw temperature must be done -* after initializing the calibration. -*/ - lvts_ctrl[i].hw_tshut_raw_temp = -lvts_temp_to_raw (LVTS_HW_TSHUT_TEMP , - lvts_data->temp_factor); - lvts_ctrl[i].low_thresh =INT_MIN ; lvts_ctrl[i].high_thresh =INT_MIN ; }
@@ -919,7 +908,6 @@ static int lvts_irq_init(struct lvts_ctrl *lvts_ctrl)* 10 : Selected sensor with bits 19-18 * 11 : Reserved */ -writel (BIT (16 ),LVTS_PROTCTL (lvts_ctrl->base));/* * LVTS_PROTTA : Stage 1 temperature threshold
@@ -932,8 +920,8 @@ static int lvts_irq_init(struct lvts_ctrl *lvts_ctrl)* * writel(0x0, LVTS_PROTTA(lvts_ctrl->base)); * writel(0x0, LVTS_PROTTB(lvts_ctrl->base)); +* writel(0x0, LVTS_PROTTC(lvts_ctrl->base)); */ -writel (lvts_ctrl->hw_tshut_raw_temp,LVTS_PROTTC (lvts_ctrl->base));/* * LVTS_MONINT : Interrupt configuration register